From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonas Lahtinen Subject: Re: [PATCH v3 23/33] drm/i915: Move module init/exit to i915_pci.c Date: Wed, 08 Jun 2016 11:57:54 +0300 Message-ID: <1465376274.5803.29.camel@linux.intel.com> References: <1464964636-3877-1-git-send-email-chris@chris-wilson.co.uk> <1464964636-3877-24-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTP id EE0566E935 for ; Wed, 8 Jun 2016 08:57:56 +0000 (UTC) In-Reply-To: <1464964636-3877-24-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gcGUsIDIwMTYtMDYtMDMgYXQgMTU6MzcgKzAxMDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBU aGUgbW9kdWxlIGluaXQvZXhpdCByb3V0aW5lcyBhcmUgYSB3cmFwcGVyIGFyb3VuZCB0aGUgUENJ IGRldmljZQo+IGluaXQvZXhpdCwgc28gbW92ZSB0aGVtIGFjcm9zcy4KPiAKPiBOb3RlIHRoYXQg aW4gb3JkZXIgdG8gYXZvaWQgZXhwb3J0aW5nIHRoZSBkcml2ZXIgc3RydWN0LCBpbnN0ZWFkIG9m Cj4gbWFuaXB1bGF0aW5nIGRyaXZlci5mZWF0dXJlcyBpbnNpZGUgaTkxNV9pbml0IHdlIGluc3Rl YWQgb3B0IHRvIHNpbXBseQo+IGV4aXQgaWYgaTkxNS5tb2Rlc2V0IGlzIGRpc2FibGVkLgo+IAo+ IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IENjOiBKb29uYXMg TGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+CgpMb29rcyBmaW5lIHRv IG1lLgoKUmV2aWV3ZWQtYnk6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4 LmludGVsLmNvbT4KCj4gLS0tCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIHwg NTEgKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiDCoGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfcGNpLmMgfCA0NSArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKy0KPiDCoDIgZmlsZXMgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggZGZjMDM4MDAwZTIxLi5l MzcxZDRlNzU4NzggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAtMjgsNyArMjgs NiBAQAo+IMKgICovCj4gwqAKPiDCoCNpbmNsdWRlIAo+IC0jaW5jbHVkZSAKPiDCoCNpbmNsdWRl IAo+IMKgI2luY2x1ZGUgCj4gwqAjaW5jbHVkZSAKPiBAQCAtMTU2Myw2ICsxNTYyLDkgQEAgaW50 IGk5MTVfZHJpdmVyX2xvYWQoc3RydWN0IHBjaV9kZXYgKnBkZXYsIGNvbnN0IHN0cnVjdCBwY2lf ZGV2aWNlX2lkICplbnQpCj4gwqAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2Owo+ IMKgCWludCByZXQ7Cj4gwqAKPiArCWlmIChpOTE1Lm51Y2xlYXJfcGFnZWZsaXApCj4gKwkJZHJp dmVyLmRyaXZlcl9mZWF0dXJlcyB8PSBEUklWRVJfQVRPTUlDOwo+ICsKPiDCoAlkZXZfcHJpdiA9 IGt6YWxsb2Moc2l6ZW9mKCpkZXZfcHJpdiksIEdGUF9LRVJORUwpOwo+IMKgCWlmIChkZXZfcHJp diA9PSBOVUxMKQo+IMKgCQlyZXR1cm4gLUVOT01FTTsKPiBAQCAtMjk4OSw1MCArMjk5MSwzIEBA IHN0YXRpYyBzdHJ1Y3QgZHJtX2RyaXZlciBkcml2ZXIgPSB7Cj4gwqAJLm1pbm9yID0gRFJJVkVS X01JTk9SLAo+IMKgCS5wYXRjaGxldmVsID0gRFJJVkVSX1BBVENITEVWRUwsCj4gwqB9Owo+IC0K PiAtc3RhdGljIGludCBfX2luaXQgaTkxNV9pbml0KHZvaWQpCj4gLXsKPiAtCWV4dGVybiBzdHJ1 Y3QgcGNpX2RyaXZlciBpOTE1X3BjaV9kcml2ZXI7Cj4gLQo+IC0JLyoKPiAtCcKgKiBFbmFibGUg S01TIGJ5IGRlZmF1bHQsIHVubGVzcyBleHBsaWNpdGx5IG92ZXJyaWRlbiBieQo+IC0JwqAqIGVp dGhlciB0aGUgaTkxNS5tb2Rlc2V0IHByYXJhbWV0ZXIgb3IgYnkgdGhlCj4gLQnCoCogdmdhX3Rl eHRfbW9kZV9mb3JjZSBib290IG9wdGlvbi4KPiAtCcKgKi8KPiAtCj4gLQlpZiAoaTkxNS5tb2Rl c2V0ID09IDApCj4gLQkJZHJpdmVyLmRyaXZlcl9mZWF0dXJlcyAmPSB+RFJJVkVSX01PREVTRVQ7 Cj4gLQo+IC0JaWYgKHZnYWNvbl90ZXh0X2ZvcmNlKCkgJiYgaTkxNS5tb2Rlc2V0ID09IC0xKQo+ IC0JCWRyaXZlci5kcml2ZXJfZmVhdHVyZXMgJj0gfkRSSVZFUl9NT0RFU0VUOwo+IC0KPiAtCWlm ICghKGRyaXZlci5kcml2ZXJfZmVhdHVyZXMgJiBEUklWRVJfTU9ERVNFVCkpIHsKPiAtCQkvKiBT aWxlbnRseSBmYWlsIGxvYWRpbmcgdG8gbm90IHVwc2V0IHVzZXJzcGFjZS4gKi8KPiAtCQlEUk1f REVCVUdfRFJJVkVSKCJLTVMgYW5kIFVNUyBkaXNhYmxlZC5cbiIpOwo+IC0JCXJldHVybiAwOwo+ IC0JfQo+IC0KPiAtCWlmIChpOTE1Lm51Y2xlYXJfcGFnZWZsaXApCj4gLQkJZHJpdmVyLmRyaXZl cl9mZWF0dXJlcyB8PSBEUklWRVJfQVRPTUlDOwo+IC0KPiAtCXJldHVybiBkcm1fcGNpX2luaXQo JmRyaXZlciwgJmk5MTVfcGNpX2RyaXZlcik7Cj4gLX0KPiAtCj4gLXN0YXRpYyB2b2lkIF9fZXhp dCBpOTE1X2V4aXQodm9pZCkKPiAtewo+IC0JZXh0ZXJuIHN0cnVjdCBwY2lfZHJpdmVyIGk5MTVf cGNpX2RyaXZlcjsKPiAtCj4gLQlpZiAoIShkcml2ZXIuZHJpdmVyX2ZlYXR1cmVzICYgRFJJVkVS X01PREVTRVQpKQo+IC0JCXJldHVybjsgLyogTmV2ZXIgbG9hZGVkIGEgZHJpdmVyLiAqLwo+IC0K PiAtCWRybV9wY2lfZXhpdCgmZHJpdmVyLCAmaTkxNV9wY2lfZHJpdmVyKTsKPiAtfQo+IC0KPiAt bW9kdWxlX2luaXQoaTkxNV9pbml0KTsKPiAtbW9kdWxlX2V4aXQoaTkxNV9leGl0KTsKPiAtCj4g LU1PRFVMRV9BVVRIT1IoIlR1bmdzdGVuIEdyYXBoaWNzLCBJbmMuIik7Cj4gLU1PRFVMRV9BVVRI T1IoIkludGVsIENvcnBvcmF0aW9uIik7Cj4gLQo+IC1NT0RVTEVfREVTQ1JJUFRJT04oRFJJVkVS X0RFU0MpOwo+IC1NT0RVTEVfTElDRU5TRSgiR1BMIGFuZCBhZGRpdGlvbmFsIHJpZ2h0cyIpOwo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9wY2kuYwo+IGluZGV4IDFjNzVlNWY3N2E0NS4uMjBhMDI2ZDkwYjM3 IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGNpLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BjaS5jCj4gQEAgLTIyLDYgKzIyLDcgQEAKPiDCoCAq Cj4gwqAgKi8KPiDCoAo+ICsjaW5jbHVkZSAKPiDCoCNpbmNsdWRlIAo+IMKgI2luY2x1ZGUgCj4g wqAKPiBAQCAtNDUxLDEwICs0NTIsNTIgQEAgc3RhdGljIHZvaWQgaTkxNV9wY2lfcmVtb3ZlKHN0 cnVjdCBwY2lfZGV2ICpwZGV2KQo+IMKgCj4gwqBleHRlcm4gY29uc3Qgc3RydWN0IGRldl9wbV9v cHMgaTkxNV9wbV9vcHM7Cj4gwqAKPiAtc3RydWN0IHBjaV9kcml2ZXIgaTkxNV9wY2lfZHJpdmVy ID0gewo+ICtzdGF0aWMgc3RydWN0IHBjaV9kcml2ZXIgaTkxNV9wY2lfZHJpdmVyID0gewo+IMKg CS5uYW1lID0gRFJJVkVSX05BTUUsCj4gwqAJLmlkX3RhYmxlID0gcGNpaWRsaXN0LAo+IMKgCS5w cm9iZSA9IGk5MTVfcGNpX3Byb2JlLAo+IMKgCS5yZW1vdmUgPSBpOTE1X3BjaV9yZW1vdmUsCj4g wqAJLmRyaXZlci5wbSA9ICZpOTE1X3BtX29wcywKPiDCoH07Cj4gKwo+ICtzdGF0aWMgaW50IF9f aW5pdCBpOTE1X2luaXQodm9pZCkKPiArewo+ICsJYm9vbCB1c2Vfa21zID0gdHJ1ZTsKPiArCj4g KwkvKgo+ICsJwqAqIEVuYWJsZSBLTVMgYnkgZGVmYXVsdCwgdW5sZXNzIGV4cGxpY2l0bHkgb3Zl cnJpZGVuIGJ5Cj4gKwnCoCogZWl0aGVyIHRoZSBpOTE1Lm1vZGVzZXQgcHJhcmFtZXRlciBvciBi eSB0aGUKPiArCcKgKiB2Z2FfdGV4dF9tb2RlX2ZvcmNlIGJvb3Qgb3B0aW9uLgo+ICsJwqAqLwo+ ICsKPiArCWlmIChpOTE1Lm1vZGVzZXQgPT0gMCkKPiArCQl1c2Vfa21zID0gZmFsc2U7Cj4gKwo+ ICsJaWYgKHZnYWNvbl90ZXh0X2ZvcmNlKCkgJiYgaTkxNS5tb2Rlc2V0ID09IC0xKQo+ICsJCXVz ZV9rbXMgPSBmYWxzZTsKPiArCj4gKwlpZiAoIXVzZV9rbXMpIHsKPiArCQkvKiBTaWxlbnRseSBm YWlsIGxvYWRpbmcgdG8gbm90IHVwc2V0IHVzZXJzcGFjZS4gKi8KPiArCQlEUk1fREVCVUdfRFJJ VkVSKCJLTVMgYW5kIFVNUyBkaXNhYmxlZC5cbiIpOwo+ICsJCXJldHVybiAwOwo+ICsJfQo+ICsK PiArCXJldHVybiBwY2lfcmVnaXN0ZXJfZHJpdmVyKCZpOTE1X3BjaV9kcml2ZXIpOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgdm9pZCBfX2V4aXQgaTkxNV9leGl0KHZvaWQpCj4gK3sKPiArCWlmICghaTkx NV9wY2lfZHJpdmVyLmRyaXZlci5vd25lcikKPiArCQlyZXR1cm47Cj4gKwo+ICsJcGNpX3VucmVn aXN0ZXJfZHJpdmVyKCZpOTE1X3BjaV9kcml2ZXIpOwo+ICt9Cj4gKwo+ICttb2R1bGVfaW5pdChp OTE1X2luaXQpOwo+ICttb2R1bGVfZXhpdChpOTE1X2V4aXQpOwo+ICsKPiArTU9EVUxFX0FVVEhP UigiVHVuZ3N0ZW4gR3JhcGhpY3MsIEluYy4iKTsKPiArTU9EVUxFX0FVVEhPUigiSW50ZWwgQ29y cG9yYXRpb24iKTsKPiArCj4gK01PRFVMRV9ERVNDUklQVElPTihEUklWRVJfREVTQyk7Cj4gK01P RFVMRV9MSUNFTlNFKCJHUEwgYW5kIGFkZGl0aW9uYWwgcmlnaHRzIik7Ci0tIApKb29uYXMgTGFo dGluZW4KT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKSW50ZWwgQ29ycG9yYXRpb24KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==