From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Lorenzo Pieralisi To: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 2/4] PCI: host-generic: claim bus resources on PCI_PROBE_ONLY set-ups Date: Wed, 8 Jun 2016 12:04:48 +0100 Message-Id: <1465383890-13538-3-git-send-email-lorenzo.pieralisi@arm.com> In-Reply-To: <1465383890-13538-1-git-send-email-lorenzo.pieralisi@arm.com> References: <1465383890-13538-1-git-send-email-lorenzo.pieralisi@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Russell King , Arnd Bergmann , David Daney , Catalin Marinas , Will Deacon , Bjorn Helgaas , Yinghai Lu MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: The PCI host generic driver does not reassign bus resources on systems that require the BARs set-up to be immutable (ie PCI_PROBE_ONLY) since that would trigger system failures. Nonetheless, PCI bus resources allocated to PCI bridge and devices must be claimed in order to be validated and inserted in the kernel resource tree, but the current driver omits the resources claiming and relies on arch specific kludges to prevent probing failure (ie preventing resources enablement on PCI_PROBE_ONLY systems). Add code to the PCI host generic driver that correctly claims bus resources upon probe on systems that are required to prevent reassignment after bus enumeration, so that the allocated resources can be enabled successfully upon PCI device drivers probing, without resorting to arch back-ends workarounds. Signed-off-by: Lorenzo Pieralisi Acked-by: Will Deacon Cc: Arnd Bergmann Cc: David Daney Cc: Will Deacon Cc: Bjorn Helgaas --- drivers/pci/host/pci-host-common.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pci-host-common.c b/drivers/pci/host/pci-host-common.c index 8cba7ab..1684882 100644 --- a/drivers/pci/host/pci-host-common.c +++ b/drivers/pci/host/pci-host-common.c @@ -154,8 +154,31 @@ int pci_host_common_probe(struct platform_device *pdev, } pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); - - if (!pci_has_flag(PCI_PROBE_ONLY)) { + /* + * For PCI bridges and PCI devices to be fully set-up, their + * resources must be initialized and inserted in the kernel + * resource tree, which implicitly means that the resources + * are correctly inserted in the kernel resource tree and are + * assigned a parent pointer to create the resource hierarchy. + * + * On PCI_PROBE_ONLY systems, the pci_bus_claim_resource() + * API claims the resources as set-up by firmware, which takes + * care of inserting them in the resource tree and setting their + * parent pointers accordingly. + * + * On !PCI_PROBE_ONLY systems, the firmware set-up is discarded, + * and resource assignment and insertion in the resource tree is + * carried out through the PCI resources API: + * + * (ie pci_bus_size_bridges() and pci_bus_assign_resources()) + * + * that sizes the bridges and assigns and inserts resources in the + * kernel resource tree (which also implies setting up their parent + * pointers), completing the resources set-up. + */ + if (pci_has_flag(PCI_PROBE_ONLY)) { + pci_bus_claim_resources(bus); + } else { pci_bus_size_bridges(bus); pci_bus_assign_resources(bus); -- 2.6.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) Date: Wed, 8 Jun 2016 12:04:48 +0100 Subject: [PATCH v3 2/4] PCI: host-generic: claim bus resources on PCI_PROBE_ONLY set-ups In-Reply-To: <1465383890-13538-1-git-send-email-lorenzo.pieralisi@arm.com> References: <1465383890-13538-1-git-send-email-lorenzo.pieralisi@arm.com> Message-ID: <1465383890-13538-3-git-send-email-lorenzo.pieralisi@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org The PCI host generic driver does not reassign bus resources on systems that require the BARs set-up to be immutable (ie PCI_PROBE_ONLY) since that would trigger system failures. Nonetheless, PCI bus resources allocated to PCI bridge and devices must be claimed in order to be validated and inserted in the kernel resource tree, but the current driver omits the resources claiming and relies on arch specific kludges to prevent probing failure (ie preventing resources enablement on PCI_PROBE_ONLY systems). Add code to the PCI host generic driver that correctly claims bus resources upon probe on systems that are required to prevent reassignment after bus enumeration, so that the allocated resources can be enabled successfully upon PCI device drivers probing, without resorting to arch back-ends workarounds. Signed-off-by: Lorenzo Pieralisi Acked-by: Will Deacon Cc: Arnd Bergmann Cc: David Daney Cc: Will Deacon Cc: Bjorn Helgaas --- drivers/pci/host/pci-host-common.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pci-host-common.c b/drivers/pci/host/pci-host-common.c index 8cba7ab..1684882 100644 --- a/drivers/pci/host/pci-host-common.c +++ b/drivers/pci/host/pci-host-common.c @@ -154,8 +154,31 @@ int pci_host_common_probe(struct platform_device *pdev, } pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci); - - if (!pci_has_flag(PCI_PROBE_ONLY)) { + /* + * For PCI bridges and PCI devices to be fully set-up, their + * resources must be initialized and inserted in the kernel + * resource tree, which implicitly means that the resources + * are correctly inserted in the kernel resource tree and are + * assigned a parent pointer to create the resource hierarchy. + * + * On PCI_PROBE_ONLY systems, the pci_bus_claim_resource() + * API claims the resources as set-up by firmware, which takes + * care of inserting them in the resource tree and setting their + * parent pointers accordingly. + * + * On !PCI_PROBE_ONLY systems, the firmware set-up is discarded, + * and resource assignment and insertion in the resource tree is + * carried out through the PCI resources API: + * + * (ie pci_bus_size_bridges() and pci_bus_assign_resources()) + * + * that sizes the bridges and assigns and inserts resources in the + * kernel resource tree (which also implies setting up their parent + * pointers), completing the resources set-up. + */ + if (pci_has_flag(PCI_PROBE_ONLY)) { + pci_bus_claim_resources(bus); + } else { pci_bus_size_bridges(bus); pci_bus_assign_resources(bus); -- 2.6.4