All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
To: mariano.lopez@linux.intel.com, bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] lib/bb/main.py: Fix use of BBPOSTCONF and BBPRECONF
Date: Wed, 08 Jun 2016 11:57:06 -0500	[thread overview]
Message-ID: <1465405026.19191.9.camel@linux.intel.com> (raw)
In-Reply-To: <1465302459-38277-1-git-send-email-mariano.lopez@linux.intel.com>

Looking good!

On Tue, 2016-06-07 at 12:27 +0000, mariano.lopez@linux.intel.com wrote:
> From: Mariano Lopez <mariano.lopez@linux.intel.com>
> 
> The functionality of BBPOSTCONF and BBPRECONF was added in
> commit 21b314d4d1e5b8fbeb4cc57006f0a110f0b3aa8f but there
> was a typo in the variable name that raises an exception
> in bitbake.
> 
> [YOCTO #9235]
> 
> Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com>
> ---
>  bitbake/lib/bb/main.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/bitbake/lib/bb/main.py b/bitbake/lib/bb/main.py
> index b296ef8..283f29b 100755
> --- a/bitbake/lib/bb/main.py
> +++ b/bitbake/lib/bb/main.py
> @@ -281,10 +281,10 @@ class
> BitBakeConfigParameters(cookerdata.ConfigParameters):
>  
>          # use configuration files from environment variables
>          if "BBPRECONF" in os.environ:
> -            option.prefile.append(os.environ["BBPRECONF"])
> +            options.prefile.append(os.environ["BBPRECONF"])
>  
>          if "BBPOSTCONF" in os.environ:
> -            option.postfile.append(os.environ["BBPOSTCONF"])
> +            options.postfile.append(os.environ["BBPOSTCONF"])
>  
>          # fill in proper log name if not supplied
>          if options.writeeventlog is not None and
> len(options.writeeventlog) == 0:
> -- 
> 2.6.6
> 


      reply	other threads:[~2016-06-08 16:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07 12:27 [PATCH] lib/bb/main.py: Fix use of BBPOSTCONF and BBPRECONF mariano.lopez
2016-06-08 16:57 ` Benjamin Esquivel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465405026.19191.9.camel@linux.intel.com \
    --to=benjamin.esquivel@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=mariano.lopez@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.