From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBCUn-00022t-3w for qemu-devel@nongnu.org; Thu, 09 Jun 2016 22:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBCUl-0006ww-AT for qemu-devel@nongnu.org; Thu, 09 Jun 2016 22:48:28 -0400 Received: from resqmta-po-01v.sys.comcast.net ([2001:558:fe16:19:96:114:154:160]:54572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBCUl-0006wf-5E for qemu-devel@nongnu.org; Thu, 09 Jun 2016 22:48:27 -0400 From: Eric Blake Date: Thu, 9 Jun 2016 20:48:07 -0600 Message-Id: <1465526889-8339-3-git-send-email-eblake@redhat.com> In-Reply-To: <1465526889-8339-1-git-send-email-eblake@redhat.com> References: <1465526889-8339-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH 2/4] checkpatch: There is no qemu_strtod() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, Blue Swirl Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironically, I had to use 'git commit -n' since checkpatch uses TAB indents, in violation of its own recommendations.) Signed-off-by: Eric Blake --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c939a32..cf32c8f 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2453,7 +2453,7 @@ sub process { } # recommend qemu_strto* over strto* for numeric conversions - if ($line =~ /\b(strto[^k].*?)\s*\(/) { + if ($line =~ /\b(strto[^kd].*?)\s*\(/) { WARN("consider using qemu_$1 in preference to $1\n" . $herecurr); } # check for module_init(), use category-specific init macros explicitly please -- 2.5.5