From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBPHW-0006id-EH for qemu-devel@nongnu.org; Fri, 10 Jun 2016 12:27:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBPHR-0007hE-94 for qemu-devel@nongnu.org; Fri, 10 Jun 2016 12:27:37 -0400 From: Sergey Sorokin Date: Fri, 10 Jun 2016 19:26:37 +0300 Message-Id: <1465575999-3594234-1-git-send-email-afarallax@yandex.ru> Subject: [Qemu-devel] [PATCH 0/2] Fix confusing argument names in some common functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Peter Maydell , "Edgar E. Iglesias" , Eduardo Habkost , Michael Walle , Aurelien Jarno , Leon Alrae , Anthony Green , Jia Liu , David Gibson , Alexander Graf , Blue Swirl , Mark Cave-Ayland , Bastian Koppelmann , Guan Xuetao , Max Filippov , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Sergey Sorokin There are functions tlb_fill(), cpu_unaligned_access() and do_unaligned_access() that are called with access type and mmu index arguments. But these arguments are named 'is_write' and 'is_user' in their declarations. The patches fix the names to avoid a confusion. Sergey Sorokin (2): Fix confusing argument names of do_unaligned_access() functions Fix a confusing argument name in tlb_fill() function include/exec/exec-all.h | 2 +- include/qom/cpu.h | 8 ++++---- target-alpha/cpu.h | 4 ++-- target-alpha/mem_helper.c | 8 ++++---- target-arm/internals.h | 4 ++-- target-arm/op_helper.c | 27 +++++++++++++++------------ target-cris/op_helper.c | 4 ++-- target-i386/mem_helper.c | 4 ++-- target-lm32/op_helper.c | 4 ++-- target-m68k/op_helper.c | 4 ++-- target-microblaze/op_helper.c | 4 ++-- target-mips/cpu.h | 4 ++-- target-mips/op_helper.c | 6 +++--- target-moxie/helper.c | 4 ++-- target-openrisc/mmu_helper.c | 4 ++-- target-ppc/mmu_helper.c | 6 +++--- target-s390x/mem_helper.c | 4 ++-- target-sh4/op_helper.c | 4 ++-- target-sparc/cpu.h | 5 +++-- target-sparc/ldst_helper.c | 9 +++++---- target-tricore/op_helper.c | 4 ++-- target-unicore32/op_helper.c | 4 ++-- target-xtensa/cpu.h | 4 ++-- target-xtensa/op_helper.c | 10 ++++++---- 24 files changed, 74 insertions(+), 67 deletions(-) -- 1.9.3