From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCoSg-0005Op-A1 for qemu-devel@nongnu.org; Tue, 14 Jun 2016 09:32:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCoSe-00065C-B1 for qemu-devel@nongnu.org; Tue, 14 Jun 2016 09:32:57 -0400 From: Kevin Wolf Date: Tue, 14 Jun 2016 15:32:35 +0200 Message-Id: <1465911155-19002-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1465911155-19002-1-git-send-email-kwolf@redhat.com> References: <1465911155-19002-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v2 6/6] block: Don't enforce 512 byte minimum alignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, famz@redhat.com, eblake@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org If block drivers say that they can do an alignment < 512 bytes, let's just suppose they mean it. raw-posix used to be an offender with respect to this, but it can actually deal with byte-aligned requests now. The default is still 512 bytes for any drivers that only implement sector-based interfaces, but it is 1 now for drivers that implement .bdrv_co_preadv. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c | 2 +- block/io.c | 8 +++----- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/block.c b/block.c index f54bc25..3d850a2 100644 --- a/block.c +++ b/block.c @@ -937,7 +937,7 @@ static int bdrv_open_common(BlockDriverState *bs, BdrvChild *file, goto fail_opts; } - bs->request_alignment = 512; + bs->request_alignment = drv->bdrv_co_preadv ? 1 : 512; bs->zero_beyond_eof = true; bs->read_only = !(bs->open_flags & BDRV_O_RDWR); diff --git a/block/io.c b/block/io.c index b261cc6..b3ff9be 100644 --- a/block/io.c +++ b/block/io.c @@ -1052,8 +1052,7 @@ int coroutine_fn bdrv_co_preadv(BlockDriverState *bs, BlockDriver *drv = bs->drv; BdrvTrackedRequest req; - /* TODO Lift BDRV_SECTOR_SIZE restriction in BlockDriver interface */ - uint64_t align = MAX(BDRV_SECTOR_SIZE, bs->request_alignment); + uint64_t align = bs->request_alignment; uint8_t *head_buf = NULL; uint8_t *tail_buf = NULL; QEMUIOVector local_qiov; @@ -1305,7 +1304,7 @@ static int coroutine_fn bdrv_co_do_zero_pwritev(BlockDriverState *bs, uint8_t *buf = NULL; QEMUIOVector local_qiov; struct iovec iov; - uint64_t align = MAX(BDRV_SECTOR_SIZE, bs->request_alignment); + uint64_t align = bs->request_alignment; unsigned int head_padding_bytes, tail_padding_bytes; int ret = 0; @@ -1392,8 +1391,7 @@ int coroutine_fn bdrv_co_pwritev(BlockDriverState *bs, BdrvRequestFlags flags) { BdrvTrackedRequest req; - /* TODO Lift BDRV_SECTOR_SIZE restriction in BlockDriver interface */ - uint64_t align = MAX(BDRV_SECTOR_SIZE, bs->request_alignment); + uint64_t align = bs->request_alignment; uint8_t *head_buf = NULL; uint8_t *tail_buf = NULL; QEMUIOVector local_qiov; -- 1.8.3.1