From: "Daniel P. Berrange" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
qemu-trivial@nongnu.org,
"Daniel P. Berrange" <berrange@redhat.com>
Subject: [Qemu-devel] [PATCH] win32: don't run subprocess tests on Mingw32 platform
Date: Tue, 14 Jun 2016 16:44:57 +0100 [thread overview]
Message-ID: <1465919097-21453-1-git-send-email-berrange@redhat.com> (raw)
The g_test_trap_subprocess() method does not work on the
Mingw32 platform, causing the test-qdev-global-props
test case to abort
(test-logging.exe:230): GLib-ERROR **: g_test_trap_subprocess()
failed: Failed to execute helper program (No such file or directory)
This failure was introduced a while ago in
commit 2177801a4899bf29108b3d471417a5b4d701ec29
Author: Eduardo Habkost <ehabkost@redhat.com>
Date: Fri Aug 8 16:03:27 2014 -0300
test-qdev-global-props: Run tests on subprocess
Modify the configure time check to avoid enabling this feature
on Mingw, rather than trying to rewrite the test to avoid this
feature.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 8c2f90b..aa291e8 100755
--- a/configure
+++ b/configure
@@ -5167,7 +5167,7 @@ if test "$bluez" = "yes" ; then
echo "CONFIG_BLUEZ=y" >> $config_host_mak
echo "BLUEZ_CFLAGS=$bluez_cflags" >> $config_host_mak
fi
-if test "$glib_subprocess" = "yes" ; then
+if test "$glib_subprocess" = "yes" && test "$mingw32" != "yes" ; then
echo "CONFIG_HAS_GLIB_SUBPROCESS_TESTS=y" >> $config_host_mak
fi
echo "GLIB_CFLAGS=$glib_cflags" >> $config_host_mak
--
2.5.5
next reply other threads:[~2016-06-14 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 15:44 Daniel P. Berrange [this message]
2016-06-14 16:00 ` [Qemu-devel] [PATCH] win32: don't run subprocess tests on Mingw32 platform Eduardo Habkost
2016-09-14 7:21 ` Michael Tokarev
2017-01-03 18:52 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465919097-21453-1-git-send-email-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.