All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, kwolf@redhat.com,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Peter Lieven <pl@kamp.de>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 09/17] iscsi: Set request_alignment during .bdrv_refresh_limits()
Date: Tue, 14 Jun 2016 15:30:31 -0600	[thread overview]
Message-ID: <1465939839-30097-10-git-send-email-eblake@redhat.com> (raw)
In-Reply-To: <1465939839-30097-1-git-send-email-eblake@redhat.com>

We want to eventually stick request_alignment alongside other
BlockLimits, but first, we must ensure it is populated at the
same time as all other limits, rather than being a special case
that is set only when a block is first opened.

Signed-off-by: Eric Blake <eblake@redhat.com>

---
v2: new patch
---
 block/iscsi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/block/iscsi.c b/block/iscsi.c
index 4290e41..b4661c9 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1588,7 +1588,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
         goto out;
     }
     bs->total_sectors = sector_lun2qemu(iscsilun->num_blocks, iscsilun);
-    bs->request_alignment = iscsilun->block_size;

     /* We don't have any emulation for devices other than disks and CD-ROMs, so
      * this must be sg ioctl compatible. We force it to be sg, otherwise qemu
@@ -1710,6 +1709,8 @@ static void iscsi_refresh_limits(BlockDriverState *bs, Error **errp)
     IscsiLun *iscsilun = bs->opaque;
     uint32_t max_xfer_len = iscsilun->use_16_for_rw ? 0xffffffff : 0xffff;

+    bs->request_alignment = iscsilun->block_size;
+
     if (iscsilun->bl.max_xfer_len) {
         max_xfer_len = MIN(max_xfer_len, iscsilun->bl.max_xfer_len);
     }
-- 
2.5.5

  parent reply	other threads:[~2016-06-14 21:31 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 21:30 [Qemu-devel] [PATCH v2 00/17] Byte-based block limits Eric Blake
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 01/17] block: Tighter assertions on bdrv_aligned_pwritev() Eric Blake
2016-06-16  5:05   ` Fam Zheng
2016-06-20 12:09   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 02/17] block: Document supported flags during bdrv_aligned_preadv() Eric Blake
2016-06-16  5:08   ` Fam Zheng
2016-06-20 12:10   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 03/17] block: Fix harmless off-by-one in bdrv_aligned_preadv() Eric Blake
2016-06-16  5:10   ` Fam Zheng
2016-06-20 12:12   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 04/17] nbd: Allow larger requests Eric Blake
2016-06-15 13:37   ` Paolo Bonzini
2016-06-16  5:12   ` Fam Zheng
2016-06-20 12:13   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 05/17] nbd: Advertise realistic limits to block layer Eric Blake
2016-06-15 13:38   ` Paolo Bonzini
2016-06-22 20:58     ` Eric Blake
2016-06-16  5:13   ` Fam Zheng
2016-06-20 12:14   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 06/17] iscsi: " Eric Blake
2016-06-16  5:19   ` Fam Zheng
2016-06-20 12:16   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 07/17] block: Give nonzero result to blk_get_max_transfer_length() Eric Blake
2016-06-16  5:25   ` Fam Zheng
2016-06-16 13:22     ` Paolo Bonzini
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 08/17] blkdebug: Set request_alignment during .bdrv_refresh_limits() Eric Blake
2016-06-16  5:27   ` Fam Zheng
2016-06-21 13:27   ` Kevin Wolf
2016-06-21 22:17     ` Eric Blake
2016-06-22 10:05       ` Kevin Wolf
2016-06-22 17:33         ` Eric Blake
2016-06-14 21:30 ` Eric Blake [this message]
2016-06-16  5:28   ` [Qemu-devel] [PATCH v2 09/17] iscsi: " Fam Zheng
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 10/17] qcow2: " Eric Blake
2016-06-16  5:28   ` Fam Zheng
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 11/17] raw-win32: " Eric Blake
2016-06-16  5:30   ` Fam Zheng
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 12/17] block: " Eric Blake
2016-06-16  5:31   ` Fam Zheng
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 13/17] block: Set default request_alignment during bdrv_refresh_limits() Eric Blake
2016-06-16  5:32   ` Fam Zheng
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 14/17] block: Switch transfer length bounds to byte-based Eric Blake
2016-06-16  5:42   ` Fam Zheng
2016-06-21 13:50   ` Kevin Wolf
2016-06-21 22:20     ` Eric Blake
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 15/17] block: Switch discard " Eric Blake
2016-06-16  5:46   ` Fam Zheng
2016-06-16 14:21     ` Eric Blake
2016-06-17  2:28       ` Fam Zheng
2016-06-21 14:05   ` Kevin Wolf
2016-06-21 22:21     ` Eric Blake
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 16/17] block: Split bdrv_merge_limits() from bdrv_refresh_limits() Eric Blake
2016-06-16  5:50   ` Fam Zheng
2016-06-16 14:22     ` Eric Blake
2016-06-21 14:12   ` Kevin Wolf
2016-06-21 22:24     ` Eric Blake
2016-06-14 21:30 ` [Qemu-devel] [PATCH v2 17/17] block: Move request_alignment into BlockLimit Eric Blake
2016-06-16  5:52   ` Fam Zheng
2016-06-21 14:16   ` Kevin Wolf
2016-06-21 22:26     ` Eric Blake
2016-06-22 10:14       ` Kevin Wolf
2016-06-21 14:18 ` [Qemu-devel] [PATCH v2 00/17] Byte-based block limits Kevin Wolf
2016-06-21 22:27   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465939839-30097-10-git-send-email-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.