All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] sunxi: Add defconfig for Olinuxino Lime 2 EMMC version
@ 2016-06-15  3:29 Emmanuel Vadot
  2016-06-15  8:17 ` Ian Campbell
  0 siblings, 1 reply; 2+ messages in thread
From: Emmanuel Vadot @ 2016-06-15  3:29 UTC (permalink / raw)
  To: u-boot

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
---
 configs/A20-OLinuXino-Lime2-emmc_defconfig | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 configs/A20-OLinuXino-Lime2-emmc_defconfig

diff --git a/configs/A20-OLinuXino-Lime2-emmc_defconfig b/configs/A20-OLinuXino-Lime2-emmc_defconfig
new file mode 100644
index 0000000..093c51f
--- /dev/null
+++ b/configs/A20-OLinuXino-Lime2-emmc_defconfig
@@ -0,0 +1,21 @@
+CONFIG_ARM=y
+CONFIG_ARCH_SUNXI=y
+CONFIG_MACH_SUN7I=y
+CONFIG_DRAM_CLK=480
+CONFIG_MMC0_CD_PIN="PH1"
+CONFIG_MMC2_PINS="PC"
+CONFIG_MMC_SUNXI_SLOT_EXTRA=2k
+CONFIG_USB0_VBUS_PIN="PC17"
+CONFIG_USB0_VBUS_DET="PH5"
+CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2-emmc"
+# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+CONFIG_SPL=y
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII,AHCI,SATAPWR=SUNXI_GPC(3)"
+# CONFIG_CMD_IMLS is not set
+# CONFIG_CMD_FLASH is not set
+# CONFIG_CMD_FPGA is not set
+CONFIG_RTL8211X_PHY_FORCE_MASTER=y
+CONFIG_ETH_DESIGNWARE=y
+CONFIG_AXP_ALDO3_VOLT=2800
+CONFIG_AXP_ALDO4_VOLT=2800
+CONFIG_USB_EHCI_HCD=y
-- 
2.8.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] sunxi: Add defconfig for Olinuxino Lime 2 EMMC version
  2016-06-15  3:29 [U-Boot] [PATCH] sunxi: Add defconfig for Olinuxino Lime 2 EMMC version Emmanuel Vadot
@ 2016-06-15  8:17 ` Ian Campbell
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2016-06-15  8:17 UTC (permalink / raw)
  To: u-boot

On Wed, 2016-06-15 at 05:29 +0200, Emmanuel Vadot wrote:

Please include a short description of the board, in this case
explaining the distinction (and defconfig differences) from the non-
EMMC version would be useful.

Have a look at some of the previous patches which add defconfig (e.g.
those from Hans) for some examples of best practice.

> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
> ?configs/A20-OLinuXino-Lime2-emmc_defconfig | 21 +++++++++++++++++++++

This patch should also touch board/sunxi/MAINTAINERS, to add an entry
with your name for this board.?

> +CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2-emmc"

This file doesn't appear to be in the u-boot tree already so usually we
would import the upstream version as part of this patch.

In fact I'm not sure how this patch builds without it, we configure u-
boot itself via DM for at least some subsystems, which requires it to
be present a build time to be concatenated onto the basic image.

Ian.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-15  8:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15  3:29 [U-Boot] [PATCH] sunxi: Add defconfig for Olinuxino Lime 2 EMMC version Emmanuel Vadot
2016-06-15  8:17 ` Ian Campbell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.