From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: [PATCH v2] eal: Fix wrong error checking while parsing device arguments Date: Thu, 16 Jun 2016 11:33:09 +0900 Message-ID: <1466044391-3210-1-git-send-email-mukawa@igel.co.jp> References: <1465961209-28309-1-git-send-email-mukawa@igel.co.jp> Cc: david.marchand@6wind.com, john.mcnamara@intel.com, michalx.k.jastrzebski@intel.com, Tetsuya Mukawa To: dev@dpdk.org Return-path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 3AC15C4D2 for ; Thu, 16 Jun 2016 04:33:31 +0200 (CEST) Received: by mail-pf0-f177.google.com with SMTP id c2so14769037pfa.2 for ; Wed, 15 Jun 2016 19:33:31 -0700 (PDT) In-Reply-To: <1465961209-28309-1-git-send-email-mukawa@igel.co.jp> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes wrong error checking of rte_eal_parse_devargs_str(). Currently, a return value of strdup() is wrongly checked. Fixes: 0fe11ec592b2 ("eal: add vdev init and uninit") Signed-off-by: Tetsuya Mukawa --- lib/librte_eal/common/eal_common_devargs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c index 2bfe54a..e403717 100644 --- a/lib/librte_eal/common/eal_common_devargs.c +++ b/lib/librte_eal/common/eal_common_devargs.c @@ -58,7 +58,7 @@ rte_eal_parse_devargs_str(const char *devargs_str, return -1; *drvname = strdup(devargs_str); - if (drvname == NULL) + if (*drvname == NULL) return -1; /* set the first ',' to '\0' to split name and arguments */ -- 2.7.4