From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754290AbcFPNO7 (ORCPT ); Thu, 16 Jun 2016 09:14:59 -0400 Received: from smarthost01b.mail.zen.net.uk ([212.23.1.3]:33561 "EHLO smarthost01b.mail.zen.net.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753849AbcFPNO6 (ORCPT ); Thu, 16 Jun 2016 09:14:58 -0400 Message-ID: <1466082894.20208.1.camel@linaro.org> Subject: Re: [PATCH v2 0/3] firmware: scpi: add device power domain support From: "Jon Medhurst (Tixy)" To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ulf Hansson , Mathieu Poirier , Suzuki K Poulose Date: Thu, 16 Jun 2016 14:14:54 +0100 In-Reply-To: <1466073481-697-1-git-send-email-sudeep.holla@arm.com> References: <1466073481-697-1-git-send-email-sudeep.holla@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-smarthost01b-IP: [82.69.122.217] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-16 at 11:37 +0100, Sudeep Holla wrote: > This series add support for SCPI based device device power state > management using genpd. > > Regards, > Sudeep > > v1[1]->v2: > - Fixed the endianness handling in scpi_device_get_power_state > as spotted by Tixy > - Renamed scpi_pd.c to scpi_pm_domain.c as suggested by Ulf You seemed to also have made some changes to the contents of the file, is that deliberate? This is the diff... --- a/drivers/firmware/scpi_pm_domain.c +++ b/drivers/firmware/scpi_pd.c @@ -27,7 +27,7 @@ struct scpi_pm_domain { struct generic_pm_domain genpd; struct scpi_ops *ops; u32 domain; - char name[20]; + char name[30]; }; enum scpi_power_domain_state { @@ -51,7 +51,7 @@ static int scpi_pd_power(struct scpi_pm_domain *pd, bool power_on) if (ret) return ret; - return (state == pd->ops->device_get_power_state(pd->domain)); + return !(state == pd->ops->device_get_power_state(pd->domain)); } static int scpi_pd_power_on(struct generic_pm_domain *domain)