From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751642AbcFXOLU (ORCPT ); Fri, 24 Jun 2016 10:11:20 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:27182 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751460AbcFXOLU (ORCPT ); Fri, 24 Jun 2016 10:11:20 -0400 From: Yingjoe Chen To: Andy Whitcroft , Joe Perches CC: , , Andi Kleen , Paul Bolle , Yingjoe Chen Subject: [PATCH v4 1/2] checkpatch: testing more config for Kconfig help text Date: Fri, 24 Jun 2016 22:11:05 +0800 Message-ID: <1466777466-21306-1-git-send-email-yingjoe.chen@mediatek.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current help text check only check a config option if it is followed by another config. Adding check for help text if the next entry is menuconfig, choice/ endchoice, comment, menu/endmenu, if/endif, source or end of file. Signed-off-by: Yingjoe Chen --- checkpatch Kconfig checking stuff again. Change in this round: In 'default n' check, don't warn if user comment on why the 'default n' is neccessary. I also change patch order. The first one extend help message check to check for all available config entries. If you think 'default n' check is not that useful, please consider just merge this one. Let me know what you think. Thanks. Change in v3: - Rebase to v4.7-rc1 Change in v2: - Change according to Joe Perches' suggestion --- scripts/checkpatch.pl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6750595..19b270b 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2646,6 +2646,12 @@ sub process { next if ($f =~ /^-/); last if (!$file && $f =~ /^\@\@/); + if ($f !~ /^[+\- ]/) { + # End of file + $is_end = 1; + last; + } + if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) { $is_start = 1; } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) { @@ -2656,7 +2662,7 @@ sub process { $f =~ s/#.*//; $f =~ s/^\s+//; next if ($f =~ /^$/); - if ($f =~ /^\s*config\s/) { + if ($f =~ /^(?:config\s|menuconfig\s|choice\s|endchoice\s*$|comment\s|menu\s|endmenu\s*$|if\s|endif\s*$|source\s)/) { $is_end = 1; last; } -- 1.9.1