From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751742AbcFXOL1 (ORCPT ); Fri, 24 Jun 2016 10:11:27 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:54262 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751476AbcFXOL0 (ORCPT ); Fri, 24 Jun 2016 10:11:26 -0400 From: Yingjoe Chen To: Andy Whitcroft , Joe Perches CC: , , Andi Kleen , Paul Bolle , Yingjoe Chen Subject: [PATCH v4 2/2] checkpatch: add Kconfig 'default n' test Date: Fri, 24 Jun 2016 22:11:06 +0800 Message-ID: <1466777466-21306-2-git-send-email-yingjoe.chen@mediatek.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1466777466-21306-1-git-send-email-yingjoe.chen@mediatek.com> References: <1466777466-21306-1-git-send-email-yingjoe.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen --- scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 19b270b..b3f1fda 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2689,6 +2689,13 @@ sub process { "Use of boolean is deprecated, please use bool instead.\n" . $herecurr); } +# discourage the use of default n + if ($realfile =~ /Kconfig/ && + $line =~ /^\+\s*default\s*n$/i) { + WARN("CONFIG_DEFAULT_N", + "Use of default n is unnecessary, default is n when omitted.\n" . $herecurr); + } + if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) { my $flag = $1; -- 1.9.1