From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGRx8-00026F-Pv for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:19:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGRx3-00056P-EF for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:19:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGRx3-00056D-5p for qemu-devel@nongnu.org; Fri, 24 Jun 2016 10:19:21 -0400 From: Markus Armbruster Date: Fri, 24 Jun 2016 16:19:13 +0200 Message-Id: <1466777957-5126-2-git-send-email-armbru@redhat.com> In-Reply-To: <1466777957-5126-1-git-send-email-armbru@redhat.com> References: <1466777957-5126-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH RFC v2 1/5] Use #include "..." exactly for our own headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, pbonzini@redhat.com Signed-off-by: Markus Armbruster Reviewed-by: Peter Maydell --- block/iscsi.c | 1 - crypto/pbkdf-gcrypt.c | 2 +- crypto/pbkdf-nettle.c | 2 +- exec.c | 2 +- hw/scsi/virtio-scsi-dataplane.c | 2 +- hw/scsi/virtio-scsi.c | 2 +- linux-user/flatload.c | 2 +- monitor.c | 2 +- slirp/bootp.c | 2 +- slirp/cksum.c | 2 +- slirp/if.c | 2 +- slirp/ip_input.c | 2 +- slirp/ip_output.c | 2 +- slirp/mbuf.c | 2 +- slirp/misc.c | 5 ++--- slirp/sbuf.c | 4 ++-- slirp/socket.c | 2 +- slirp/tcp_input.c | 2 +- slirp/tcp_output.c | 2 +- slirp/tcp_subr.c | 2 +- slirp/tcp_timer.c | 2 +- slirp/tftp.c | 2 +- slirp/udp.c | 2 +- target-arm/arm-powerctl.c | 4 ++-- target-arm/psci.c | 8 ++++---- target-ppc/translate_init.c | 2 +- target-s390x/cpu.h | 2 +- target-unicore32/softmmu.c | 2 +- tests/postcopy-test.c | 3 +-- tests/vhost-user-bridge.c | 2 -- tests/vhost-user-test.c | 2 +- util/mmap-alloc.c | 3 ++- util/oslib-posix.c | 2 +- 33 files changed, 38 insertions(+), 42 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 7e78ade..74f084ca 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -46,7 +46,6 @@ #ifdef __linux__ #include -#include #endif typedef struct IscsiLun { diff --git a/crypto/pbkdf-gcrypt.c b/crypto/pbkdf-gcrypt.c index 997b311..34af3a9 100644 --- a/crypto/pbkdf-gcrypt.c +++ b/crypto/pbkdf-gcrypt.c @@ -19,9 +19,9 @@ */ #include "qemu/osdep.h" +#include #include "qapi/error.h" #include "crypto/pbkdf.h" -#include "gcrypt.h" bool qcrypto_pbkdf2_supports(QCryptoHashAlgorithm hash) { diff --git a/crypto/pbkdf-nettle.c b/crypto/pbkdf-nettle.c index db9fc15..d681a60 100644 --- a/crypto/pbkdf-nettle.c +++ b/crypto/pbkdf-nettle.c @@ -19,9 +19,9 @@ */ #include "qemu/osdep.h" +#include #include "qapi/error.h" #include "crypto/pbkdf.h" -#include "nettle/pbkdf2.h" bool qcrypto_pbkdf2_supports(QCryptoHashAlgorithm hash) diff --git a/exec.c b/exec.c index 0122ef7..011babd 100644 --- a/exec.c +++ b/exec.c @@ -36,7 +36,7 @@ #include "qemu/config-file.h" #include "qemu/error-report.h" #if defined(CONFIG_USER_ONLY) -#include +#include "qemu.h" #else /* !CONFIG_USER_ONLY */ #include "hw/hw.h" #include "exec/memory.h" diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplane.c index 1a49f1e..64c263f 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -16,7 +16,7 @@ #include "qemu/error-report.h" #include "sysemu/block-backend.h" #include -#include +#include "block/scsi.h" #include #include "hw/virtio/virtio-access.h" diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 71d09d3..a41f3e9 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -21,7 +21,7 @@ #include "qemu/iov.h" #include "sysemu/block-backend.h" #include -#include +#include "block/scsi.h" #include #include "hw/virtio/virtio-access.h" diff --git a/linux-user/flatload.c b/linux-user/flatload.c index 48ad1c5..42d1079 100644 --- a/linux-user/flatload.c +++ b/linux-user/flatload.c @@ -37,7 +37,7 @@ #include "qemu.h" #include "flat.h" -#include +#include "target_flat.h" //#define DEBUG diff --git a/monitor.c b/monitor.c index 6f960f1..6770c8c 100644 --- a/monitor.c +++ b/monitor.c @@ -62,7 +62,7 @@ #include "qapi/qmp/qjson.h" #include "qapi/qmp/json-streamer.h" #include "qapi/qmp/json-parser.h" -#include +#include "qom/object_interfaces.h" #include "cpu.h" #include "trace.h" #include "trace/control.h" diff --git a/slirp/bootp.c b/slirp/bootp.c index 7b3232b..5a4646c 100644 --- a/slirp/bootp.c +++ b/slirp/bootp.c @@ -22,7 +22,7 @@ * THE SOFTWARE. */ #include "qemu/osdep.h" -#include +#include "slirp.h" #if defined(_WIN32) /* Windows ntohl() returns an u_long value. diff --git a/slirp/cksum.c b/slirp/cksum.c index 2ad0e65..6d73abf 100644 --- a/slirp/cksum.c +++ b/slirp/cksum.c @@ -31,7 +31,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" /* * Checksum routine for Internet Protocol family headers (Portable Version). diff --git a/slirp/if.c b/slirp/if.c index 9b02180..51ae0d0 100644 --- a/slirp/if.c +++ b/slirp/if.c @@ -6,7 +6,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" #include "qemu/timer.h" static void diff --git a/slirp/ip_input.c b/slirp/ip_input.c index 34fba2b..348e1dc 100644 --- a/slirp/ip_input.c +++ b/slirp/ip_input.c @@ -39,7 +39,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" #include "ip_icmp.h" static struct ip *ip_reass(Slirp *slirp, struct ip *ip, struct ipq *fp); diff --git a/slirp/ip_output.c b/slirp/ip_output.c index 0d6b3b8..db403f0 100644 --- a/slirp/ip_output.c +++ b/slirp/ip_output.c @@ -39,7 +39,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" /* Number of packets queued before we start sending * (to prevent allocing too many mbufs) */ diff --git a/slirp/mbuf.c b/slirp/mbuf.c index d136988..7eddc21 100644 --- a/slirp/mbuf.c +++ b/slirp/mbuf.c @@ -16,7 +16,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" #define MBUF_THRESH 30 diff --git a/slirp/misc.c b/slirp/misc.c index 1a0ea1b..88e9d94 100644 --- a/slirp/misc.c +++ b/slirp/misc.c @@ -6,9 +6,8 @@ */ #include "qemu/osdep.h" -#include -#include - +#include "slirp.h" +#include "libslirp.h" #include "monitor/monitor.h" #include "qemu/error-report.h" #include "qemu/main-loop.h" diff --git a/slirp/sbuf.c b/slirp/sbuf.c index dd4cb8c..10119d3 100644 --- a/slirp/sbuf.c +++ b/slirp/sbuf.c @@ -6,8 +6,8 @@ */ #include "qemu/osdep.h" -#include -#include +#include "slirp.h" +#include "qemu/main-loop.h" static void sbappendsb(struct sbuf *sb, struct mbuf *m); diff --git a/slirp/socket.c b/slirp/socket.c index b336586..2b53cd7 100644 --- a/slirp/socket.c +++ b/slirp/socket.c @@ -7,7 +7,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" -#include +#include "slirp.h" #include "ip_icmp.h" #ifdef __sun__ #include diff --git a/slirp/tcp_input.c b/slirp/tcp_input.c index e2b5d4e..c5063a9 100644 --- a/slirp/tcp_input.c +++ b/slirp/tcp_input.c @@ -39,7 +39,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" #include "ip_icmp.h" #define TCPREXMTTHRESH 3 diff --git a/slirp/tcp_output.c b/slirp/tcp_output.c index 99b0a9b..819db27 100644 --- a/slirp/tcp_output.c +++ b/slirp/tcp_output.c @@ -39,7 +39,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" static const u_char tcp_outflags[TCP_NSTATES] = { TH_RST|TH_ACK, 0, TH_SYN, TH_SYN|TH_ACK, diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c index 6b9fef2..ed16e18 100644 --- a/slirp/tcp_subr.c +++ b/slirp/tcp_subr.c @@ -39,7 +39,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" /* patchable/settable parameters for tcp */ /* Don't do rfc1323 performance enhancements */ diff --git a/slirp/tcp_timer.c b/slirp/tcp_timer.c index 8f5dd77..f9060c7 100644 --- a/slirp/tcp_timer.c +++ b/slirp/tcp_timer.c @@ -31,7 +31,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" static struct tcpcb *tcp_timers(register struct tcpcb *tp, int timer); diff --git a/slirp/tftp.c b/slirp/tftp.c index 12b5ff6..8de3bc0 100644 --- a/slirp/tftp.c +++ b/slirp/tftp.c @@ -23,7 +23,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" #include "qemu-common.h" #include "qemu/cutils.h" diff --git a/slirp/udp.c b/slirp/udp.c index 247024f..93d7224 100644 --- a/slirp/udp.c +++ b/slirp/udp.c @@ -39,7 +39,7 @@ */ #include "qemu/osdep.h" -#include +#include "slirp.h" #include "ip_icmp.h" static uint8_t udp_tos(struct socket *so); diff --git a/target-arm/arm-powerctl.c b/target-arm/arm-powerctl.c index d452230..6519d52 100644 --- a/target-arm/arm-powerctl.c +++ b/target-arm/arm-powerctl.c @@ -9,8 +9,8 @@ */ #include "qemu/osdep.h" -#include -#include +#include "cpu.h" +#include "cpu-qom.h" #include "internals.h" #include "arm-powerctl.h" #include "qemu/log.h" diff --git a/target-arm/psci.c b/target-arm/psci.c index 4db9b8c..14316eb 100644 --- a/target-arm/psci.c +++ b/target-arm/psci.c @@ -16,10 +16,10 @@ * along with this program; if not, see . */ #include "qemu/osdep.h" -#include -#include -#include -#include +#include "cpu.h" +#include "exec/helper-proto.h" +#include "kvm-consts.h" +#include "sysemu/sysemu.h" #include "internals.h" #include "arm-powerctl.h" #include "exec/exec-all.h" diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index ca894ff..49c0728 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -21,7 +21,7 @@ #include "qemu/osdep.h" #include "disas/bfd.h" #include "exec/gdbstub.h" -#include +#include "sysemu/kvm.h" #include "kvm_ppc.h" #include "sysemu/arch_init.h" #include "sysemu/cpus.h" diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h index bd6b2e5..c7cc4e1 100644 --- a/target-s390x/cpu.h +++ b/target-s390x/cpu.h @@ -219,7 +219,7 @@ int s390_cpu_gdb_write_register(CPUState *cpu, uint8_t *buf, int reg); void s390_cpu_gdb_init(CPUState *cs); void s390x_cpu_debug_excp_handler(CPUState *cs); -#include +#include "sysemu/kvm.h" /* distinguish between 24 bit and 31 bit addressing */ #define HIGH_ORDER_BIT 0x80000000 diff --git a/target-unicore32/softmmu.c b/target-unicore32/softmmu.c index a34026a..e7152e7 100644 --- a/target-unicore32/softmmu.c +++ b/target-unicore32/softmmu.c @@ -13,7 +13,7 @@ #endif #include "qemu/osdep.h" -#include +#include "cpu.h" #include "exec/exec-all.h" #undef DEBUG_UC32 diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c index 35d5180..16465ab 100644 --- a/tests/postcopy-test.c +++ b/tests/postcopy-test.c @@ -15,11 +15,10 @@ #include "libqtest.h" #include "qemu/option.h" #include "qemu/range.h" +#include "qemu/sockets.h" #include "sysemu/char.h" #include "sysemu/sysemu.h" -#include - const unsigned start_address = 1024 * 1024; const unsigned end_address = 100 * 1024 * 1024; bool got_stop; diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c index 45fa2b6..775e031 100644 --- a/tests/vhost-user-bridge.c +++ b/tests/vhost-user-bridge.c @@ -36,8 +36,6 @@ #include #include #include -#include - #include #include "qemu/atomic.h" diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 8b2164b..71e7f42 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -13,12 +13,12 @@ #include "libqtest.h" #include "qemu/option.h" #include "qemu/range.h" +#include "qemu/sockets.h" #include "sysemu/char.h" #include "sysemu/sysemu.h" #include #include -#include /* GLIB version compatibility flags */ #if !GLIB_CHECK_VERSION(2, 26, 0) diff --git a/util/mmap-alloc.c b/util/mmap-alloc.c index 629d97a..5a85aa3 100644 --- a/util/mmap-alloc.c +++ b/util/mmap-alloc.c @@ -9,8 +9,9 @@ * This work is licensed under the terms of the GNU GPL, version 2 or * later. See the COPYING file in the top-level directory. */ + #include "qemu/osdep.h" -#include +#include "qemu/mmap-alloc.h" #define HUGETLBFS_MAGIC 0x958458f6 diff --git a/util/oslib-posix.c b/util/oslib-posix.c index e2e1d4d..d8e5dcf 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -48,7 +48,7 @@ #include #endif -#include +#include "qemu/mmap-alloc.h" int qemu_get_thread_id(void) { -- 2.5.5