All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.verkamp@intel.com (Verkamp, Daniel)
Subject: NVMe over Fabrics: NQN UUID byte order
Date: Fri, 24 Jun 2016 18:22:11 +0000	[thread overview]
Message-ID: <1466792528.3234.9.camel@intel.com> (raw)

The NVMe 1.2.1 specification, section 7.9 (NVMe Qualified Names), says
that the UUID format of NQN is based on RFC 4122, which explicitly
requires all fields to be in big-endian/network byte order (section
4.1.2, Layout and Byte Order).

However, the current NVMe over Fabrics host code generates and formats
the Host Identifier UUID in little-endian byte order:

>static struct nvmf_host *nvmf_host_default(void)
>{
[...]
>	uuid_le_gen(&host->id);
>	snprintf(host->nqn, NVMF_NQN_SIZE,
>		"nqn.2014-08.org.nvmexpress:NVMf:uuid:%pUl", &host-
>id);

Is this intentional or an oversight?

This could probably use some clarification on the NVMe specification
side either way.

Thanks,
-- Daniel Verkamp

             reply	other threads:[~2016-06-24 18:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24 18:22 Verkamp, Daniel [this message]
2016-06-28  8:45 ` NVMe over Fabrics: NQN UUID byte order Christoph Hellwig
2016-06-28 18:20   ` [PATCH] nvme-fabrics: change NQN UUID to big-endian format Daniel Verkamp
2016-06-28 19:55     ` Freyensee, James P
2016-06-30  6:41     ` Christoph Hellwig
2016-08-18 19:48       ` Verkamp, Daniel
2016-08-19  9:02         ` Sagi Grimberg
2016-07-13 10:12     ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466792528.3234.9.camel@intel.com \
    --to=daniel.verkamp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.