All of lore.kernel.org
 help / color / mirror / Atom feed
From: vedang.patel@intel.com
To: alsa-devel@alsa-project.org
Cc: vinod.koul@intel.com, marc.herbert@intel.com, broonie@kernel.org,
	liam.r.girdwood@intel.com, jeeja.kp@intel.com,
	subhransu.s.prusty@intel.com,
	Vedang Patel <vedang.patel@intel.com>
Subject: [REPOST REPOST PATCH v3 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages.
Date: Fri, 24 Jun 2016 17:37:11 -0700	[thread overview]
Message-ID: <1466815031-31922-4-git-send-email-vedang.patel@intel.com> (raw)
In-Reply-To: <1466815031-31922-1-git-send-email-vedang.patel@intel.com>

From: Vedang Patel <vedang.patel@intel.com>

There is log spam while doing playback, record or reloading the
audio firmware.

print_hex_dump uses printk(KERN_DEBUG,... which is different from
dev_dbg used elsewhere in the driver: it's always enabled at
compile-time. Change it to print_hex_dump_debug for logging consistency.

For consistency with other log statements, change dev_info to dev_dbg
for a kernel print which is frequently printed by the driver.

Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
 sound/soc/intel/skylake/skl-messages.c |    2 +-
 sound/soc/intel/skylake/skl-sst-ipc.c  |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index 226db84..81224de 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -730,7 +730,7 @@ static int skl_set_module_format(struct skl_sst *ctx,
 
 	dev_dbg(ctx->dev, "Module type=%d config size: %d bytes\n",
 			module_config->id.module_id, param_size);
-	print_hex_dump(KERN_DEBUG, "Module params:", DUMP_PREFIX_OFFSET, 8, 4,
+	print_hex_dump_debug("Module params:", DUMP_PREFIX_OFFSET, 8, 4,
 			*param_data, param_size, false);
 	return 0;
 }
diff --git a/sound/soc/intel/skylake/skl-sst-ipc.c b/sound/soc/intel/skylake/skl-sst-ipc.c
index 5434602..c141f24 100644
--- a/sound/soc/intel/skylake/skl-sst-ipc.c
+++ b/sound/soc/intel/skylake/skl-sst-ipc.c
@@ -363,7 +363,7 @@ static void skl_ipc_process_reply(struct sst_generic_ipc *ipc,
 	/* first process the header */
 	switch (reply) {
 	case IPC_GLB_REPLY_SUCCESS:
-		dev_info(ipc->dev, "ipc FW reply %x: success\n", header.primary);
+		dev_dbg(ipc->dev, "ipc FW reply %x: success\n", header.primary);
 		/* copy the rx data from the mailbox */
 		sst_dsp_inbox_read(ipc->dsp, msg->rx_data, msg->rx_size);
 		break;
@@ -692,7 +692,7 @@ int skl_ipc_init_instance(struct sst_generic_ipc *ipc,
 	 /* param_block_size must be in dwords */
 	u16 param_block_size = msg->param_data_size / sizeof(u32);
 
-	print_hex_dump(KERN_DEBUG, NULL, DUMP_PREFIX_NONE,
+	print_hex_dump_debug(NULL, DUMP_PREFIX_NONE,
 		16, 4, buffer, param_block_size, false);
 
 	header.primary = IPC_MSG_TARGET(IPC_MOD_MSG);
-- 
1.7.9.5

  parent reply	other threads:[~2016-06-25  0:37 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12 22:08 [PATCH 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-04-12 22:08 ` [PATCH 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-04-13  1:09   ` Takashi Sakamoto
2016-04-14 15:15     ` Vedang Patel
2016-04-15 19:13       ` Vedang Patel
2016-04-12 22:08 ` [PATCH 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-27 16:40   ` Applied "ASoC: Intel: common: increase the loglevel of "FW Poll Status"." to the asoc tree Mark Brown
2016-04-12 22:08 ` [PATCH 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-04-26 23:03   ` [PATCH v2 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-04-26 23:03     ` [PATCH v2 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-04-26 23:03     ` [PATCH v2 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-04-26 23:03     ` [PATCH v2 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-01  1:14       ` [PATCH v3 0/3] ASoC: Reduce audio related kernel spew vedang.patel
2016-06-01  1:14         ` [PATCH v3 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-06-27 16:40           ` Applied "ASoC: hdac_hdmi: Increase loglevel of hex dump printed" to the asoc tree Mark Brown
2016-06-01  1:15         ` [PATCH v3 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-01  1:15         ` [PATCH v3 3/3] ASoC: Intel: Skylake: Increase loglevel of debug messages vedang.patel
2016-06-01  5:56         ` [PATCH v3 0/3] ASoC: Reduce audio related kernel spew Vinod Koul
2016-06-25  0:37       ` [REPOST REPOST PATCH " vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 1/3] ASoC: hdac_hdmi: Increase loglevel of hex dump printed vedang.patel
2016-06-25  0:37         ` [REPOST REPOST PATCH v3 2/3] ASoC: Intel: common: increase the loglevel of "FW Poll Status" vedang.patel
2016-06-25  0:37         ` vedang.patel [this message]
2016-06-27 14:50         ` [REPOST REPOST PATCH v3 0/3] ASoC: Reduce audio related kernel spew Mark Brown
2016-06-29 23:39           ` Patel, Vedang
2016-06-30  2:27             ` Vinod Koul
2016-07-01  7:50               ` Mark Brown
2016-06-27 16:40       ` Applied "ASoC: Intel: Skylake: Increase loglevel of debug messages." to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466815031-31922-4-git-send-email-vedang.patel@intel.com \
    --to=vedang.patel@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=marc.herbert@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.