From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [RESEND][PATCH] device-tree: nexus7: Remove power gpio key entry and use pmic8xxx-pwrkey Date: Mon, 27 Jun 2016 12:36:11 -0700 Message-ID: <146705617133.30684.6377761340335782468@sboyd-linaro> References: <1466639150-27814-1-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from mail-pf0-f171.google.com ([209.85.192.171]:36156 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751639AbcF0TgR convert rfc822-to-8bit (ORCPT ); Mon, 27 Jun 2016 15:36:17 -0400 Received: by mail-pf0-f171.google.com with SMTP id t190so64719751pfb.3 for ; Mon, 27 Jun 2016 12:36:17 -0700 (PDT) In-Reply-To: <1466639150-27814-1-git-send-email-john.stultz@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: lkml Cc: John Stultz , Rob Herring , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Quoting John Stultz (2016-06-22 16:45:50) > Since the pmic8xxx-pwrkey driver is already supported in the > qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to > configure proper device shutdown when ps_hold goes low, it is > better to use that driver then a generic gpio button. > > Thus this patch remove the gpio power key entry here, so we > don't get double input events from having two drivers enabled. > > Cc: Rob Herring > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Stephen Boyd > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Acked-by: Rob Herring > Acked-by: Bjorn Andersson > Signed-off-by: John Stultz Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063AbcF0TgT (ORCPT ); Mon, 27 Jun 2016 15:36:19 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35099 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbcF0TgR convert rfc822-to-8bit (ORCPT ); Mon, 27 Jun 2016 15:36:17 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: John Stultz , "lkml" From: Stephen Boyd In-Reply-To: <1466639150-27814-1-git-send-email-john.stultz@linaro.org> Cc: "John Stultz" , "Rob Herring" , "Andy Gross" , "Bjorn Andersson" , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <1466639150-27814-1-git-send-email-john.stultz@linaro.org> Message-ID: <146705617133.30684.6377761340335782468@sboyd-linaro> User-Agent: alot/0.3.7 Subject: Re: [RESEND][PATCH] device-tree: nexus7: Remove power gpio key entry and use pmic8xxx-pwrkey Date: Mon, 27 Jun 2016 12:36:11 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting John Stultz (2016-06-22 16:45:50) > Since the pmic8xxx-pwrkey driver is already supported in the > qcom-apq8064.dtsi, and the pmic8xxx-pwrkey supports logic to > configure proper device shutdown when ps_hold goes low, it is > better to use that driver then a generic gpio button. > > Thus this patch remove the gpio power key entry here, so we > don't get double input events from having two drivers enabled. > > Cc: Rob Herring > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Stephen Boyd > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Acked-by: Rob Herring > Acked-by: Bjorn Andersson > Signed-off-by: John Stultz Reviewed-by: Stephen Boyd