From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbcF2NYX (ORCPT ); Wed, 29 Jun 2016 09:24:23 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:57719 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752404AbcF2NVB (ORCPT ); Wed, 29 Jun 2016 09:21:01 -0400 X-AuditID: cbfee68f-f79476d000001429-1d-5773cb380ac0 From: Andi Shyti To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH 06/15] lirc_dev: do not use goto to create loops Date: Wed, 29 Jun 2016 22:20:35 +0900 Message-id: <1467206444-9935-7-git-send-email-andi.shyti@samsung.com> X-Mailer: git-send-email 2.8.1 In-reply-to: <1467206444-9935-1-git-send-email-andi.shyti@samsung.com> References: <1467206444-9935-1-git-send-email-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrFLMWRmVeSWpSXmKPExsWyRsSkUNfidHG4weWDphbbjzxjtVj84zmT xeVdc9gsejZsZbVY/azCgdXj+pJPzB5b+u+ye/RtWcXo8XmTXABLFJdNSmpOZllqkb5dAlfG rOfTWAr2sFXsXvuHsYGxm7WLkZNDQsBE4tP+iSwQtpjEhXvr2boYuTiEBFYwSkw9uAwowQFW 9PytMkR8KaNE14U/TBDOR0aJSae+s4F0swloSjTd/sEG0iAiYCxx7oc6SJhZoJlRYvd1IxBb WMBBYs+2C2DLWARUJVbNmwLWyivgKvG2ayYjxBFyEpenPwCLcwq4SSw/f5MdxBYCqml9+p8R ZK+EQDe7xOQ1b1ghBglIfJt8COpQWYlNB5gh5khKHFxxg2UCo/ACRoZVjKKpBckFxUnpRcZ6 xYm5xaV56XrJ+bmbGIFBfPrfs/4djHcPWB9iFOBgVOLh/XG4OFyINbGsuDL3EKMp0IaJzFKi yfnAWMkriTc0NjOyMDUxNTYytzRTEuddKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVANj s6pZ+gpmxcWTbguZ2TgqdKXnJTbsWXJ355beEP6zhmu/Lrfvmepty7pl85k3l69MdVhZvezR 8znrhQsc1JdMuCLHwRe5/BPnAVnPjb+LGVZpTtr1XKSPZUGsl1nNjxfLzCf/XRqfbrPv4I9r f9WWsxafDeyu2OXOcsxvdfzPCRu+LDVnl9fhU2Ipzkg01GIuKk4EAAuvOIVdAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRmVeSWpSXmKPExsVy+t9jAV2L08XhBgduGFpsP/KM1WLxj+dM Fpd3zWGz6NmwldVi9bMKB1aP60s+MXts6b/L7tG3ZRWjx+dNcgEsUQ2MNhmpiSmpRQqpecn5 KZl56bZK3sHxzvGmZgaGuoaWFuZKCnmJuam2Si4+AbpumTlAe5UUyhJzSoFCAYnFxUr6dpgm hIa46VrANEbo+oYEwfUYGaCBhDWMGbOeT2Mp2MNWsXvtH8YGxm7WLkYODgkBE4nnb5W7GDmB TDGJC/fWs3UxcnEICSxllOi68IcJwvnIKDHp1Hc2kCo2AU2Jpts/2ECaRQSMJc79UAcJMws0 M0rsvm4EYgsLOEjs2XaBBcRmEVCVWDVvClgrr4CrxNuumYwQy+QkLk9/ABbnFHCTWH7+JjuI LQRU0/r0P+MERt4FjAyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYIj5Zn0DsbDu9wP MQpwMCrx8FpcKAoXYk0sK67MPcQowcGsJMIrd6I4XIg3JbGyKrUoP76oNCe1+BCjKdBhE5ml RJPzgVGcVxJvaGxiZmRpZG5oYWRsriTO+/j/ujAhgfTEktTs1NSC1CKYPiYOTqkGRtuPleUn JVJvTBWo27XHYXvZdZ8Z7KtOJU4+ob+PN3jVsw3/CkJeX/xz8L+iWb2Se2Dq55OmbBvny/3o frGn1zbh+M7ATK/EOIfylUwzU96u23uQ1Wc749Jj33OSFUub/2QLXWZ7I/vy8ocy3mQdq13f H27wZ3b7q/HkO9e17X/mRDjcfHguIEOJpTgj0VCLuag4EQCfsvlzqgIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... use "do .. while" instead. Signed-off-by: Andi Shyti --- drivers/media/rc/lirc_dev.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index 400ab80..cc00b9a 100644 --- a/drivers/media/rc/lirc_dev.c +++ b/drivers/media/rc/lirc_dev.c @@ -103,12 +103,11 @@ static int lirc_add_to_buf(struct irctl *ir) * service the device as long as it is returning * data and we have space */ -get_data: - res = ir->d.add_to_buf(ir->d.data, ir->buf); - if (res == 0) { - got_data++; - goto get_data; - } + do { + res = ir->d.add_to_buf(ir->d.data, ir->buf); + if (!res) + got_data++; + } while (!res); if (res == -ENODEV) kthread_stop(ir->task); -- 2.8.1