From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Boyd <stephen.boyd@linaro.org>
Subject: Re: [PATCH 17/21] usb: chipidea: msm: Make platform data driver local
 instead of global
Date: Wed, 29 Jun 2016 12:17:12 -0700
Message-ID: <146722783258.16253.8246581455698560411@sboyd-linaro>
References: <20160626072838.28082-1-stephen.boyd@linaro.org>
 <20160626072838.28082-18-stephen.boyd@linaro.org>
 <20160629112925.GN25236@shlinux2>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org>
In-Reply-To: <20160629112925.GN25236@shlinux2>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org
To: Peter Chen <hzpeterchen@gmail.com>
Cc: Felipe Balbi <balbi@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Neil Armstrong <narmstrong@baylibre.com>, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, Peter Chen <peter.chen@nxp.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Gross <andy.gross@linaro.org>, linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-msm@vger.kernel.org

Quoting Peter Chen (2016-06-29 04:29:25)
> On Sun, Jun 26, 2016 at 12:28:34AM -0700, Stephen Boyd wrote:
> > @@ -204,7 +201,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
> >       of_node_put(ulpi_node);
> >  
> >       plat_ci = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > -                                  pdev->num_resources, &ci_hdrc_msm_platdata);
> > +                                  pdev->num_resources, &ci->pdata);
> >       if (IS_ERR(plat_ci)) {
> >               dev_err(&pdev->dev, "ci_hdrc_add_device failed!\n");
> >               ret = PTR_ERR(plat_ci);
> 
> You can do something like ci_hdrc_usb2.c, it looks simpler. 
> 

Do what exactly? I'd rather not do a structure copy because that wastes
some memory for a structure that is just a template. We add some more
code here to assign values directly, but that is smaller size wise than
the large platdata structure that only has a few values set in it.

From mboxrd@z Thu Jan  1 00:00:00 1970
From: stephen.boyd@linaro.org (Stephen Boyd)
Date: Wed, 29 Jun 2016 12:17:12 -0700
Subject: [PATCH 17/21] usb: chipidea: msm: Make platform data driver local
 instead of global
In-Reply-To: <20160629112925.GN25236@shlinux2>
References: <20160626072838.28082-1-stephen.boyd@linaro.org>
 <20160626072838.28082-18-stephen.boyd@linaro.org>
 <20160629112925.GN25236@shlinux2>
Message-ID: <146722783258.16253.8246581455698560411@sboyd-linaro>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Quoting Peter Chen (2016-06-29 04:29:25)
> On Sun, Jun 26, 2016 at 12:28:34AM -0700, Stephen Boyd wrote:
> > @@ -204,7 +201,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
> >       of_node_put(ulpi_node);
> >  
> >       plat_ci = ci_hdrc_add_device(&pdev->dev, pdev->resource,
> > -                                  pdev->num_resources, &ci_hdrc_msm_platdata);
> > +                                  pdev->num_resources, &ci->pdata);
> >       if (IS_ERR(plat_ci)) {
> >               dev_err(&pdev->dev, "ci_hdrc_add_device failed!\n");
> >               ret = PTR_ERR(plat_ci);
> 
> You can do something like ci_hdrc_usb2.c, it looks simpler. 
> 

Do what exactly? I'd rather not do a structure copy because that wastes
some memory for a structure that is just a template. We add some more
code here to assign values directly, but that is smaller size wise than
the large platdata structure that only has a few values set in it.