From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH 10/21] usb: chipidea: msm: Rely on core to override AHBBURST Date: Wed, 29 Jun 2016 18:41:13 -0700 Message-ID: <146725087367.32568.2173579806935264329@sboyd-linaro> References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-11-stephen.boyd@linaro.org> <20160629063211.GE25236@shlinux2> <146722676163.16253.15476996138920236894@sboyd-linaro> <20160630011827.GA19743@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160630011827.GA19743@shlinux2> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Peter Chen Cc: Felipe Balbi , Arnd Bergmann , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Peter Chen , Greg Kroah-Hartman , Andy Gross , linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org Quoting Peter Chen (2016-06-29 18:18:27) > On Wed, Jun 29, 2016 at 11:59:21AM -0700, Stephen Boyd wrote: > > Quoting Peter Chen (2016-06-28 23:32:11) > > > On Sun, Jun 26, 2016 at 12:28:27AM -0700, Stephen Boyd wrote: > > > > The core framework already handles setting this parameter with a > > > > platform quirk. Add the appropriate flag so that we always set > > > > AHBBURST to 0. Technically DT should be doing this, but we always > > > > do it for msm chipidea devices so setting the flag in the driver > > > > works just as well. > > > > > > You still need to set AHB burst value at dts, this flag is just for > > > override, see below: > > > > > > ahb-burst-config = <0x0>; > > > > Right, I have added that to dts now, but the CI_HDRC_OVERRIDE_AHB_BURST > > flag allows us to specify it from the platdata structure in the > > ci_hdrc_msm.c file. As the value is zero for msm type controllers, I > > left it out of the static definition of platdata because all the > > non-initialized members of that structure are going to be zero anyway. I > > can explicitly set it to zero to make it more clear if you like. > > I suggest setting it explicitly at dts, at current code, it is set > as zero explicitly too:) > Yes I'm making sure to always set it in dts as well. Should we drop this patch and require dts to always have it set if needed? I was setting it in the driver in case we had some older dts lying around, but I suppose this is changing significantly enough where the qcom,ci_hdrc_msm binding needs to be redone anyway. I'd still like to remove writing the value in the reset callback though. From mboxrd@z Thu Jan 1 00:00:00 1970 From: stephen.boyd@linaro.org (Stephen Boyd) Date: Wed, 29 Jun 2016 18:41:13 -0700 Subject: [PATCH 10/21] usb: chipidea: msm: Rely on core to override AHBBURST In-Reply-To: <20160630011827.GA19743@shlinux2> References: <20160626072838.28082-1-stephen.boyd@linaro.org> <20160626072838.28082-11-stephen.boyd@linaro.org> <20160629063211.GE25236@shlinux2> <146722676163.16253.15476996138920236894@sboyd-linaro> <20160630011827.GA19743@shlinux2> Message-ID: <146725087367.32568.2173579806935264329@sboyd-linaro> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Peter Chen (2016-06-29 18:18:27) > On Wed, Jun 29, 2016 at 11:59:21AM -0700, Stephen Boyd wrote: > > Quoting Peter Chen (2016-06-28 23:32:11) > > > On Sun, Jun 26, 2016 at 12:28:27AM -0700, Stephen Boyd wrote: > > > > The core framework already handles setting this parameter with a > > > > platform quirk. Add the appropriate flag so that we always set > > > > AHBBURST to 0. Technically DT should be doing this, but we always > > > > do it for msm chipidea devices so setting the flag in the driver > > > > works just as well. > > > > > > You still need to set AHB burst value at dts, this flag is just for > > > override, see below: > > > > > > ahb-burst-config = <0x0>; > > > > Right, I have added that to dts now, but the CI_HDRC_OVERRIDE_AHB_BURST > > flag allows us to specify it from the platdata structure in the > > ci_hdrc_msm.c file. As the value is zero for msm type controllers, I > > left it out of the static definition of platdata because all the > > non-initialized members of that structure are going to be zero anyway. I > > can explicitly set it to zero to make it more clear if you like. > > I suggest setting it explicitly at dts, at current code, it is set > as zero explicitly too:) > Yes I'm making sure to always set it in dts as well. Should we drop this patch and require dts to always have it set if needed? I was setting it in the driver in case we had some older dts lying around, but I suppose this is changing significantly enough where the qcom,ci_hdrc_msm binding needs to be redone anyway. I'd still like to remove writing the value in the reset callback though.