From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc Date: Thu, 30 Jun 2016 12:54:28 +0300 Message-ID: <1467280468.30123.350.camel@linux.intel.com> References: <1467250062-61583-1-git-send-email-wangkefeng.wang@huawei.com> <1467250062-61583-3-git-send-email-wangkefeng.wang@huawei.com> <1467279517.30123.346.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga01.intel.com ([192.55.52.88]:61505 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbcF3Jye (ORCPT ); Thu, 30 Jun 2016 05:54:34 -0400 In-Reply-To: <1467279517.30123.346.camel@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Kefeng Wang , Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, z.liuxinliang@hisilicon.com, guohanjun@huawei.com, linux-acpi@vger.kernel.org, xuwei5@hisilicon.com, graeme.gregory@linaro.org On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: > On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > > that it is not 16550 compatibal. > >=20 > > Meanwhile, set dw8250_serial_out32 to keep consistent between > > serial_out > > and serial_in in ACPI. > >=20 > > Signed-off-by: Kefeng Wang > > --- > > =C2=A0drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- > > =C2=A01 file changed, 11 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > b/drivers/tty/serial/8250/8250_dw.c > > index 65f3da7..096431b 100644 > > --- a/drivers/tty/serial/8250/8250_dw.c > > +++ b/drivers/tty/serial/8250/8250_dw.c > > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan > > *chan, void *param) > > =C2=A0 return param =3D=3D chan->device->dev->parent; > > =C2=A0} > > =C2=A0 > > +/* non 16550 compatible id list*/ > > +static const struct acpi_device_id non_16550_id_list[] =3D { > > + { "HISI0031", 0 }, > > + { }, > > +}; > > + >=20 > On first glance it looks redundant, see below. Oh, wait, this is still valid, but the better solution is to use device properties for the rest except yours! I will prepare patch later this week or at the beginning of next week i= f you are in hurry, otherwise I would postpone this a bit (anyway it will not make v4.8 cycle). --=20 Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbcF3Jyg (ORCPT ); Thu, 30 Jun 2016 05:54:36 -0400 Received: from mga01.intel.com ([192.55.52.88]:61505 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbcF3Jye (ORCPT ); Thu, 30 Jun 2016 05:54:34 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,551,1459839600"; d="scan'208";a="727288179" Message-ID: <1467280468.30123.350.camel@linux.intel.com> Subject: Re: [PATCH v2 2/2] serial: 8250_dw: add ACPI support for uart on Hisilicon Hip05 soc From: Andy Shevchenko To: Kefeng Wang , Greg Kroah-Hartman Cc: Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, z.liuxinliang@hisilicon.com, guohanjun@huawei.com, linux-acpi@vger.kernel.org, xuwei5@hisilicon.com, graeme.gregory@linaro.org Date: Thu, 30 Jun 2016 12:54:28 +0300 In-Reply-To: <1467279517.30123.346.camel@linux.intel.com> References: <1467250062-61583-1-git-send-email-wangkefeng.wang@huawei.com> <1467250062-61583-3-git-send-email-wangkefeng.wang@huawei.com> <1467279517.30123.346.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-30 at 12:38 +0300, Andy Shevchenko wrote: > On Thu, 2016-06-30 at 09:27 +0800, Kefeng Wang wrote: > > Add ACPI identifier for UART on Hisilicon Hip05 soc, be careful > > that it is not 16550 compatibal. > > > > Meanwhile, set dw8250_serial_out32 to keep consistent between > > serial_out > > and serial_in in ACPI. > > > > Signed-off-by: Kefeng Wang > > --- > >  drivers/tty/serial/8250/8250_dw.c | 13 +++++++++++-- > >  1 file changed, 11 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/tty/serial/8250/8250_dw.c > > b/drivers/tty/serial/8250/8250_dw.c > > index 65f3da7..096431b 100644 > > --- a/drivers/tty/serial/8250/8250_dw.c > > +++ b/drivers/tty/serial/8250/8250_dw.c > > @@ -272,6 +272,12 @@ static bool dw8250_idma_filter(struct dma_chan > > *chan, void *param) > >   return param == chan->device->dev->parent; > >  } > >   > > +/* non 16550 compatible id list*/ > > +static const struct acpi_device_id non_16550_id_list[] = { > > + { "HISI0031", 0 }, > > + { }, > > +}; > > + > > On first glance it looks redundant, see below. Oh, wait, this is still valid, but the better solution is to use device properties for the rest except yours! I will prepare patch later this week or at the beginning of next week if you are in hurry, otherwise I would postpone this a bit (anyway it will not make v4.8 cycle). -- Andy Shevchenko Intel Finland Oy