From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbcF3Mzw (ORCPT ); Thu, 30 Jun 2016 08:55:52 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:55862 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751704AbcF3Mzv (ORCPT ); Thu, 30 Jun 2016 08:55:51 -0400 Message-ID: <1467291345.11091.16.camel@mtksdaap41> Subject: Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string From: Garlic Tseng To: Mark Brown CC: , , , , , , , , Date: Thu, 30 Jun 2016 20:55:45 +0800 In-Reply-To: <20160629191500.GU6247@sirena.org.uk> References: <1466149440-23889-1-git-send-email-garlic.tseng@mediatek.com> <1466149440-23889-8-git-send-email-garlic.tseng@mediatek.com> <20160629191500.GU6247@sirena.org.uk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > > Add supports for 16k (wideband BT) and add a general compatible > > string "linux,bt-sco" > > This will claim that we support 16k on existing systems which we clearly > don't. It also seems unwise to advertise multiple rates when we've no > way to configure the rates... how does the BT controller figure out > what the sample rate is? The codec driver is a dummy driver for bt device and actually do nothing. The user-space will control both bt part and alsa part (at least in mt2701 platform). Yes the sound/soc/codecs/bt-sco.c was only support 8k and was already there before the patch, but I think it might be ok to extend it to 16k without any side effect. If you worry about some potential risk (I don't see any) maybe we have to develop another dummy bt-sco codec driver which support both 8k and 16k? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Garlic Tseng Subject: Re: [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string Date: Thu, 30 Jun 2016 20:55:45 +0800 Message-ID: <1467291345.11091.16.camel@mtksdaap41> References: <1466149440-23889-1-git-send-email-garlic.tseng@mediatek.com> <1466149440-23889-8-git-send-email-garlic.tseng@mediatek.com> <20160629191500.GU6247@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by alsa0.perex.cz (Postfix) with ESMTP id 334172651A3 for ; Thu, 30 Jun 2016 14:55:52 +0200 (CEST) In-Reply-To: <20160629191500.GU6247@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, ir.lian@mediatek.com, srv_heupstream@mediatek.com, tiwai@suse.de, linux-kernel@vger.kernel.org, koro.chen@mediatek.com, linux-mediatek@lists.infradead.org, PC.Liao@mediatek.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > > Add supports for 16k (wideband BT) and add a general compatible > > string "linux,bt-sco" > > This will claim that we support 16k on existing systems which we clearly > don't. It also seems unwise to advertise multiple rates when we've no > way to configure the rates... how does the BT controller figure out > what the sample rate is? The codec driver is a dummy driver for bt device and actually do nothing. The user-space will control both bt part and alsa part (at least in mt2701 platform). Yes the sound/soc/codecs/bt-sco.c was only support 8k and was already there before the patch, but I think it might be ok to extend it to 16k without any side effect. If you worry about some potential risk (I don't see any) maybe we have to develop another dummy bt-sco codec driver which support both 8k and 16k? From mboxrd@z Thu Jan 1 00:00:00 1970 From: garlic.tseng@mediatek.com (Garlic Tseng) Date: Thu, 30 Jun 2016 20:55:45 +0800 Subject: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string In-Reply-To: <20160629191500.GU6247@sirena.org.uk> References: <1466149440-23889-1-git-send-email-garlic.tseng@mediatek.com> <1466149440-23889-8-git-send-email-garlic.tseng@mediatek.com> <20160629191500.GU6247@sirena.org.uk> Message-ID: <1467291345.11091.16.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > > Add supports for 16k (wideband BT) and add a general compatible > > string "linux,bt-sco" > > This will claim that we support 16k on existing systems which we clearly > don't. It also seems unwise to advertise multiple rates when we've no > way to configure the rates... how does the BT controller figure out > what the sample rate is? The codec driver is a dummy driver for bt device and actually do nothing. The user-space will control both bt part and alsa part (at least in mt2701 platform). Yes the sound/soc/codecs/bt-sco.c was only support 8k and was already there before the patch, but I think it might be ok to extend it to 16k without any side effect. If you worry about some potential risk (I don't see any) maybe we have to develop another dummy bt-sco codec driver which support both 8k and 16k?