From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387AbcF3PTk (ORCPT ); Thu, 30 Jun 2016 11:19:40 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:35134 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075AbcF3PTj (ORCPT ); Thu, 30 Jun 2016 11:19:39 -0400 From: Gustavo Padovan To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Daniel Stone , Daniel Vetter , Rob Clark , Greg Hackmann , John Harrison , laurent.pinchart@ideasonboard.com, seanpaul@google.com, marcheu@google.com, m.chehab@samsung.com, Sumit Semwal , Maarten Lankhorst , Gustavo Padovan Subject: [PATCH 0/2] dma-buf/sync_file: rework fences on struct sync_file Date: Thu, 30 Jun 2016 11:09:46 -0300 Message-Id: <1467295788-6422-1-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gustavo Padovan Hi all, This is an attempt to improve fence support on Sync File. The basic idea is to have only sync_file->fence and store all fences there, either as normal fences or fence_arrays. That way we can remove some potential duplication when using fence_array with sync_file: the duplication of the array of fences and the duplication of fence_add_callback() for all fences. Now when creating a new sync_file during the merge process sync_file_set_fence() will set sync_file->fence based on the number of fences for that sync_file. If there is more than one fence a fence_array is created. One important advantage approach is that we only add one fence callback now, no matter how many fences there are in a sync_file - the individual callbacks are added by fence_array. Please review! Thanks! Gustavo Changes since RFC v2 (Comments from Chris Wilson and Christian König): - struct sync_file lost status member in favor of fence_is_signaled() - drop use of fence_array_teardown() - use sizeof(*fence) to allocate only an array on fence pointers Changes since RFC v1 (Comments from Chris Wilson and Christian König): - Not using fence_ops anymore. - fence_is_array() was created to differentiate fence from fence_array - fence_array_teardown() is now exported and used under fence_is_array() - struct sync_file lost num_fences member Gustavo Padovan (2): dma-buf/fence-array: add fence_is_array() dma-buf/sync_file: rework fence storage in struct file drivers/dma-buf/sync_file.c | 163 ++++++++++++++++++++++------------- drivers/staging/android/sync_debug.c | 13 ++- include/linux/fence-array.h | 10 +++ include/linux/sync_file.h | 17 ++-- 4 files changed, 128 insertions(+), 75 deletions(-) -- 2.5.5 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: [PATCH 0/2] dma-buf/sync_file: rework fences on struct sync_file Date: Thu, 30 Jun 2016 11:09:46 -0300 Message-ID: <1467295788-6422-1-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9048B6E8A2 for ; Thu, 30 Jun 2016 14:09:57 +0000 (UTC) Received: by mail-qk0-f195.google.com with SMTP id n132so16844870qka.0 for ; Thu, 30 Jun 2016 07:09:57 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: marcheu@google.com, Daniel Stone , seanpaul@google.com, Daniel Vetter , linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, Gustavo Padovan , John Harrison , m.chehab@samsung.com List-Id: dri-devel@lists.freedesktop.org RnJvbTogR3VzdGF2byBQYWRvdmFuIDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgoK SGkgYWxsLCAKICAKVGhpcyBpcyBhbiBhdHRlbXB0IHRvIGltcHJvdmUgZmVuY2Ugc3VwcG9ydCBv biBTeW5jIEZpbGUuIFRoZSBiYXNpYyBpZGVhICAKaXMgdG8gaGF2ZSBvbmx5IHN5bmNfZmlsZS0+ ZmVuY2UgYW5kIHN0b3JlIGFsbCBmZW5jZXMgdGhlcmUsIGVpdGhlciBhcyAKbm9ybWFsIGZlbmNl cyBvciBmZW5jZV9hcnJheXMuIFRoYXQgd2F5IHdlIGNhbiByZW1vdmUgc29tZSBwb3RlbnRpYWwK ZHVwbGljYXRpb24gd2hlbiB1c2luZyBmZW5jZV9hcnJheSB3aXRoIHN5bmNfZmlsZTogdGhlIGR1 cGxpY2F0aW9uIG9mIHRoZSBhcnJheSAKb2YgZmVuY2VzIGFuZCB0aGUgZHVwbGljYXRpb24gb2Yg ZmVuY2VfYWRkX2NhbGxiYWNrKCkgZm9yIGFsbCBmZW5jZXMuICAKICAKTm93IHdoZW4gY3JlYXRp bmcgYSBuZXcgc3luY19maWxlIGR1cmluZyB0aGUgbWVyZ2UgcHJvY2VzcyBzeW5jX2ZpbGVfc2V0 X2ZlbmNlKCkKd2lsbCBzZXQgc3luY19maWxlLT5mZW5jZSBiYXNlZCBvbiB0aGUgbnVtYmVyIG9m IGZlbmNlcyBmb3IgdGhhdCBzeW5jX2ZpbGUuIElmICAKdGhlcmUgaXMgbW9yZSB0aGFuIG9uZSBm ZW5jZSBhIGZlbmNlX2FycmF5IGlzIGNyZWF0ZWQuIE9uZSBpbXBvcnRhbnQgYWR2YW50YWdlICAK YXBwcm9hY2ggaXMgdGhhdCB3ZSBvbmx5IGFkZCBvbmUgZmVuY2UgY2FsbGJhY2sgbm93LCBubyBt YXR0ZXIgaG93IG1hbnkgZmVuY2VzICAKdGhlcmUgYXJlIGluIGEgc3luY19maWxlIC0gdGhlIGlu ZGl2aWR1YWwgY2FsbGJhY2tzIGFyZSBhZGRlZCBieSBmZW5jZV9hcnJheS4KICAKUGxlYXNlIHJl dmlldyEgVGhhbmtzISAKICAKICBHdXN0YXZvICAKCkNoYW5nZXMgc2luY2UgUkZDIHYyIChDb21t ZW50cyBmcm9tIENocmlzIFdpbHNvbiBhbmQgQ2hyaXN0aWFuIEvDtm5pZyk6ICAKIC0gc3RydWN0 IHN5bmNfZmlsZSBsb3N0IHN0YXR1cyBtZW1iZXIgaW4gZmF2b3Igb2YgZmVuY2VfaXNfc2lnbmFs ZWQoKQogLSBkcm9wIHVzZSBvZiBmZW5jZV9hcnJheV90ZWFyZG93bigpCiAtIHVzZSBzaXplb2Yo KmZlbmNlKSB0byBhbGxvY2F0ZSBvbmx5IGFuIGFycmF5IG9uIGZlbmNlIHBvaW50ZXJzCgpDaGFu Z2VzIHNpbmNlIFJGQyB2MSAoQ29tbWVudHMgZnJvbSBDaHJpcyBXaWxzb24gYW5kIENocmlzdGlh biBLw7ZuaWcpOiAgCiAtIE5vdCB1c2luZyBmZW5jZV9vcHMgYW55bW9yZS4KIC0gZmVuY2VfaXNf YXJyYXkoKSB3YXMgY3JlYXRlZCB0byBkaWZmZXJlbnRpYXRlIGZlbmNlIGZyb20gZmVuY2VfYXJy YXkgIAogLSBmZW5jZV9hcnJheV90ZWFyZG93bigpIGlzIG5vdyBleHBvcnRlZCBhbmQgdXNlZCB1 bmRlciBmZW5jZV9pc19hcnJheSgpCiAtIHN0cnVjdCBzeW5jX2ZpbGUgbG9zdCBudW1fZmVuY2Vz IG1lbWJlciAKCkd1c3Rhdm8gUGFkb3ZhbiAoMik6CiAgZG1hLWJ1Zi9mZW5jZS1hcnJheTogYWRk IGZlbmNlX2lzX2FycmF5KCkKICBkbWEtYnVmL3N5bmNfZmlsZTogcmV3b3JrIGZlbmNlIHN0b3Jh Z2UgaW4gc3RydWN0IGZpbGUKCiBkcml2ZXJzL2RtYS1idWYvc3luY19maWxlLmMgICAgICAgICAg fCAxNjMgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIGRyaXZlcnMvc3RhZ2lu Zy9hbmRyb2lkL3N5bmNfZGVidWcuYyB8ICAxMyArKy0KIGluY2x1ZGUvbGludXgvZmVuY2UtYXJy YXkuaCAgICAgICAgICB8ICAxMCArKysKIGluY2x1ZGUvbGludXgvc3luY19maWxlLmggICAgICAg ICAgICB8ICAxNyArKy0tCiA0IGZpbGVzIGNoYW5nZWQsIDEyOCBpbnNlcnRpb25zKCspLCA3NSBk ZWxldGlvbnMoLSkKCi0tIAoyLjUuNQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==