From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 10/16] drm: Don't call drm_dev_set_unique from platform drivers Date: Fri, 17 Jun 2016 14:12:09 +0300 Message-ID: <14673064.ujHFono6l2@avalon> References: <1466148814-8194-1-git-send-email-daniel.vetter@ffwll.ch> <1466148814-8194-11-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1466148814-8194-11-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Intel Graphics Development , Emil Velikov , DRI Development , Daniel Vetter , Maxime Ripard List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXkgMTcgSnVuIDIw MTYgMDk6MzM6MjggRGFuaWVsIFZldHRlciB3cm90ZToKPiBTaW5jZQo+IAo+IGNvbW1pdCBlMTEy ZTU5M2IyMTVjMzk0YzAzMDNkYmYwNTM0ZGIwOTI4ZTg3OTY3Cj4gQXV0aG9yOiBOaWNvbGFzIElv b3NzIDxuaWNvbGFzLmlvb3NzX2xpbnV4QG00eC5vcmc+Cj4gRGF0ZTogICBGcmkgRGVjIDExIDEx OjIwOjI4IDIwMTUgKzAxMDAKPiAKPiAgICAgZHJtOiB1c2UgZGV2X25hbWUgYXMgZGVmYXVsdCB1 bmlxdWUgbmFtZSBpbiBkcm1fZGV2X2FsbG9jKCkKPiAKPiB3ZSdyZSB1c2luZyBhIHJlYXNvbmFi bGUgZGVmYXVsdCB3aGljaCBzaG91bGQgd29yayBmb3IgZXZlcnlvbmUuIE9ubHkKPiBtdGssIHJj YXItZHUgYW5kIHN1bjRpIGFyZSBhZmZlY3RlZCwgYW5kIGFzIGttcy1vbmx5IGRyaXZlcnMgd2l0 aG91dAo+IGFueSByZW5kZXJpbmcgc3VwcG9ydCBubyBvbmUgc2hvdWxkIGV2ZXIgY2FyZSBhYm91 dCB0aGUgdW5pcXVlIG5hbWUKPiAKPiB2MjogUmViYXNlIG9uIHRvcCBvZiBtZWRpYXRlay4KPiAK PiBDYzogUGhpbGlwcCBaYWJlbCA8cC56YWJlbEBwZW5ndXRyb25peC5kZT4KPiBDYzogTWF4aW1l IFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gQ2M6IExhdXJlbnQg UGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KPiBDYzogRW1pbCBW ZWxpa292IDxlbWlsLmwudmVsaWtvdkBnbWFpbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVs IFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQ aW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2RybV9kcnYuYyAgICAgICAgICAgICAgfCAzNSArKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2LmMg fCAgMiAtLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jICB8ICAyIC0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9kcnYuYyAgICAgIHwgIDQgLS0tLQo+ICBp bmNsdWRlL2RybS9kcm1QLmggICAgICAgICAgICAgICAgICAgICB8ICAxIC0KPiAgNSBmaWxlcyBj aGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAzMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZHJ2LmMK PiBpbmRleCBlY2JhMjUxMWVmNWEuLjI1ZjEwNTg2YTc0ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9kcnYuYwo+IEBA IC0yOTgsMTAgKzI5OCw5IEBAIHZvaWQgZHJtX21pbm9yX3JlbGVhc2Uoc3RydWN0IGRybV9taW5v ciAqbWlub3IpCj4gICAqIGNhbGxiYWNrcyBpbXBsZW1lbnRlZCBieSB0aGUgZHJpdmVyLiBUaGUg ZHJpdmVyIHRoZW4gbmVlZHMgdG8gaW5pdGlhbGl6ZQo+IGFsbCAqIHRoZSB2YXJpb3VzIHN1YnN5 c3RlbXMgZm9yIHRoZSBkcm0gZGV2aWNlIGxpa2UgbWVtb3J5IG1hbmFnZW1lbnQsCj4gdmJsYW5r ICogaGFuZGxpbmcsIG1vZGVzZXR0aW5nIHN1cHBvcnQgYW5kIGludGlhbCBvdXRwdXQgY29uZmln dXJhdGlvbiBwbHVzCj4gb2J2aW91c2x5IC0gKiBpbml0aWFsaXplIGFsbCB0aGUgY29ycmVzcG9u ZGluZyBoYXJkd2FyZSBiaXRzLiBBbiBpbXBvcnRhbnQKPiBwYXJ0IG9mIHRoaXMgaXMgLSAqIGFs c28gY2FsbGluZyBkcm1fZGV2X3NldF91bmlxdWUoKSB0byBzZXQgdGhlCj4gdXNlcnNwYWNlLXZp c2libGUgdW5pcXVlIG5hbWUgb2YgLSAqIHRoaXMgZGV2aWNlIGluc3RhbmNlLiBGaW5hbGx5IHdo ZW4KPiBldmVyeXRoaW5nIGlzIHVwIGFuZCBydW5uaW5nIGFuZCByZWFkeSBmb3IgLSAqIHVzZXJz cGFjZSB0aGUgZGV2aWNlCj4gaW5zdGFuY2UgY2FuIGJlIHB1Ymxpc2hlZCB1c2luZyBkcm1fZGV2 X3JlZ2lzdGVyKCkuICsgKiBpbml0aWFsaXplIGFsbCB0aGUKPiBjb3JyZXNwb25kaW5nIGhhcmR3 YXJlIGJpdHMuIEZpbmFsbHkgd2hlbiBldmVyeXRoaW5nIGlzIHVwICsgKiBhbmQgcnVubmluZwo+ IGFuZCByZWFkeSBmb3IgdXNlcnNwYWNlIHRoZSBkZXZpY2UgaW5zdGFuY2UgY2FuIGJlIHB1Ymxp c2hlZCArICogdXNpbmcKPiBkcm1fZGV2X3JlZ2lzdGVyKCkuCj4gICAqCj4gICAqIFRoZXJlIGlz IGFsc28gZGVwcmVjYXRlZCBzdXBwb3J0IGZvciBpbml0YWxpemluZyBkZXZpY2UgaW5zdGFuY2Vz IHVzaW5nCj4gICAqIGJ1cy1zcGVjaWZpYyBoZWxwZXJzIGFuZCB0aGUgLT5sb2FkKCkgY2FsbGJh Y2suIEJ1dCBkdWUgdG8KPiBAQCAtMzIzLDYgKzMyMiwxNCBAQCB2b2lkIGRybV9taW5vcl9yZWxl YXNlKHN0cnVjdCBkcm1fbWlub3IgKm1pbm9yKQo+ICAgKiBkZXZfcHJpdiBmaWVsZCBvZiAmZHJt X2RldmljZS4KPiAgICovCj4gCj4gK3N0YXRpYyBpbnQgZHJtX2Rldl9zZXRfdW5pcXVlKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIGNvbnN0IGNoYXIgKm5hbWUpCj4gK3sKPiArCWtmcmVlKGRldi0+ dW5pcXVlKTsKPiArCWRldi0+dW5pcXVlID0ga3N0cmR1cChuYW1lLCBHRlBfS0VSTkVMKTsKPiAr Cj4gKwlyZXR1cm4gZGV2LT51bmlxdWUgPyAwIDogLUVOT01FTTsKPiArfQo+ICsKPiAgLyoqCj4g ICAqIGRybV9wdXRfZGV2IC0gVW5yZWdpc3RlciBhbmQgcmVsZWFzZSBhIERSTSBkZXZpY2UKPiAg ICogQGRldjogRFJNIGRldmljZQo+IEBAIC02OTcsMjYgKzcwNCw2IEBAIHZvaWQgZHJtX2Rldl91 bnJlZ2lzdGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIH0KPiAgRVhQT1JUX1NZTUJPTChk cm1fZGV2X3VucmVnaXN0ZXIpOwo+IAo+IC0vKioKPiAtICogZHJtX2Rldl9zZXRfdW5pcXVlIC0g U2V0IHRoZSB1bmlxdWUgbmFtZSBvZiBhIERSTSBkZXZpY2UKPiAtICogQGRldjogZGV2aWNlIG9m IHdoaWNoIHRvIHNldCB0aGUgdW5pcXVlIG5hbWUKPiAtICogQG5hbWU6IHVuaXF1ZSBuYW1lCj4g LSAqCj4gLSAqIFNldHMgdGhlIHVuaXF1ZSBuYW1lIG9mIGEgRFJNIGRldmljZSB1c2luZyB0aGUg c3BlY2lmaWVkIHN0cmluZy4gRHJpdmVycwo+IC0gKiBjYW4gdXNlIHRoaXMgYXQgZHJpdmVyIHBy b2JlIHRpbWUgaWYgdGhlIHVuaXF1ZSBuYW1lIG9mIHRoZSBkZXZpY2VzCj4gdGhleSAtICogZHJp dmUgaXMgc3RhdGljLgo+IC0gKgo+IC0gKiBSZXR1cm46IDAgb24gc3VjY2VzcyBvciBhIG5lZ2F0 aXZlIGVycm9yIGNvZGUgb24gZmFpbHVyZS4KPiAtICovCj4gLWludCBkcm1fZGV2X3NldF91bmlx dWUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgY29uc3QgY2hhciAqbmFtZSkKPiAtewo+IC0Ja2Zy ZWUoZGV2LT51bmlxdWUpOwo+IC0JZGV2LT51bmlxdWUgPSBrc3RyZHVwKG5hbWUsIEdGUF9LRVJO RUwpOwo+IC0KPiAtCXJldHVybiBkZXYtPnVuaXF1ZSA/IDAgOiAtRU5PTUVNOwo+IC19Cj4gLUVY UE9SVF9TWU1CT0woZHJtX2Rldl9zZXRfdW5pcXVlKTsKPiAtCj4gIC8qCj4gICAqIERSTSBDb3Jl Cj4gICAqIFRoZSBEUk0gY29yZSBtb2R1bGUgaW5pdGlhbGl6ZXMgYWxsIGdsb2JhbCBEUk0gb2Jq ZWN0cyBhbmQgbWFrZXMgdGhlbQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0 ZWsvbXRrX2RybV9kcnYuYwo+IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fZHJ2 LmMgaW5kZXggYzMzYmY5OGM1ZDVlLi4wNGU5MDFhODAyMzQKPiAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9tZWRpYXRlay9tdGtfZHJtX2Rydi5jCj4gQEAgLTI4MCw4ICsyODAsNiBAQCBzdGF0aWMgaW50 IG10a19kcm1fYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAlpZiAoIWRybSkKPiAgCQlyZXR1 cm4gLUVOT01FTTsKPiAKPiAtCWRybV9kZXZfc2V0X3VuaXF1ZShkcm0sIGRldl9uYW1lKGRldikp Owo+IC0KPiAgCWRybS0+ZGV2X3ByaXZhdGUgPSBwcml2YXRlOwo+ICAJcHJpdmF0ZS0+ZHJtID0g ZHJtOwo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Ry di5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jIGluZGV4IDQ4ZWM0 YjZlOGIyNi4uODc4NDIwOGQ4ZWVkCj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3Jj YXItZHUvcmNhcl9kdV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJf ZHVfZHJ2LmMKPiBAQCAtMzIwLDggKzMyMCw2IEBAIHN0YXRpYyBpbnQgcmNhcl9kdV9wcm9iZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJaWYgKCFkZGV2KQo+ICAJCXJldHVybiAt RU5PTUVNOwo+IAo+IC0JZHJtX2Rldl9zZXRfdW5pcXVlKGRkZXYsIGRldl9uYW1lKCZwZGV2LT5k ZXYpKTsKPiAtCj4gIAlyY2R1LT5kZGV2ID0gZGRldjsKPiAgCWRkZXYtPmRldl9wcml2YXRlID0g cmNkdTsKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5j Cj4gYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfZHJ2LmMgaW5kZXggNjhlOWQ4NTA4NWZi Li41YzRiNGFkMTdhZDMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRp X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2Rydi5jCj4gQEAgLTEz NSwxMCArMTM1LDYgQEAgc3RhdGljIGludCBzdW40aV9kcnZfYmluZChzdHJ1Y3QgZGV2aWNlICpk ZXYpCj4gIAlpZiAoIWRybSkKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAKPiAtCXJldCA9IGRybV9k ZXZfc2V0X3VuaXF1ZShkcm0sIGRldl9uYW1lKGRybS0+ZGV2KSk7Cj4gLQlpZiAocmV0KQo+IC0J CWdvdG8gZnJlZV9kcm07Cj4gLQo+ICAJZHJ2ID0gZGV2bV9remFsbG9jKGRldiwgc2l6ZW9mKCpk cnYpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghZHJ2KSB7Cj4gIAkJcmV0ID0gLUVOT01FTTsKPiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtUC5oIGIvaW5jbHVkZS9kcm0vZHJtUC5oCj4gaW5k ZXggNjJlMGU3MGNiNWEyLi5iZDQwZDdlZTVlYzUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0v ZHJtUC5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtUC5oCj4gQEAgLTEwNzMsNyArMTA3Myw2IEBA IHZvaWQgZHJtX2Rldl9yZWYoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIHZvaWQgZHJtX2Rl dl91bnJlZihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgaW50IGRybV9kZXZfcmVnaXN0ZXIo c3RydWN0IGRybV9kZXZpY2UgKmRldiwgdW5zaWduZWQgbG9uZyBmbGFncyk7Cj4gIHZvaWQgZHJt X2Rldl91bnJlZ2lzdGVyKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+IC1pbnQgZHJtX2Rldl9z ZXRfdW5pcXVlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGNvbnN0IGNoYXIgKm5hbWUpOwo+IAo+ ICBzdHJ1Y3QgZHJtX21pbm9yICpkcm1fbWlub3JfYWNxdWlyZSh1bnNpZ25lZCBpbnQgbWlub3Jf aWQpOwo+ICB2b2lkIGRybV9taW5vcl9yZWxlYXNlKHN0cnVjdCBkcm1fbWlub3IgKm1pbm9yKTsK Ci0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg==