All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: [WireGuard] [PATCH 2/4] explain "security reasons"
Date: Thu, 30 Jun 2016 18:55:21 -0400	[thread overview]
Message-ID: <1467327323-8532-2-git-send-email-dkg@fifthhorseman.net> (raw)
In-Reply-To: <1467327323-8532-1-git-send-email-dkg@fifthhorseman.net>

It's generally preferable to avoid vague "security reasons" if there
is a specific concern.

I think the reason we don't want the secret key material directly on
the command line is because of the command line's argument exposure in
the process table.

If there is another reason, i'd be happy to see a different patch
explaining it.
---
 src/tools/wg.8 | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/tools/wg.8 b/src/tools/wg.8
index bffe58b..77e9b0d 100644
--- a/src/tools/wg.8
+++ b/src/tools/wg.8
@@ -55,7 +55,8 @@ Sets configuration values for the specified \fI<interface>\fP. Multiple
 for a peer, that peer is removed, not configured. If \fIlisten-port\fP
 is not specified, the port will be automatically generated when the
 interface comes up. Both \fIprivate-key\fP and \fIpreshared-key\fP must
-be a files, for security reasons, but if you're using
+be files to avoid exposing secret material via the process table's view
+of the command line.  However, if you're using
 .BR bash (1),
 you may safely pass in a string by specifying as \fIprivate-key\fP or
 \fIpreshared-key\fP the expression: <(echo PRIVATEKEYSTRING). If
-- 
2.8.1

  reply	other threads:[~2016-06-30 22:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 22:55 [WireGuard] [PATCH 1/4] address:port separation uses colon, not comma Daniel Kahn Gillmor
2016-06-30 22:55 ` Daniel Kahn Gillmor [this message]
2016-06-30 22:55 ` [WireGuard] [PATCH 3/4] Explain the optional nature of Peer.EndPoint more clearly Daniel Kahn Gillmor
2016-07-01  2:08   ` Jason A. Donenfeld
2016-07-01 12:13     ` Daniel Kahn Gillmor
2016-07-01 20:54       ` Jason A. Donenfeld
2016-06-30 22:55 ` [WireGuard] [PATCH 4/4] Clarify what Peer.AllowedIPs actually constrains Daniel Kahn Gillmor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467327323-8532-2-git-send-email-dkg@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.