All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Ilya Dryomov <idryomov@gmail.com>, zyan@redhat.com
Cc: Sage Weil <sage@redhat.com>,
	ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Al Viro <viro@ZenIV.linux.org.uk>
Subject: [PATCH 0/4] ceph: allow ceph_d_revalidate to handle some cases under LOOKUP_RCU
Date: Tue,  5 Jul 2016 12:27:45 -0400	[thread overview]
Message-ID: <1467736069-27140-1-git-send-email-jlayton@redhat.com> (raw)

The basic idea with this set is to allow the kernel client to allow the
client to do more d_revalidate functionality under the rcu_read_lock.
The idea is basically to do what we can there while not blocking, and
then return -ECHILD for the rest.

The only really questionable bit is the part where we need to take the
d_lock in ceph_d_release. I think it should be largely uncontended, but
it's still less than ideal. Maybe there is some way to handle that
locklessly?

Also, it would be nice to not have to drop out of rcuwalk mode in order
to run the lease renewal. It seems like the kind of thing that would be
ideal to queue to a workqueue, but I don't see a way to do that without
introducing a potential deadlock.

My teuthology run with it passed all but one test, which seems to have
been an unrelated problem (though I could be wrong there).

Jeff Layton (4):
  ceph: remove ceph_mdsc_lease_release
  ceph: clear d_fsinfo pointer under d_lock
  ceph: allow dentry_lease_is_valid to work under RCU walk
  ceph: handle LOOKUP_RCU in ceph_d_revalidate

 fs/ceph/dir.c        | 67 +++++++++++++++++++++++++++++++++++-----------------
 fs/ceph/mds_client.c | 41 --------------------------------
 fs/ceph/mds_client.h |  4 ----
 3 files changed, 45 insertions(+), 67 deletions(-)

-- 
2.5.5


             reply	other threads:[~2016-07-05 16:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05 16:27 Jeff Layton [this message]
2016-07-05 16:27 ` [PATCH 1/4] ceph: remove ceph_mdsc_lease_release Jeff Layton
2016-07-05 16:27 ` [PATCH 2/4] ceph: clear d_fsinfo pointer under d_lock Jeff Layton
2016-07-05 16:27 ` [PATCH 3/4] ceph: allow dentry_lease_is_valid to work under RCU walk Jeff Layton
2016-07-05 16:27 ` [PATCH 4/4] ceph: handle LOOKUP_RCU in ceph_d_revalidate Jeff Layton
2016-07-06  1:55 ` [PATCH 0/4] ceph: allow ceph_d_revalidate to handle some cases under LOOKUP_RCU Yan, Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467736069-27140-1-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sage@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=zyan@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.