From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH v23 12/22] vfs: Add get_richacl and set_richacl inode operations Date: Wed, 06 Jul 2016 14:31:13 -0400 Message-ID: <1467829873.2908.1.camel@redhat.com> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-13-git-send-email-agruenba@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Christoph Hellwig , Theodore Ts'o , Andreas Dilger , "J. Bruce Fields" , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, xfs-VZNHf3L845pBDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andreas Gruenbacher , Alexander Viro Return-path: In-Reply-To: <1467294433-3222-13-git-send-email-agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Thu, 2016-06-30 at 15:47 +0200, Andreas Gruenbacher wrote: > These operations are similar to the get_acl and set_acl operations fo= r > POSIX ACLs.=C2=A0=C2=A0The distinction between access and default ACL= s doesn't exist > for richacls. >=20 > Signed-off-by: Andreas Gruenbacher > Reviewed-by: Steve French > --- > =C2=A0include/linux/fs.h | 2 ++ > =C2=A01 file changed, 2 insertions(+) >=20 > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 06a30b0..ac96bda 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1726,6 +1726,7 @@ struct inode_operations { > =C2=A0 const char * (*get_link) (struct dentry *, struct inode *, str= uct delayed_call *); > =C2=A0 int (*permission) (struct inode *, int); > =C2=A0 struct posix_acl * (*get_acl)(struct inode *, int); > + struct richacl * (*get_richacl)(struct inode *); > =C2=A0 > =C2=A0 int (*readlink) (struct dentry *, char __user *,int); > =C2=A0 > @@ -1756,6 +1757,7 @@ struct inode_operations { > =C2=A0 =C2=A0=C2=A0=C2=A0umode_t create_mode, int *opened); > =C2=A0 int (*tmpfile) (struct inode *, struct dentry *, umode_t); > =C2=A0 int (*set_acl)(struct inode *, struct posix_acl *, int); > + int (*set_richacl)(struct inode *, struct richacl *); > =C2=A0} ____cacheline_aligned; > =C2=A0 > =C2=A0ssize_t rw_copy_check_uvector(int type, const struct iovec __us= er * uvector, Looks OK, though it's hard to review something like this without some context. Maybe this patch should be folded in with the patch that actually adds the calls for these operations? Reviewed-by: Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932355AbcGFSb0 (ORCPT ); Wed, 6 Jul 2016 14:31:26 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:36606 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932088AbcGFSbW (ORCPT ); Wed, 6 Jul 2016 14:31:22 -0400 Message-ID: <1467829873.2908.1.camel@redhat.com> Subject: Re: [PATCH v23 12/22] vfs: Add get_richacl and set_richacl inode operations From: Jeff Layton To: Andreas Gruenbacher , Alexander Viro Cc: Christoph Hellwig , "Theodore Ts'o" , Andreas Dilger , "J. Bruce Fields" , Trond Myklebust , Anna Schumaker , Dave Chinner , linux-ext4@vger.kernel.org, xfs@oss.sgi.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-api@vger.kernel.org Date: Wed, 06 Jul 2016 14:31:13 -0400 In-Reply-To: <1467294433-3222-13-git-send-email-agruenba@redhat.com> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-13-git-send-email-agruenba@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-30 at 15:47 +0200, Andreas Gruenbacher wrote: > These operations are similar to the get_acl and set_acl operations for > POSIX ACLs.  The distinction between access and default ACLs doesn't exist > for richacls. > > Signed-off-by: Andreas Gruenbacher > Reviewed-by: Steve French > --- >  include/linux/fs.h | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 06a30b0..ac96bda 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1726,6 +1726,7 @@ struct inode_operations { >   const char * (*get_link) (struct dentry *, struct inode *, struct delayed_call *); >   int (*permission) (struct inode *, int); >   struct posix_acl * (*get_acl)(struct inode *, int); > + struct richacl * (*get_richacl)(struct inode *); >   >   int (*readlink) (struct dentry *, char __user *,int); >   > @@ -1756,6 +1757,7 @@ struct inode_operations { >      umode_t create_mode, int *opened); >   int (*tmpfile) (struct inode *, struct dentry *, umode_t); >   int (*set_acl)(struct inode *, struct posix_acl *, int); > + int (*set_richacl)(struct inode *, struct richacl *); >  } ____cacheline_aligned; >   >  ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector, Looks OK, though it's hard to review something like this without some context. Maybe this patch should be folded in with the patch that actually adds the calls for these operations? Reviewed-by: Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 987DE7D0D for ; Wed, 6 Jul 2016 13:31:22 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 210B6AC00D for ; Wed, 6 Jul 2016 11:31:18 -0700 (PDT) Received: from mail-qk0-f173.google.com (mail-qk0-f173.google.com [209.85.220.173]) by cuda.sgi.com with ESMTP id BMacTwAEik81l6Dy (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Wed, 06 Jul 2016 11:31:17 -0700 (PDT) Received: by mail-qk0-f173.google.com with SMTP id t127so322465457qkf.1 for ; Wed, 06 Jul 2016 11:31:17 -0700 (PDT) Message-ID: <1467829873.2908.1.camel@redhat.com> Subject: Re: [PATCH v23 12/22] vfs: Add get_richacl and set_richacl inode operations From: Jeff Layton Date: Wed, 06 Jul 2016 14:31:13 -0400 In-Reply-To: <1467294433-3222-13-git-send-email-agruenba@redhat.com> References: <1467294433-3222-1-git-send-email-agruenba@redhat.com> <1467294433-3222-13-git-send-email-agruenba@redhat.com> Mime-Version: 1.0 List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Andreas Gruenbacher , Alexander Viro Cc: "J. Bruce Fields" , linux-nfs@vger.kernel.org, Theodore Ts'o , linux-cifs@vger.kernel.org, linux-api@vger.kernel.org, Trond Myklebust , linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Christoph Hellwig , Andreas Dilger , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Anna Schumaker T24gVGh1LCAyMDE2LTA2LTMwIGF0IDE1OjQ3ICswMjAwLCBBbmRyZWFzIEdydWVuYmFjaGVyIHdy b3RlOgo+IFRoZXNlIG9wZXJhdGlvbnMgYXJlIHNpbWlsYXIgdG8gdGhlIGdldF9hY2wgYW5kIHNl dF9hY2wgb3BlcmF0aW9ucyBmb3IKPiBQT1NJWCBBQ0xzLsKgwqBUaGUgZGlzdGluY3Rpb24gYmV0 d2VlbiBhY2Nlc3MgYW5kIGRlZmF1bHQgQUNMcyBkb2Vzbid0IGV4aXN0Cj4gZm9yIHJpY2hhY2xz Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJlYXMgR3J1ZW5iYWNoZXIgPGFncnVlbmJhQHJlZGhh dC5jb20+Cj4gUmV2aWV3ZWQtYnk6IFN0ZXZlIEZyZW5jaCA8c3RldmUuZnJlbmNoQHByaW1hcnlk YXRhLmNvbT4KPiAtLS0KPiDCoGluY2x1ZGUvbGludXgvZnMuaCB8IDIgKysKPiDCoDEgZmlsZSBj aGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9m cy5oIGIvaW5jbHVkZS9saW51eC9mcy5oCj4gaW5kZXggMDZhMzBiMC4uYWM5NmJkYSAxMDA2NDQK PiAtLS0gYS9pbmNsdWRlL2xpbnV4L2ZzLmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L2ZzLmgKPiBA QCAtMTcyNiw2ICsxNzI2LDcgQEAgc3RydWN0IGlub2RlX29wZXJhdGlvbnMgewo+IMKgCWNvbnN0 IGNoYXIgKiAoKmdldF9saW5rKSAoc3RydWN0IGRlbnRyeSAqLCBzdHJ1Y3QgaW5vZGUgKiwgc3Ry dWN0IGRlbGF5ZWRfY2FsbCAqKTsKPiDCoAlpbnQgKCpwZXJtaXNzaW9uKSAoc3RydWN0IGlub2Rl ICosIGludCk7Cj4gwqAJc3RydWN0IHBvc2l4X2FjbCAqICgqZ2V0X2FjbCkoc3RydWN0IGlub2Rl ICosIGludCk7Cj4gKwlzdHJ1Y3QgcmljaGFjbCAqICgqZ2V0X3JpY2hhY2wpKHN0cnVjdCBpbm9k ZSAqKTsKPiDCoAo+IMKgCWludCAoKnJlYWRsaW5rKSAoc3RydWN0IGRlbnRyeSAqLCBjaGFyIF9f dXNlciAqLGludCk7Cj4gwqAKPiBAQCAtMTc1Niw2ICsxNzU3LDcgQEAgc3RydWN0IGlub2RlX29w ZXJhdGlvbnMgewo+IMKgCQkJwqDCoMKgdW1vZGVfdCBjcmVhdGVfbW9kZSwgaW50ICpvcGVuZWQp Owo+IMKgCWludCAoKnRtcGZpbGUpIChzdHJ1Y3QgaW5vZGUgKiwgc3RydWN0IGRlbnRyeSAqLCB1 bW9kZV90KTsKPiDCoAlpbnQgKCpzZXRfYWNsKShzdHJ1Y3QgaW5vZGUgKiwgc3RydWN0IHBvc2l4 X2FjbCAqLCBpbnQpOwo+ICsJaW50ICgqc2V0X3JpY2hhY2wpKHN0cnVjdCBpbm9kZSAqLCBzdHJ1 Y3QgcmljaGFjbCAqKTsKPiDCoH0gX19fX2NhY2hlbGluZV9hbGlnbmVkOwo+IMKgCj4gwqBzc2l6 ZV90IHJ3X2NvcHlfY2hlY2tfdXZlY3RvcihpbnQgdHlwZSwgY29uc3Qgc3RydWN0IGlvdmVjIF9f dXNlciAqIHV2ZWN0b3IsCgpMb29rcyBPSywgdGhvdWdoIGl0J3MgaGFyZCB0byByZXZpZXcgc29t ZXRoaW5nIGxpa2UgdGhpcyB3aXRob3V0IHNvbWUKY29udGV4dC4gTWF5YmUgdGhpcyBwYXRjaCBz aG91bGQgYmUgZm9sZGVkIGluIHdpdGggdGhlIHBhdGNoIHRoYXQKYWN0dWFsbHkgYWRkcyB0aGUg Y2FsbHMgZm9yIHRoZXNlIG9wZXJhdGlvbnM/CgpSZXZpZXdlZC1ieTogSmVmZiBMYXl0b24gPGps YXl0b25AcmVkaGF0LmNvbT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCnhmcyBtYWlsaW5nIGxpc3QKeGZzQG9zcy5zZ2kuY29tCmh0dHA6Ly9vc3Muc2dp LmNvbS9tYWlsbWFuL2xpc3RpbmZvL3hmcwo=