From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 19/19] xen: credit2: use cpumask_first
 instead of cpumask_any when choosing cpu
Date: Thu, 7 Jul 2016 18:55:10 +0200
Message-ID: <1467910510.23985.87.camel@citrix.com>
References: <146620492155.29766.10321123657058307698.stgit@Solace.fritz.box>
 <146620521750.29766.12008171749820205436.stgit@Solace.fritz.box>
 <57691A00.50103@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4051962946197887749=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
 by lists.xenproject.org with esmtp (Exim 4.84_2)
 (envelope-from <prvs=98972c1c7=dario.faggioli@citrix.com>)
 id 1bLCaV-0005SQ-KL
 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2016 16:55:43 +0000
In-Reply-To: <57691A00.50103@citrix.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: David Vrabel <david.vrabel@citrix.com>, xen-devel@lists.xenproject.org
Cc: Anshul Makkar <anshul.makkar@citrix.com>, George Dunlap <george.dunlap@citrix.com>
List-Id: xen-devel@lists.xenproject.org

--===============4051962946197887749==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-L5Nh3hf8W2k/9bSkRRvL"

--=-L5Nh3hf8W2k/9bSkRRvL
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2016-06-21 at 11:42 +0100, David Vrabel wrote:
> On 18/06/16 00:13, Dario Faggioli wrote:
> >=20
> > because it is cheaper, and there is no much point in
> > randomizing which cpu gets selected anyway, as such
> > choice will be overridden shortly after, in runq_tickle().
> >=20
> > If we really feel the need (e.g., we prove it worth with
> > benchmarking), we can record the last cpu which was used
> > by csched2_cpu_pick() and migrate() in a per-runq variable,
> > and then use cpumask_cycle()... but this really does not
> > look necessary.
> Isn't this backwards?=C2=A0=C2=A0Surely you should demonstrate that this =
change
> is
> beneficial before proposing it?
>=20
Right. I think it's my fault having presented things this way.

This patch get rid of something that is pure overhead, and getting rid
of overhead is, in general, a good thing.

There is only one possible situation under which we may actually end up
favouring lower pCPU IDs, and it is unlikely enough that it is IMO, of
no concern.

But in any case, let's just drop this patch. I'm rerunning the
benchmarks anyway, I'll consider doing a set of runs with and without
this patch, and check if it does make any difference.

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-L5Nh3hf8W2k/9bSkRRvL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJXfolvAAoJEBZCeImluHPu7EwP/3zLyBzz4ccRi9/nTumcW+JK
7uFk/BX6OiCx5LviUj0mUxs38ZJORrh0NLpXfaDQaxGFRNWk2WfMHIrWYmtb79Iq
V6luxaot56CyhYp1rAV2TuNPuO3b6OLjk6VtzLl53Sv7785ZsICa0OckaKzuSn1z
OGnMJq8Wtd6rJfklIV0kGNRgpn6EASplFcka2maJdSd+pABo8YbYIIhT7/Cp+1pc
nWBs/toTmtY7S3bP1LWyImLApaXNTg1v6OS6r3TXKLFycHOp0w2jp/xiKnzbJOSO
Di0UMRlZW6WZjpW3vjCSPKLLCGtkQ11Xr9iL/lMgTH/FdFUGUP4GoLwEvr2zSnb0
0oIfGqWdjSB2Nve1RSAFsfadmCNclo6bg83qF+q5twa/cvL6Akux4nBPwJgS4j8Z
5Ln/jDaRkUPUEH+bXf5h03XvCUIljujUWfC2qiNF6OzPeQ67NXmL7LFcqpxp5BPl
HvI8q8lU555vzqiVrzEbhZq+4hP9pcGZQIvQtnx0uwMNab3JMsDXi7CXqrB/r+zE
U2+RpLwTkuPA01WFHqWSiVSU8H9e2JHz+RYxIuc3VIkucvov3sfQsBzQXqH2f1FB
vZma9OTACqkYAbqsmhc8C3ZyZZkWQk618c8USR+5trKbS2VOsH8BWbYUQNon+lhj
ehE0YGoLuvm1AIgBbeoj
=zg/o
-----END PGP SIGNATURE-----

--=-L5Nh3hf8W2k/9bSkRRvL--


--===============4051962946197887749==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============4051962946197887749==--