From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754567AbcGHKSZ (ORCPT ); Fri, 8 Jul 2016 06:18:25 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45149 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754112AbcGHKST convert rfc822-to-8bit (ORCPT ); Fri, 8 Jul 2016 06:18:19 -0400 Message-ID: <1467973066.2472.238.camel@pengutronix.de> Subject: Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit From: Jan =?ISO-8859-1?Q?L=FCbbe?= To: HS Liao Cc: Rob Herring , Matthias Brugger , Daniel Kurtz , Monica Wang , Jiaguang Zhang , Nicolas Boichat , cawa cheng , Bibby Hsieh , YT Shen , Damon Chu , devicetree@vger.kernel.org, Sascha Hauer , Daoyuan Huang , Sascha Hauer , Glory Hung , CK HU , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, Josh-YC Liu , linux-kernel@vger.kernel.org, Dennis-YC Hsieh , Philipp Zabel Date: Fri, 08 Jul 2016 12:17:46 +0200 In-Reply-To: <1467270883-1407-2-git-send-email-hs.liao@mediatek.com> References: <1467270883-1407-1-git-send-email-hs.liao@mediatek.com> <1467270883-1407-2-git-send-email-hs.liao@mediatek.com> Organization: Pengutronix Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c3 X-SA-Exim-Mail-From: jlu@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote: [...] > +Required properties: > +- compatible: Must be "mediatek,mt8173-gce" > +- reg: Address range of the GCE unit > +- interrupts: The interrupt signal from the GCE block > +- clock: Clocks according to the common clock binding > +- clock-names: Must be "gce" to stand for GCE clock > +- #mbox-cells: Should be 1 [...] > + #mbox-cells = <1>; [...] > + mediatek,gce = <&gce>; > + mboxes = <&gce 0 1 /* main display with merging wfe */ > + &gce 1 1>; /* sub display with merging wfe */ It seems that you use two cells instead of one as you declared above. This should be consistent. Also, why do you need an explicit phandle to the gce if you already use mailboxes? Best regards, Jan Lübbe -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan =?ISO-8859-1?Q?L=FCbbe?= Subject: Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit Date: Fri, 08 Jul 2016 12:17:46 +0200 Message-ID: <1467973066.2472.238.camel@pengutronix.de> References: <1467270883-1407-1-git-send-email-hs.liao@mediatek.com> <1467270883-1407-2-git-send-email-hs.liao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1467270883-1407-2-git-send-email-hs.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: HS Liao Cc: Monica Wang , Jiaguang Zhang , Nicolas Boichat , cawa cheng , Bibby Hsieh , YT Shen , Damon Chu , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Philipp Zabel , Daoyuan Huang , Sascha Hauer , Glory Hung , CK HU , Rob Herring , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Josh-YC Liu , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Dennis-YC Hsieh , Sascha Hauer List-Id: devicetree@vger.kernel.org T24gRG8sIDIwMTYtMDYtMzAgYXQgMTU6MTQgKzA4MDAsIEhTIExpYW8gd3JvdGU6ClsuLi5dCj4g K1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gKy0gY29tcGF0aWJsZTogTXVzdCBiZSAibWVkaWF0ZWss bXQ4MTczLWdjZSIKPiArLSByZWc6IEFkZHJlc3MgcmFuZ2Ugb2YgdGhlIEdDRSB1bml0Cj4gKy0g aW50ZXJydXB0czogVGhlIGludGVycnVwdCBzaWduYWwgZnJvbSB0aGUgR0NFIGJsb2NrCj4gKy0g Y2xvY2s6IENsb2NrcyBhY2NvcmRpbmcgdG8gdGhlIGNvbW1vbiBjbG9jayBiaW5kaW5nCj4gKy0g Y2xvY2stbmFtZXM6IE11c3QgYmUgImdjZSIgdG8gc3RhbmQgZm9yIEdDRSBjbG9jawo+ICstICNt Ym94LWNlbGxzOiBTaG91bGQgYmUgMQpbLi4uXQo+ICsJCSNtYm94LWNlbGxzID0gPDE+OwpbLi4u XQo+ICsJCW1lZGlhdGVrLGdjZSA9IDwmZ2NlPjsKPiArCQltYm94ZXMgPSA8JmdjZSAwIDEgLyog bWFpbiBkaXNwbGF5IHdpdGggbWVyZ2luZyB3ZmUgKi8KPiArCQkJICAmZ2NlIDEgMT47IC8qIHN1 YiBkaXNwbGF5IHdpdGggbWVyZ2luZyB3ZmUgKi8KCkl0IHNlZW1zIHRoYXQgeW91IHVzZSB0d28g Y2VsbHMgaW5zdGVhZCBvZiBvbmUgYXMgeW91IGRlY2xhcmVkIGFib3ZlLgpUaGlzIHNob3VsZCBi ZSBjb25zaXN0ZW50LgoKQWxzbywgd2h5IGRvIHlvdSBuZWVkIGFuIGV4cGxpY2l0IHBoYW5kbGUg dG8gdGhlIGdjZSBpZiB5b3UgYWxyZWFkeSB1c2UKbWFpbGJveGVzPwoKQmVzdCByZWdhcmRzLApK YW4gTMO8YmJlCi0tIApQZW5ndXRyb25peCBlLksuICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfApJbmR1c3RyaWFsIExpbnV4IFNvbHV0aW9u cyAgICAgICAgICAgICAgICAgfCBodHRwOi8vd3d3LnBlbmd1dHJvbml4LmRlLyAgfApQZWluZXIg U3RyLiA2LTgsIDMxMTM3IEhpbGRlc2hlaW0sIEdlcm1hbnkgfCBQaG9uZTogKzQ5LTUxMjEtMjA2 OTE3LTAgICAgfApBbXRzZ2VyaWNodCBIaWxkZXNoZWltLCBIUkEgMjY4NiAgICAgICAgICAgfCBG YXg6ICAgKzQ5LTUxMjEtMjA2OTE3LTU1NTUgfAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdApMaW51eC1t ZWRpYXRla0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWsK From mboxrd@z Thu Jan 1 00:00:00 1970 From: jlu@pengutronix.de (Jan =?ISO-8859-1?Q?L=FCbbe?=) Date: Fri, 08 Jul 2016 12:17:46 +0200 Subject: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the MediaTek GCE unit In-Reply-To: <1467270883-1407-2-git-send-email-hs.liao@mediatek.com> References: <1467270883-1407-1-git-send-email-hs.liao@mediatek.com> <1467270883-1407-2-git-send-email-hs.liao@mediatek.com> Message-ID: <1467973066.2472.238.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote: [...] > +Required properties: > +- compatible: Must be "mediatek,mt8173-gce" > +- reg: Address range of the GCE unit > +- interrupts: The interrupt signal from the GCE block > +- clock: Clocks according to the common clock binding > +- clock-names: Must be "gce" to stand for GCE clock > +- #mbox-cells: Should be 1 [...] > + #mbox-cells = <1>; [...] > + mediatek,gce = <&gce>; > + mboxes = <&gce 0 1 /* main display with merging wfe */ > + &gce 1 1>; /* sub display with merging wfe */ It seems that you use two cells instead of one as you declared above. This should be consistent. Also, why do you need an explicit phandle to the gce if you already use mailboxes? Best regards, Jan L?bbe -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |