All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: dm-devel@redhat.com, linux-scsi@vger.kernel.org
Cc: linux-block@vger.kernel.org
Subject: [PATCH 1/2] sd: don't use the ALL_TG_PT bit for reservations
Date: Fri,  8 Jul 2016 21:23:50 +0900	[thread overview]
Message-ID: <1467980631-18945-2-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1467980631-18945-1-git-send-email-hch@lst.de>

These only work if the we use the same initiator ID for all path,
which might not be true if we use different protocols, or even just
different HBAs.

Instead dm-mpath will grow support to register all path manually
later in this series.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/scsi/sd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 60bff78..42b4d05 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -1613,8 +1613,7 @@ static int sd_pr_register(struct block_device *bdev, u64 old_key, u64 new_key,
 		return -EOPNOTSUPP;
 	return sd_pr_command(bdev, (flags & PR_FL_IGNORE_KEY) ? 0x06 : 0x00,
 			old_key, new_key, 0,
-			(1 << 0) /* APTPL */ |
-			(1 << 2) /* ALL_TG_PT */);
+			(1 << 0) /* APTPL */);
 }
 
 static int sd_pr_reserve(struct block_device *bdev, u64 key, enum pr_type type,
-- 
2.1.4


  reply	other threads:[~2016-07-08 12:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 12:23 PR API fixes for multipathing Christoph Hellwig
2016-07-08 12:23 ` Christoph Hellwig [this message]
2016-07-08 15:56   ` [PATCH 1/2] sd: don't use the ALL_TG_PT bit for reservations Mike Christie
2016-07-08 12:23 ` [PATCH 2/2] dm: call PR reserve/unreserve on each underlying device Christoph Hellwig
2016-07-08 15:57   ` Mike Christie
2016-07-15 19:03 ` PR API fixes for multipathing Martin K. Petersen
2016-07-16  1:08   ` Christoph Hellwig
2016-07-16 18:10     ` Mike Snitzer
2016-07-16 18:14       ` James Bottomley
2016-07-16 18:25         ` Mike Snitzer
2016-07-17  1:28       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467980631-18945-2-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=dm-devel@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.