From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932920AbcGHRiN (ORCPT ); Fri, 8 Jul 2016 13:38:13 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:39302 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932252AbcGHRiC (ORCPT ); Fri, 8 Jul 2016 13:38:02 -0400 Message-ID: <1467999480.2365.75.camel@pengutronix.de> Subject: Re: [PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats From: Philipp Zabel To: Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steve Longerbeam Date: Fri, 08 Jul 2016 19:38:00 +0200 In-Reply-To: <1467932621-358-12-git-send-email-steve_longerbeam@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-12-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > The CSI data format was being programmed incorrectly for the > 1x16 media bus formats. The CSI data format for 16-bit must > be bayer/generic (CSI_SENS_CONF_DATA_FMT_BAYER). I think this is not the case for BT.1120, but right now it that isn't supported yet anyway. > Suggested-by: Carsten Resch > Signed-off-by: Steve Longerbeam > --- > drivers/gpu/ipu-v3/ipu-csi.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c > index 07c7091..0eac28c 100644 > --- a/drivers/gpu/ipu-v3/ipu-csi.c > +++ b/drivers/gpu/ipu-v3/ipu-csi.c > @@ -258,12 +258,8 @@ static int mbus_code_to_bus_cfg(struct ipu_csi_bus_config *cfg, u32 mbus_code) > cfg->data_width = IPU_CSI_DATA_WIDTH_8; > break; > case MEDIA_BUS_FMT_UYVY8_1X16: > - cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_YUV422_UYVY; > - cfg->mipi_dt = MIPI_DT_YUV422; > - cfg->data_width = IPU_CSI_DATA_WIDTH_16; > - break; > case MEDIA_BUS_FMT_YUYV8_1X16: > - cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_YUV422_YUYV; > + cfg->data_fmt = CSI_SENS_CONF_DATA_FMT_BAYER; > cfg->mipi_dt = MIPI_DT_YUV422; > cfg->data_width = IPU_CSI_DATA_WIDTH_16; > break; regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH 11/16] gpu: ipu-v3: Fix CSI data format for 16-bit media bus formats Date: Fri, 08 Jul 2016 19:38:00 +0200 Message-ID: <1467999480.2365.75.camel@pengutronix.de> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-12-git-send-email-steve_longerbeam@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5115A6E2BF for ; Fri, 8 Jul 2016 17:38:02 +0000 (UTC) In-Reply-To: <1467932621-358-12-git-send-email-steve_longerbeam@mentor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steve Longerbeam Cc: Steve Longerbeam , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gRG9ubmVyc3RhZywgZGVuIDA3LjA3LjIwMTYsIDE2OjAzIC0wNzAwIHNjaHJpZWIgU3RldmUg TG9uZ2VyYmVhbToKPiBUaGUgQ1NJIGRhdGEgZm9ybWF0IHdhcyBiZWluZyBwcm9ncmFtbWVkIGlu Y29ycmVjdGx5IGZvciB0aGUKPiAxeDE2IG1lZGlhIGJ1cyBmb3JtYXRzLiBUaGUgQ1NJIGRhdGEg Zm9ybWF0IGZvciAxNi1iaXQgbXVzdAo+IGJlIGJheWVyL2dlbmVyaWMgKENTSV9TRU5TX0NPTkZf REFUQV9GTVRfQkFZRVIpLgoKSSB0aGluayB0aGlzIGlzIG5vdCB0aGUgY2FzZSBmb3IgQlQuMTEy MCwgYnV0IHJpZ2h0IG5vdyBpdCB0aGF0IGlzbid0CnN1cHBvcnRlZCB5ZXQgYW55d2F5LgoKPiBT dWdnZXN0ZWQtYnk6IENhcnN0ZW4gUmVzY2ggPENhcnN0ZW4uUmVzY2hAZGUuYm9zY2guY29tPgo+ IFNpZ25lZC1vZmYtYnk6IFN0ZXZlIExvbmdlcmJlYW0gPHN0ZXZlX2xvbmdlcmJlYW1AbWVudG9y LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1jc2kuYyB8IDYgKy0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgNSBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvaXB1LXYzL2lwdS1jc2kuYyBiL2RyaXZlcnMvZ3B1L2lwdS12 My9pcHUtY3NpLmMKPiBpbmRleCAwN2M3MDkxLi4wZWFjMjhjIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2lwdS12My9pcHUtY3NpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9pcHUtdjMvaXB1LWNz aS5jCj4gQEAgLTI1OCwxMiArMjU4LDggQEAgc3RhdGljIGludCBtYnVzX2NvZGVfdG9fYnVzX2Nm ZyhzdHJ1Y3QgaXB1X2NzaV9idXNfY29uZmlnICpjZmcsIHUzMiBtYnVzX2NvZGUpCj4gIAkJY2Zn LT5kYXRhX3dpZHRoID0gSVBVX0NTSV9EQVRBX1dJRFRIXzg7Cj4gIAkJYnJlYWs7Cj4gIAljYXNl IE1FRElBX0JVU19GTVRfVVlWWThfMVgxNjoKPiAtCQljZmctPmRhdGFfZm10ID0gQ1NJX1NFTlNf Q09ORl9EQVRBX0ZNVF9ZVVY0MjJfVVlWWTsKPiAtCQljZmctPm1pcGlfZHQgPSBNSVBJX0RUX1lV VjQyMjsKPiAtCQljZmctPmRhdGFfd2lkdGggPSBJUFVfQ1NJX0RBVEFfV0lEVEhfMTY7Cj4gLQkJ YnJlYWs7Cj4gIAljYXNlIE1FRElBX0JVU19GTVRfWVVZVjhfMVgxNjoKPiAtCQljZmctPmRhdGFf Zm10ID0gQ1NJX1NFTlNfQ09ORl9EQVRBX0ZNVF9ZVVY0MjJfWVVZVjsKPiArCQljZmctPmRhdGFf Zm10ID0gQ1NJX1NFTlNfQ09ORl9EQVRBX0ZNVF9CQVlFUjsKPiAgCQljZmctPm1pcGlfZHQgPSBN SVBJX0RUX1lVVjQyMjsKPiAgCQljZmctPmRhdGFfd2lkdGggPSBJUFVfQ1NJX0RBVEFfV0lEVEhf MTY7Cj4gIAkJYnJlYWs7CgpyZWdhcmRzClBoaWxpcHAKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=