From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932910AbcGIAXO (ORCPT ); Fri, 8 Jul 2016 20:23:14 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35351 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756297AbcGIAXH convert rfc822-to-8bit (ORCPT ); Fri, 8 Jul 2016 20:23:07 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Jorge Ramirez , linux@armlinux.org.uk, xuwei5@hisilicon.com From: Michael Turquette In-Reply-To: <57801DA6.5010506@linaro.org> Cc: guodong.xu@linaro.org, sboyd@codeaurora.org, xinliang.liu@linaro.org, john.stultz@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1467965467-28180-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <146799807004.73491.2602277598493203375@resonance> <57801DA6.5010506@linaro.org> Message-ID: <146802378337.73491.10770797315435166004@resonance> User-Agent: alot/0.3.7 Subject: Re: [PATCH 1/2] tty: amba-pl011: add support for clock frequency setting via dt Date: Fri, 08 Jul 2016 17:23:03 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Jorge Ramirez (2016-07-08 14:39:50) > On 07/08/2016 07:14 PM, Michael Turquette wrote: > > Quoting Jorge Ramirez-Ortiz (2016-07-08 01:11:06) > >> Allow to specify the clock frequency for any given port via the > >> assigned-clock-rates device tree property. > >> > >> Signed-off-by: Jorge Ramirez-Ortiz > >> Tested-by: Jorge Ramirez-Ortiz > >> --- > >> drivers/tty/serial/amba-pl011.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > >> index 1b7331e..51867ab 100644 > >> --- a/drivers/tty/serial/amba-pl011.c > >> +++ b/drivers/tty/serial/amba-pl011.c > >> @@ -55,6 +55,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -2472,6 +2473,10 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id) > >> if (IS_ERR(uap->clk)) > >> return PTR_ERR(uap->clk); > >> > >> + ret = of_clk_set_defaults(dev->dev.of_node, false); > > Change looks good to me, but with one question: should this change be > > put into more generic code instead of in this specific driver? For > > instance, we call of_clk_set_defaults from the following files: > > > > drivers/base/platform.c > > drivers/i2c/i2c-core.c > > drivers/spi/spi.c > > > > And Stephen posted a patch to do this for devices on the AMBA bus: > > > > https://patchwork.kernel.org/patch/6501691/ > > > > Does Stephen's patch mean that you do not need patch #1? > > I did a quick test (replaced my changes with the patch above) and the > console broke and the BT stack couldn't communicate to the device over > the uart...I guess something else needs doing on top of Stephen's change. > Let's give Stephen a chance to respond. If he doesn't soon then I'm OK to merge your two patches. Regards, Mike From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@baylibre.com (Michael Turquette) Date: Fri, 08 Jul 2016 17:23:03 -0700 Subject: [PATCH 1/2] tty: amba-pl011: add support for clock frequency setting via dt In-Reply-To: <57801DA6.5010506@linaro.org> References: <1467965467-28180-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <146799807004.73491.2602277598493203375@resonance> <57801DA6.5010506@linaro.org> Message-ID: <146802378337.73491.10770797315435166004@resonance> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Jorge Ramirez (2016-07-08 14:39:50) > On 07/08/2016 07:14 PM, Michael Turquette wrote: > > Quoting Jorge Ramirez-Ortiz (2016-07-08 01:11:06) > >> Allow to specify the clock frequency for any given port via the > >> assigned-clock-rates device tree property. > >> > >> Signed-off-by: Jorge Ramirez-Ortiz > >> Tested-by: Jorge Ramirez-Ortiz > >> --- > >> drivers/tty/serial/amba-pl011.c | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c > >> index 1b7331e..51867ab 100644 > >> --- a/drivers/tty/serial/amba-pl011.c > >> +++ b/drivers/tty/serial/amba-pl011.c > >> @@ -55,6 +55,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -2472,6 +2473,10 @@ static int pl011_probe(struct amba_device *dev, const struct amba_id *id) > >> if (IS_ERR(uap->clk)) > >> return PTR_ERR(uap->clk); > >> > >> + ret = of_clk_set_defaults(dev->dev.of_node, false); > > Change looks good to me, but with one question: should this change be > > put into more generic code instead of in this specific driver? For > > instance, we call of_clk_set_defaults from the following files: > > > > drivers/base/platform.c > > drivers/i2c/i2c-core.c > > drivers/spi/spi.c > > > > And Stephen posted a patch to do this for devices on the AMBA bus: > > > > https://patchwork.kernel.org/patch/6501691/ > > > > Does Stephen's patch mean that you do not need patch #1? > > I did a quick test (replaced my changes with the patch above) and the > console broke and the BT stack couldn't communicate to the device over > the uart...I guess something else needs doing on top of Stephen's change. > Let's give Stephen a chance to respond. If he doesn't soon then I'm OK to merge your two patches. Regards, Mike