From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932479AbcGLJiq (ORCPT ); Tue, 12 Jul 2016 05:38:46 -0400 Received: from mga04.intel.com ([192.55.52.120]:61975 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932392AbcGLJio (ORCPT ); Tue, 12 Jul 2016 05:38:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,351,1464678000"; d="scan'208";a="1015222721" From: Liu Shuo To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Zhang Yanmin , He Bo , Liu Shuo , Paolo Bonzini , =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= Subject: [PATCH] KVM: release anon file in failure path of vm creation Date: Tue, 12 Jul 2016 17:38:42 +0800 Message-Id: <1468316323-23835-1-git-send-email-shuo.a.liu@intel.com> X-Mailer: git-send-email 1.9.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The failure of create debugfs of VM will return directly without release the anon file. It will leak memory and file descriptors, even through be not serious. Signed-off-by: Liu Shuo --- virt/kvm/kvm_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 48bd520..8322154 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -49,6 +49,7 @@ #include #include #include +#include #include #include @@ -3067,6 +3068,7 @@ static int kvm_dev_ioctl_create_vm(unsigned long type) if (kvm_create_vm_debugfs(kvm, r) < 0) { kvm_put_kvm(kvm); + sys_close(r); return -ENOMEM; } -- 1.9.4