* [PATCH 1/1] media: platform: ti-vpe: call of_node_put on non-null pointer
@ 2016-07-15 9:33 Peter Chen
2016-07-28 20:46 ` Benoit Parrot
0 siblings, 1 reply; 2+ messages in thread
From: Peter Chen @ 2016-07-15 9:33 UTC (permalink / raw)
To: bparrot, mchehab; +Cc: Peter Chen, linux-media
It should call of_node_put on non-null poiner.
Cc: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/media/platform/ti-vpe/cal.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
index 82001e6..00c3e97 100644
--- a/drivers/media/platform/ti-vpe/cal.c
+++ b/drivers/media/platform/ti-vpe/cal.c
@@ -1761,13 +1761,13 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst)
}
cleanup_exit:
- if (!remote_ep)
+ if (remote_ep)
of_node_put(remote_ep);
- if (!sensor_node)
+ if (sensor_node)
of_node_put(sensor_node);
- if (!ep_node)
+ if (ep_node)
of_node_put(ep_node);
- if (!port)
+ if (port)
of_node_put(port);
return ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] media: platform: ti-vpe: call of_node_put on non-null pointer
2016-07-15 9:33 [PATCH 1/1] media: platform: ti-vpe: call of_node_put on non-null pointer Peter Chen
@ 2016-07-28 20:46 ` Benoit Parrot
0 siblings, 0 replies; 2+ messages in thread
From: Benoit Parrot @ 2016-07-28 20:46 UTC (permalink / raw)
To: Peter Chen; +Cc: mchehab, linux-media
Peter Chen <peter.chen@nxp.com> wrote on Fri [2016-Jul-15 17:33:06 +0800]:
> It should call of_node_put on non-null poiner.
Good catch, thanks.
Acked-by: Benoit Parrot <bparrot@ti.com>
>
> Cc: linux-media@vger.kernel.org
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/media/platform/ti-vpe/cal.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti-vpe/cal.c
> index 82001e6..00c3e97 100644
> --- a/drivers/media/platform/ti-vpe/cal.c
> +++ b/drivers/media/platform/ti-vpe/cal.c
> @@ -1761,13 +1761,13 @@ static int of_cal_create_instance(struct cal_ctx *ctx, int inst)
> }
>
> cleanup_exit:
> - if (!remote_ep)
> + if (remote_ep)
> of_node_put(remote_ep);
> - if (!sensor_node)
> + if (sensor_node)
> of_node_put(sensor_node);
> - if (!ep_node)
> + if (ep_node)
> of_node_put(ep_node);
> - if (!port)
> + if (port)
> of_node_put(port);
>
> return ret;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-28 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15 9:33 [PATCH 1/1] media: platform: ti-vpe: call of_node_put on non-null pointer Peter Chen
2016-07-28 20:46 ` Benoit Parrot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.