From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751831AbcGRShk (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jul 2016 14:37:40 -0400
Received: from foss.arm.com ([217.140.101.70]:59925 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751656AbcGRShi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jul 2016 14:37:38 -0400
Message-ID: <1468867038.2996.21.camel@arm.com>
Subject: Re: [patch V2 23/67] bus/arm-ccn: Convert to hotplug statemachine
From: Pawel Moll <pawel.moll@arm.com>
To: Anna-Maria Gleixner <anna-maria@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, rt@linutronix.de,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Arnd Bergmann <arnd@arndb.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>
Date: Mon, 18 Jul 2016 19:37:18 +0100
In-Reply-To: <20160713153334.768498577@linutronix.de>
References: <20160713153219.128052238@linutronix.de>
	 <20160713153334.768498577@linutronix.de>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5-1ubuntu3.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Dnia 2016-07-13, Wed o godzinie 17:16 +0000, Anna-Maria Gleixner pisze:
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> 
> Install the callbacks via the state machine and let the core invoke
> the callbacks on the already online CPUs.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>

> @@ -1316,7 +1309,6 @@ static void arm_ccn_pmu_cleanup(struct a
>  	ida_simple_remove(&arm_ccn_pmu_ida, ccn->dt.id);
>  }
>  
> -
>  static int arm_ccn_for_each_valid_region(struct arm_ccn *ccn,
>  		int (*callback)(struct arm_ccn *ccn, int region,
>  		void __iomem *base, u32 type, u32 id))

This empty line doesn't impact hotplug, does it? ;-)

With this chunk dropped

Acked-by: Pawel Moll <pawel.moll@arm.com>

Cheers!

Pawel