All of lore.kernel.org
 help / color / mirror / Atom feed
From: Song Shan Gong <gongss@linux.vnet.ibm.com>
To: acme@kernel.org, jolsa@kernel.org
Cc: dsahern@gmail.com, linux-kernel@vger.kernel.org,
	borntraeger@de.ibm.com,
	Song Shan Gong <gongss@linux.vnet.ibm.com>
Subject: [PATCH] s390/perf: fix 'start' address of module's map
Date: Thu, 21 Jul 2016 11:10:51 +0800	[thread overview]
Message-ID: <1469070651-6447-2-git-send-email-gongss@linux.vnet.ibm.com> (raw)
In-Reply-To: <1469070651-6447-1-git-send-email-gongss@linux.vnet.ibm.com>

At preset, when creating module's map, perf gets 'start' address by parsing
'/proc/modules', but it's module base address, isn't the start address of
'.text' section. In most archs, it's OK. But for s390, it places 'GOT' and
'PLT' relocations before '.text' section. So there exists an offset between
module base address and '.text' section, which will incur wrong symbol
resolution for modules.

Fix this bug by getting 'start' address of module's map from parsing
'/sys/module/[module name]/sections/.text', not from '/proc/modules'.

Signed-off-by: Song Shan Gong <gongss@linux.vnet.ibm.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/arch/s390/util/Build     |  2 ++
 tools/perf/arch/s390/util/machine.c | 19 +++++++++++++++++++
 tools/perf/util/machine.c           |  8 ++++++++
 tools/perf/util/machine.h           |  1 +
 4 files changed, 30 insertions(+)
 create mode 100644 tools/perf/arch/s390/util/machine.c

diff --git a/tools/perf/arch/s390/util/Build b/tools/perf/arch/s390/util/Build
index 8a61372..5bd7b92 100644
--- a/tools/perf/arch/s390/util/Build
+++ b/tools/perf/arch/s390/util/Build
@@ -2,3 +2,5 @@ libperf-y += header.o
 libperf-y += kvm-stat.o
 
 libperf-$(CONFIG_DWARF) += dwarf-regs.o
+
+libperf-y += machine.o
diff --git a/tools/perf/arch/s390/util/machine.c b/tools/perf/arch/s390/util/machine.c
new file mode 100644
index 0000000..b9a95a1
--- /dev/null
+++ b/tools/perf/arch/s390/util/machine.c
@@ -0,0 +1,19 @@
+#include <unistd.h>
+#include <stdio.h>
+#include <string.h>
+#include "util.h"
+#include "machine.h"
+#include "api/fs/fs.h"
+
+int arch__fix_module_text_start(u64 *start, const char *name)
+{
+	char path[PATH_MAX];
+
+	snprintf(path, PATH_MAX, "module/%.*s/sections/.text",
+				(int)strlen(name) - 2, name + 1);
+
+	if (sysfs__read_ull(path, (unsigned long long *)start) < 0)
+		return -1;
+
+	return 0;
+}
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index b177218..97cc9f0 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1091,12 +1091,20 @@ static int machine__set_modules_path(struct machine *machine)
 
 	return map_groups__set_modules_path_dir(&machine->kmaps, modules_path, 0);
 }
+int __weak arch__fix_module_text_start(u64 *start __maybe_unused,
+				const char *name __maybe_unused)
+{
+	return 0;
+}
 
 static int machine__create_module(void *arg, const char *name, u64 start)
 {
 	struct machine *machine = arg;
 	struct map *map;
 
+	if (arch__fix_module_text_start(&start, name) < 0)
+		return -1;
+
 	map = machine__findnew_module_map(machine, start, name);
 	if (map == NULL)
 		return -1;
diff --git a/tools/perf/util/machine.h b/tools/perf/util/machine.h
index 41ac9cf..20739f7 100644
--- a/tools/perf/util/machine.h
+++ b/tools/perf/util/machine.h
@@ -216,6 +216,7 @@ struct symbol *machine__find_kernel_function_by_name(struct machine *machine,
 
 struct map *machine__findnew_module_map(struct machine *machine, u64 start,
 					const char *filename);
+int arch__fix_module_text_start(u64 *start, const char *name);
 
 int __machine__load_kallsyms(struct machine *machine, const char *filename,
 			     enum map_type type, bool no_kcore, symbol_filter_t filter);
-- 
2.3.0

  reply	other threads:[~2016-07-21  3:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21  3:10 [RFC PATCH V4]s390/perf:fix 'start' address of module's map Song Shan Gong
2016-07-21  3:10 ` Song Shan Gong [this message]
2016-07-22  2:47   ` [PATCH] s390/perf: fix " Songshan Gong
2016-07-26  6:54     ` Jiri Olsa
2016-07-26 19:50   ` Arnaldo Carvalho de Melo
2016-07-26 20:14     ` Christian Borntraeger
2016-07-26 20:29       ` Arnaldo Carvalho de Melo
2016-07-27  9:24         ` Michael Ellerman
2016-07-27 13:05           ` Arnaldo Carvalho de Melo
2016-07-27 10:10         ` Songshan Gong
2016-07-27 10:49         ` Songshan Gong
2016-07-27 13:08           ` Arnaldo Carvalho de Melo
2016-07-28  2:01             ` Songshan Gong
2016-07-27 10:05     ` Songshan Gong
2016-07-27 10:41   ` [tip:perf/urgent] perf s390: Fix " tip-bot for Song Shan Gong
  -- strict thread matches above, loose matches on Subject: below --
2016-07-19 11:31 [RFC PATCH V3]s390/perf:fix " Song Shan Gong
2016-07-19 11:31 ` [PATCH] s390/perf: fix " Song Shan Gong
2016-07-20 11:51   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469070651-6447-2-git-send-email-gongss@linux.vnet.ibm.com \
    --to=gongss@linux.vnet.ibm.com \
    --cc=acme@kernel.org \
    --cc=borntraeger@de.ibm.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.