All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] musl: don't compile in mips16e mode
Date: Thu, 21 Jul 2016 11:16:45 +0100	[thread overview]
Message-ID: <1469096205.6229.18.camel@andred.net> (raw)
In-Reply-To: <76D6B136-02D8-404A-8AB1-3F236ABAB58D@gmail.com>

On Mi, 2016-07-20 at 20:22 -0700, Khem Raj wrote:
> > 
> > On Jul 20, 2016, at 8:19 PM, git@andred.net wrote:
> > 
> > From: André Draszik <adraszik@tycoint.com>
> > 
> > musl contains hand-written assembly which is not compatible with
> > the MIPS16e mode.
> > 
> > Signed-off-by: André Draszik <adraszik@tycoint.com>
> > ---
> > meta/recipes-core/musl/musl.inc | 3 +++
> > 1 file changed, 3 insertions(+)
> > 
> > diff --git a/meta/recipes-core/musl/musl.inc b/meta/recipes-
> > core/musl/musl.inc
> > index 5e6cd01..276b00f 100644
> > --- a/meta/recipes-core/musl/musl.inc
> > +++ b/meta/recipes-core/musl/musl.inc
> > @@ -24,3 +24,6 @@ FILES_SOLIBSDEV = ""
> > FILES_${PN} += "${libdir}/lib*${SOLIBSDEV}"
> > INSANE_SKIP_${PN} = "dev-so"
> > 
> > +# Doesn't compile in MIPS16e mode due to use of hand-written
> > +# assembly
> > +MIPS_INSTRUCTION_SET = “mips"
> 
> Looks ok. However, does it make sense to have it compiled with mips ISA
> for a mips16e
> part ?

MIPS16e is just an optional extension (ASE) on some mips32 and mips64 parts.
There can not be mips16e only parts.

> will it work in all cases or only certain SOCs

MIPS_INSTRUCTION_SET in OE is implemented similar to ARM_INSTRUCTION_SET. If
set to 'mips' (as above), it will simply revert to the standard instruction
set for the part we're building for, mips32/mips64/etc.

Given mips16e is an optional ASE, this currently is hooked into 24k family
type cores in OE, only.

So yes, this should not break anything.

BTW, Qemu supports mips16e (if the right target is selected).


Cheers,
Andre'



  reply	other threads:[~2016-07-21 10:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21  3:19 [PATCH] musl: don't compile in mips16e mode git
2016-07-21  3:22 ` Khem Raj
2016-07-21 10:16   ` André Draszik [this message]
2016-07-21 13:46     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469096205.6229.18.camel@andred.net \
    --to=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.