From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbcGUNPV (ORCPT ); Thu, 21 Jul 2016 09:15:21 -0400 Received: from lucky1.263xmail.com ([211.157.147.132]:60230 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752506AbcGUNPK (ORCPT ); Thu, 21 Jul 2016 09:15:10 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: yzq@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <24b99a34d510d8e5b073173c27fbf94a> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Yakir Yang To: Mark Yao , Inki Dae , Thierry Reding , Heiko Stuebner Cc: Jingoo Han , Javier Martinez Canillas , =?UTF-8?q?St=C3=A9phane=20Marchesin?= , Sean Paul , Tomasz Figa , dianders@chromium.org, David Airlie , daniel.vetter@ffwll.ch, Krzysztof Kozlowski , emil.l.velikov@gmail.com, Yakir Yang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH v1 2/2] drm/bridge: analogix_dp: turn off the panel when eDP need to disable Date: Thu, 21 Jul 2016 21:14:46 +0800 Message-Id: <1469106886-4979-1-git-send-email-ykk@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469106874-4912-1-git-send-email-ykk@rock-chips.com> References: <1469106874-4912-1-git-send-email-ykk@rock-chips.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some panels (like Sharp LQ123P1JX31) need to be turn off when eDP controller stop to send valid video signal, otherwhise panel would go burn in, and keep flicker and flicker. So it's better to turn off the panel when eDP need to disable, and we need to turn on the panel in connector->detect() callback, so that driver would detect panel status rightly. Signed-off-by: Yakir Yang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 32715da..ea059b3 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -961,6 +961,14 @@ analogix_dp_detect(struct drm_connector *connector, bool force) { struct analogix_dp_device *dp = to_dp(connector); + /* + * Panle would prepare for several times here, but don't worry it + * would only enable the hardware at the first prepare time. + */ + if (dp->plat_data->panel) + if (drm_panel_prepare(dp->plat_data->panel)) + DRM_ERROR("failed to setup the panel\n"); + if (analogix_dp_detect_hpd(dp)) return connector_status_disconnected; @@ -1063,7 +1071,8 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge) return; if (dp->plat_data->panel) { - if (drm_panel_disable(dp->plat_data->panel)) { + if (drm_panel_disable(dp->plat_data->panel) || + drm_panel_unprepare(dp->plat_data->panel)) { DRM_ERROR("failed to disable the panel\n"); return; } @@ -1333,13 +1342,6 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, phy_power_on(dp->phy); - if (dp->plat_data->panel) { - if (drm_panel_prepare(dp->plat_data->panel)) { - DRM_ERROR("failed to setup the panel\n"); - return -EBUSY; - } - } - analogix_dp_init_dp(dp); ret = devm_request_threaded_irq(&pdev->dev, dp->irq, -- 1.9.1