From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbcGVIOH (ORCPT ); Fri, 22 Jul 2016 04:14:07 -0400 Received: from cn.fujitsu.com ([59.151.112.132]:4990 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752550AbcGVIN4 (ORCPT ); Fri, 22 Jul 2016 04:13:56 -0400 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="8978657" From: Wei Jiangang To: CC: , , , , , , , , , Wei Jiangang , Cao jin Subject: [PATCH 1/3] x86/apic: Remove "focus disabled" for 64bit case Date: Fri, 22 Jul 2016 16:10:24 +0800 Message-ID: <1469175026-29447-1-git-send-email-weijg.fnst@cn.fujitsu.com> X-Mailer: git-send-email 1.9.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.226.50] X-yoursite-MailScanner-ID: 9EACE4218F42.A230A X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: weijg.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Disable processor focus for 64bit causes a crash, Call Trace as following: [] dump_stack+0x63/0x84 [] __warn+0xd1/0xf0 [] warn_slowpath_fmt+0x5f/0x80 [] ex_handler_wrmsr_unsafe+0x62/0x70 [] fixup_exception+0x39/0x50 [] do_general_protection+0x80/0x160 [] general_protection+0x28/0x30 [] ? native_write_msr+0x4/0x30 [] ? native_apic_msr_write+0x32/0x40 [] init_bsp_APIC+0x5f/0x118 [] init_ISA_irqs+0x19/0x4c [] native_init_IRQ+0xd/0x377 [] init_IRQ+0x42/0x49 [] start_kernel+0x2ce/0x4c8 [] ? set_init_arg+0x55/0x55 [] ? early_idt_handler_array+0x120/0x120 [] x86_64_start_reservations+0x2f/0x31 [] x86_64_start_kernel+0x14c/0x16f Keep a consistent implementation with the setup_local_APIC(), always use processor focus for 64bit. more details refer to commit 89c38c2867eb ("x86: apic - unify setup_local_APIC") Signed-off-by: Cao jin Signed-off-by: Wei Jiangang --- arch/x86/kernel/apic/apic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 60078a67d7e3..0273b652c689 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1154,9 +1154,7 @@ void __init init_bsp_APIC(void) if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) && (boot_cpu_data.x86 == 15)) value &= ~APIC_SPIV_FOCUS_DISABLED; - else #endif - value |= APIC_SPIV_FOCUS_DISABLED; value |= SPURIOUS_APIC_VECTOR; apic_write(APIC_SPIV, value); -- 1.9.3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [59.151.112.132] (helo=heian.cn.fujitsu.com) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bQVbK-0006yV-Fh for kexec@lists.infradead.org; Fri, 22 Jul 2016 08:14:31 +0000 From: Wei Jiangang Subject: [PATCH 1/3] x86/apic: Remove "focus disabled" for 64bit case Date: Fri, 22 Jul 2016 16:10:24 +0800 Message-ID: <1469175026-29447-1-git-send-email-weijg.fnst@cn.fujitsu.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: linux-kernel@vger.kernel.org Cc: bhe@redhat.com, xpang@redhat.com, x86@kernel.org, kexec@lists.infradead.org, Cao jin , mingo@redhat.com, kernel@kyup.com, ebiederm@xmission.com, hpa@zytor.com, tglx@linutronix.de, Wei Jiangang Disable processor focus for 64bit causes a crash, Call Trace as following: [] dump_stack+0x63/0x84 [] __warn+0xd1/0xf0 [] warn_slowpath_fmt+0x5f/0x80 [] ex_handler_wrmsr_unsafe+0x62/0x70 [] fixup_exception+0x39/0x50 [] do_general_protection+0x80/0x160 [] general_protection+0x28/0x30 [] ? native_write_msr+0x4/0x30 [] ? native_apic_msr_write+0x32/0x40 [] init_bsp_APIC+0x5f/0x118 [] init_ISA_irqs+0x19/0x4c [] native_init_IRQ+0xd/0x377 [] init_IRQ+0x42/0x49 [] start_kernel+0x2ce/0x4c8 [] ? set_init_arg+0x55/0x55 [] ? early_idt_handler_array+0x120/0x120 [] x86_64_start_reservations+0x2f/0x31 [] x86_64_start_kernel+0x14c/0x16f Keep a consistent implementation with the setup_local_APIC(), always use processor focus for 64bit. more details refer to commit 89c38c2867eb ("x86: apic - unify setup_local_APIC") Signed-off-by: Cao jin Signed-off-by: Wei Jiangang --- arch/x86/kernel/apic/apic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index 60078a67d7e3..0273b652c689 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1154,9 +1154,7 @@ void __init init_bsp_APIC(void) if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) && (boot_cpu_data.x86 == 15)) value &= ~APIC_SPIV_FOCUS_DISABLED; - else #endif - value |= APIC_SPIV_FOCUS_DISABLED; value |= SPURIOUS_APIC_VECTOR; apic_write(APIC_SPIV, value); -- 1.9.3 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec