All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Rename engine->semaphore.sync_to, engine->sempahore.signal locals
Date: Fri, 22 Jul 2016 12:38:49 +0300	[thread overview]
Message-ID: <1469180329.5916.34.camel@linux.intel.com> (raw)
In-Reply-To: <20160722093124.GL10317@nuc-i3427.alporthouse.com>

On pe, 2016-07-22 at 10:31 +0100, Chris Wilson wrote:
> On Fri, Jul 22, 2016 at 12:28:11PM +0300, Joonas Lahtinen wrote:
> > 
> > On pe, 2016-07-22 at 10:14 +0100, Chris Wilson wrote:
> > > 
> > >  	/* When the !RCS engines idle waiting upon a semaphore, they lose their
> > >  	 * pagetables and we must reload them before executing the batch.
> > >  	 * We do this on the i915_switch_context() following the wait and
> > >  	 * before the dispatch.
> > >  	 */
> > > -	ppgtt = wait->ctx->ppgtt;
> > > -	if (ppgtt && wait->engine->id != RCS)
> > > -		ppgtt->pd_dirty_rings |= intel_engine_flag(wait->engine);
> > > +	ppgtt = req->ctx->ppgtt;
> > This assignment could still be lifted up.
> I'm not a huge believe in gcc's live range analysis :)

It's Open Source :P We can optimize the culprit once there is need.

> -Chris
> > 
> > 
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-07-22  9:38 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 13:11 Unify request construction Chris Wilson
2016-07-20 13:11 ` [PATCH 01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit Chris Wilson
2016-07-21 11:26   ` Joonas Lahtinen
2016-07-21 12:09     ` Chris Wilson
2016-07-20 13:11 ` [PATCH 02/18] drm/i915: Rename request->ringbuf to request->ring Chris Wilson
2016-07-20 14:12   ` Dave Gordon
2016-07-20 14:51     ` Dave Gordon
2016-07-20 15:00     ` [PATCH] drm/i915: Convert stray struct intel_engine_cs *ring Chris Wilson
2016-07-27 13:15       ` Dave Gordon
2016-07-21 11:28   ` [PATCH 02/18] drm/i915: Rename request->ringbuf to request->ring Joonas Lahtinen
2016-07-20 13:11 ` [PATCH 03/18] drm/i915: Rename backpointer from intel_ringbuffer to intel_engine_cs Chris Wilson
2016-07-20 14:23   ` Dave Gordon
2016-07-21 11:32   ` Joonas Lahtinen
2016-07-21 11:42     ` Chris Wilson
2016-07-20 13:11 ` [PATCH 04/18] drm/i915: Rename intel_context[engine].ringbuf Chris Wilson
2016-07-21 11:43   ` Joonas Lahtinen
2016-07-20 13:11 ` [PATCH 05/18] drm/i915: Rename struct intel_ringbuffer to struct intel_ring Chris Wilson
2016-07-21 11:59   ` Joonas Lahtinen
2016-07-21 16:02     ` Chris Wilson
2016-07-20 13:11 ` [PATCH 06/18] drm/i915: Rename residual ringbuf parameters Chris Wilson
2016-07-21 12:01   ` Joonas Lahtinen
2016-07-21 12:20     ` Chris Wilson
2016-07-20 13:11 ` [PATCH 07/18] drm/i915: Rename intel_pin_and_map_ring() Chris Wilson
2016-07-21 12:02   ` Joonas Lahtinen
2016-07-20 13:12 ` [PATCH 08/18] drm/i915: Remove obsolete engine->gpu_caches_dirty Chris Wilson
2016-07-20 13:12 ` [PATCH 09/18] drm/i915: Simplify request_alloc by returning the allocated request Chris Wilson
2016-07-21 13:07   ` Joonas Lahtinen
2016-07-21 13:18     ` Chris Wilson
2016-07-20 13:12 ` [PATCH 10/18] drm/i915: Unify legacy/execlists emission of MI_BATCHBUFFER_START Chris Wilson
2016-07-21 13:39   ` Joonas Lahtinen
2016-07-21 14:14     ` Chris Wilson
2016-07-27 15:04       ` Dave Gordon
2016-07-27 15:19         ` Chris Wilson
2016-07-20 13:12 ` [PATCH 11/18] drm/i915: Convert engine->write_tail to operate on a request Chris Wilson
2016-07-21 13:52   ` Joonas Lahtinen
2016-07-20 13:12 ` [PATCH 12/18] drm/i915: Unify request submission Chris Wilson
2016-07-22  8:03   ` Joonas Lahtinen
2016-07-22  8:24     ` Chris Wilson
2016-07-27 17:51     ` Dave Gordon
2016-07-27 18:09       ` Chris Wilson
2016-07-27 18:17         ` Chris Wilson
2016-07-28 10:25         ` Dave Gordon
2016-07-28 11:49           ` Daniel Vetter
2016-07-20 13:12 ` [PATCH 13/18] drm/i915: Stop passing caller's num_dwords to engine->semaphore.signal() Chris Wilson
2016-07-22  8:15   ` Joonas Lahtinen
2016-07-22  8:30     ` Chris Wilson
2016-07-22  9:06       ` Joonas Lahtinen
2016-07-20 13:12 ` [PATCH 14/18] drm/i915: Reuse legacy breadcrumbs + tail emission Chris Wilson
2016-07-22  8:34   ` Joonas Lahtinen
2016-07-20 13:12 ` [PATCH 15/18] drm/i915/ringbuffer: Specialise SNB+ request emission for semaphores Chris Wilson
2016-07-21 13:55   ` Joonas Lahtinen
2016-07-21 14:10     ` Chris Wilson
2016-07-22  9:42       ` Joonas Lahtinen
2016-07-20 13:12 ` [PATCH 16/18] drm/i915: Remove duplicate golden render state init from execlists Chris Wilson
2016-07-21 14:18   ` Joonas Lahtinen
2016-07-21 16:27     ` Chris Wilson
2016-07-21 16:37       ` Chris Wilson
2016-07-22  9:53         ` Joonas Lahtinen
2016-07-22 10:16           ` [PATCH] drm/i915: Refactor golden render state emission to unconfuse gcc Chris Wilson
2016-07-22 10:33             ` Joonas Lahtinen
2016-07-20 13:12 ` [PATCH 17/18] drm/i915: Unify legacy/execlists submit_execbuf callbacks Chris Wilson
2016-07-22  8:45   ` Joonas Lahtinen
2016-07-20 13:12 ` [PATCH 18/18] drm/i915: Simplify calling engine->sync_to Chris Wilson
2016-07-22  8:59   ` Joonas Lahtinen
2016-07-22  9:14     ` [PATCH] drm/i915: Rename engine->semaphore.sync_to, engine->sempahore.signal locals Chris Wilson
2016-07-22  9:28       ` Joonas Lahtinen
2016-07-22  9:31         ` Chris Wilson
2016-07-22  9:38           ` Joonas Lahtinen [this message]
2016-07-20 13:54 ` ✓ Ro.CI.BAT: success for series starting with [01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit Patchwork
2016-07-20 15:10 ` ✗ Ro.CI.BAT: failure for series starting with [01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit (rev2) Patchwork
2016-07-22  9:58 ` ✗ Ro.CI.BAT: failure for series starting with [01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit (rev4) Patchwork
2016-07-22 10:22 ` ✗ Ro.CI.BAT: failure for series starting with [01/18] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit (rev5) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469180329.5916.34.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.