From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059AbcGYS1e (ORCPT ); Mon, 25 Jul 2016 14:27:34 -0400 Received: from mga02.intel.com ([134.134.136.20]:24583 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752484AbcGYS1c (ORCPT ); Mon, 25 Jul 2016 14:27:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,420,1464678000"; d="scan'208";a="853154991" From: william.c.roberts@intel.com To: linux-mm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linux@arm.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, tytso@mit.edu, arnd@arndb.de, gregkh@linuxfoundation.org, catalin.marinas@arm.com, will.deacon@arm.com, ralf@linux-mips.org, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, viro@zeniv.linux.org.uk, nnk@google.com, jeffv@google.com, salyzyn@android.com, dcashman@android.com, William Roberts Subject: [PATCH] randomize_range: use random long instead of int Date: Mon, 25 Jul 2016 11:25:41 -0700 Message-Id: <1469471141-25669-1-git-send-email-william.c.roberts@intel.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: William Roberts Use a long when generating the random range rather than an int. This will produce better random distributions as well as matching all the types at hand. Signed-off-by: William Roberts --- drivers/char/random.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/random.c b/drivers/char/random.c index 0158d3b..bbf11b5 100644 --- a/drivers/char/random.c +++ b/drivers/char/random.c @@ -1837,7 +1837,8 @@ randomize_range(unsigned long start, unsigned long end, unsigned long len) if (end <= start + len) return 0; - return PAGE_ALIGN(get_random_int() % range + start); + + return PAGE_ALIGN(get_random_long() % range + start); } /* Interface for in-kernel drivers of true hardware RNGs. -- 1.9.1