From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754543AbcG0Jss (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jul 2016 05:48:48 -0400
Received: from mailgw01.mediatek.com ([210.61.82.183]:12480 "EHLO
	mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752765AbcG0Jsp (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jul 2016 05:48:45 -0400
Message-ID: <1469529756.4678.30.camel@mtksdaap41>
Subject: Re: [PATCH v4 6/8] drm/mediatek: add dsi transfer function
From: YT Shen <yt.shen@mediatek.com>
To: CK Hu <ck.hu@mediatek.com>
CC: <dri-devel@lists.freedesktop.org>, Philipp Zabel <p.zabel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "Russell King" <linux@arm.linux.org.uk>,
        David Airlie <airlied@linux.ie>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        Mao Huang <littlecvr@chromium.org>,
        "Bibby Hsieh" <bibby.hsieh@mediatek.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>, <srv_heupstream@mediatek.com>,
        "Sascha Hauer" <kernel@pengutronix.de>, <yingjoe.chen@mediatek.com>,
        <emil.l.velikov@gmail.com>, <thierry.reding@gmail.com>,
        shaoming chen <shaoming.chen@mediatek.com>
In-Reply-To: <1468994346.11841.31.camel@mtksdaap41>
References: <1468577274-6178-1-git-send-email-yt.shen@mediatek.com>
	 <1468577274-6178-7-git-send-email-yt.shen@mediatek.com>
	 <1468994346.11841.31.camel@mtksdaap41>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 26 Jul 2016 18:42:36 +0800
MIME-Version: 1.0
X-Mailer: Evolution 3.2.3-0ubuntu6 
Content-Transfer-Encoding: 7bit
X-MTK: N
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi CK,

Thanks for the review.

On Wed, 2016-07-20 at 13:59 +0800, CK Hu wrote:
> Hi, YT:
> 
> Some comments inline.
> 
> On Fri, 2016-07-15 at 18:07 +0800, YT Shen wrote:
> > From: shaoming chen <shaoming.chen@mediatek.com>
> > 
> > add dsi read/write commands for transfer function
> > 
> > Signed-off-by: shaoming chen <shaoming.chen@mediatek.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dsi.c |  322 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 322 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > index de5ad7f..1f99894 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > @@ -24,6 +24,7 @@
> >  #include <linux/of_graph.h>
> >  #include <linux/phy/phy.h>
> >  #include <linux/platform_device.h>
> > +#include <video/mipi_display.h>
> >  #include <video/videomode.h>
> >  
> >  #include "mtk_drm_ddp_comp.h"
> > @@ -80,8 +81,16 @@
> >  #define DSI_HBP_WC		0x54
> >  #define DSI_HFP_WC		0x58
> >  
> > +#define DSI_CMDQ_SIZE		0x60
> > +#define CMDQ_SIZE		0x3f
> > +
> >  #define DSI_HSTX_CKL_WC		0x64
> >  
> > +#define DSI_RX_DATA0		0x74
> > +#define DSI_RX_DATA1		0x78
> > +#define DSI_RX_DATA2		0x7c
> > +#define DSI_RX_DATA3		0x80
> > +
> >  #define DSI_RACK		0x84
> >  #define RACK			BIT(0)
> >  
> > @@ -117,8 +126,25 @@
> >  #define CLK_HS_POST			(0xff << 8)
> >  #define CLK_HS_EXIT			(0xff << 16)
> >  
> > +#define DSI_CMDQ0		0x180
> > +
> >  #define NS_TO_CYCLE(n, c)    ((n) / (c) + (((n) % (c)) ? 1 : 0))
> >  
> > +#define MTK_DSI_HOST_IS_READ(type) \
> > +	((type == MIPI_DSI_GENERIC_READ_REQUEST_0_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_READ_REQUEST_2_PARAM) || \
> > +	(type == MIPI_DSI_DCS_READ))
> > +
> > +#define MTK_DSI_HOST_IS_WRITE(type) \
> > +	((type == MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_SHORT_WRITE_1_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM) || \
> > +	(type == MIPI_DSI_DCS_SHORT_WRITE) || \
> > +	(type == MIPI_DSI_DCS_SHORT_WRITE_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_LONG_WRITE) || \
> > +	(type == MIPI_DSI_DCS_LONG_WRITE))
> > +
> >  struct phy;
> >  
> >  struct mtk_dsi {
> > @@ -148,6 +174,38 @@ struct mtk_dsi {
> >  	int irq_num, irq_data;
> >  };
> >  
> > +struct dsi_cmd_t0 {
> > +	u8 config;
> > +	u8 type;
> > +	u8 data0;
> > +	u8 data1;
> > +};
> > +
> > +struct dsi_cmd_t2 {
> > +	u8 config;
> > +	u8 type;
> > +	u16 wc16;
> > +	u8 *pdata;
> > +};
> > +
> > +struct dsi_rx_data {
> > +	u8 byte0;
> > +	u8 byte1;
> > +	u8 byte2;
> > +	u8 byte3;
> > +};
> > +
> > +struct dsi_tx_cmdq {
> > +	u8 byte0;
> > +	u8 byte1;
> > +	u8 byte2;
> > +	u8 byte3;
> > +};
> > +
> > +struct dsi_tx_cmdq_regs {
> > +	struct dsi_tx_cmdq data[128];
> > +};
> > +
> >  enum {
> >  	DSI_INT_SLEEPOUT_DONE_FLAG	= BIT(6),
> >  	DSI_INT_VM_CMD_DONE_FLAG	= BIT(5),
> > @@ -858,9 +916,273 @@ static int mtk_dsi_host_detach(struct mipi_dsi_host *host,
> >  	return 0;
> >  }
> >  
> > +static void mtk_dsi_set_cmdq(void __iomem *reg, u32 mask, u32 data)
> > +{
> > +	u32 temp = readl(reg);
> > +
> > +	writel((temp & ~mask) | (data & mask), reg);
> > +}
> > +
> > +static void mtk_dsi_wait_for_idle(struct mtk_dsi *dsi)
> > +{
> > +	u32 timeout_ms = 500000; /* total 1s ~ 2s timeout */
> > +
> > +	while (timeout_ms--) {
> > +		if (!(readl(dsi->regs + DSI_INTSTA) & DSI_BUSY))
> > +			break;
> > +
> > +		usleep_range(2, 4);
> > +	}
> > +
> > +	if (timeout_ms == 0) {
> > +		dev_info(dsi->dev, "polling dsi wait not busy timeout!\n");
> > +
> > +		mtk_dsi_enable(dsi);
> > +		mtk_dsi_reset_engine(dsi);
> > +	}
> > +}
> > +
> > +static ssize_t mtk_dsi_host_read_cmd(struct mtk_dsi *dsi,
> > +				     const struct mipi_dsi_msg *msg)
> > +{
> > +	u8 max_try_count = 5;
> > +	u32 recv_data_cnt, tmp_val;
> > +	u32 recv_data0, recv_data1, recv_data2, recv_data3;
> > +	struct dsi_rx_data read_data0, read_data1, read_data2, read_data3;
> > +	struct dsi_cmd_t0 t0;
> > +	s32 ret;
> > +
> > +	u8 *buffer = msg->rx_buf;
> > +	u8 buffer_size = msg->rx_len;
> > +	u8 packet_type;
> > +
> > +	if (readl(dsi->regs + DSI_MODE_CTRL) & 0x03) {
> > +		dev_info(dsi->dev, "dsi engine is not command mode\n");
> > +		return -1;
> > +	}
> > +
> > +	if (!buffer) {
> > +		dev_info(dsi->dev, "dsi receive buffer size may be NULL\n");
> > +		return -1;
> > +	}
> > +
> > +	do {
> > +		if (max_try_count == 0) {
> > +			dev_info(dsi->dev, "dsi engine read counter has been maxinum\n");
> > +			return -1;
> > +		}
> > +
> > +		max_try_count--;
> > +		recv_data_cnt = 0;
> > +
> > +		mtk_dsi_wait_for_idle(dsi);
> > +
> > +		t0.config = 0x04;
> > +		t0.data0 = *((u8 *)(msg->tx_buf));
> > +
> > +		if (buffer_size < 0x3)
> 
> It's better to use '3' instead of '0x3'.
OK.

> 
> > +			t0.type = MIPI_DSI_DCS_READ;
> > +		else
> > +			t0.type = MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM;
> > +
> > +		t0.data1 = 0;
> > +
> > +		tmp_val = (t0.data1 << 24) | (t0.data0 << 16) | (t0.type << 8) |
> > +			t0.config;
> 
> Why need 'struct dsi_cmd_t0 t0'? I think code is more simple when get
> rid of this structure. The code looks like:
> 
> tmp_val = (data1 << 24) | (data0 << 16) | (type << 8) | config;
We will check this part.

> 
> > +
> > +		writel(tmp_val, dsi->regs + DSI_CMDQ0);
> > +		mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, 1);
> > +
> > +		mtk_dsi_mask(dsi, DSI_RACK, RACK, RACK);
> > +		mtk_dsi_mask(dsi, DSI_INTSTA, LPRX_RD_RDY_INT_FLAG,
> > +			     ~LPRX_RD_RDY_INT_FLAG);
> > +		mtk_dsi_mask(dsi, DSI_INTSTA, CMD_DONE_INT_FLAG,
> > +			     ~CMD_DONE_INT_FLAG);
> 
> I think interrupt status should be cleared in irq handler. So you need
> not to clear it here.
will remove.

> 
> > +		mtk_dsi_mask(dsi, DSI_INTEN, DSI_INT_LPRX_RD_RDY_FLAG,
> > +			     DSI_INT_LPRX_RD_RDY_FLAG);
> > +		mtk_dsi_mask(dsi, DSI_INTEN, DSI_INT_CMD_DONE_FLAG,
> > +			     DSI_INT_CMD_DONE_FLAG);
> 
> Why enable cmd_done interrupt? You just need interrupt of LPRX_RD_RDY.
will remove.

> 
> > +
> > +		mtk_dsi_start(dsi);
> > +
> > +		dev_info(dsi->dev, "Start polling DSI read ready!!!\n");
> > +
> > +		 /* 2s timeout*/
> > +		ret = mtk_dsi_wait_for_irq_timeout(dsi,
> > +						   DSI_INT_LPRX_RD_RDY_FLAG,
> > +						   2000);
> > +		if (ret) {
> > +			dev_info(dsi->dev, "Polling DSI read ready timeout!!!\n");
> > +
> > +			mtk_dsi_enable(dsi);
> > +			mtk_dsi_reset_engine(dsi);
> > +
> > +			return ret;
> > +		}
> > +
> > +		dev_info(dsi->dev, "End polling DSI read ready!!!\n");
> > +
> > +		mtk_dsi_mask(dsi, DSI_RACK, RACK, RACK);
> > +		mtk_dsi_mask(dsi, DSI_INTSTA, LPRX_RD_RDY_INT_FLAG,
> > +			     ~LPRX_RD_RDY_INT_FLAG);
> > +
> > +		recv_data0 = readl(dsi->regs + DSI_RX_DATA0);
> > +		recv_data1 = readl(dsi->regs + DSI_RX_DATA1);
> > +		recv_data2 = readl(dsi->regs + DSI_RX_DATA2);
> > +		recv_data3 = readl(dsi->regs + DSI_RX_DATA3);
> > +
> > +		read_data0 = *((struct dsi_rx_data *)(&recv_data0));
> > +		read_data1 = *((struct dsi_rx_data *)(&recv_data1));
> > +		read_data2 = *((struct dsi_rx_data *)(&recv_data2));
> > +		read_data3 = *((struct dsi_rx_data *)(&recv_data3));
> 
> You only use read_data0. read_data1, read_data2, and read_data3 are just
> for debug. Remove the debug only modification if they are not necessary.
> Or move them to another patch to make this patch clear.
We will remove the debug messages here.

> 
> > +
> > +		ret = readl(dsi->regs + DSI_CMDQ_SIZE);
> > +		dev_info(dsi->dev, "DSI_CMDQ_SIZE : 0x%x\n", ret & CMDQ_SIZE);
> > +
> > +		ret = readl(dsi->regs + DSI_CMDQ0);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA0 : 0x%x\n",
> > +			 ret & 0xff);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA1 : 0x%x\n",
> > +			 (ret >> 8) & 0xff);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA2 : 0x%x\n",
> > +			 (ret >> 16) & 0xff);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA3 : 0x%x\n",
> > +			 (ret >> 24) & 0xff);
> > +
> > +		dev_info(dsi->dev, "DSI_RX_DATA0: 0x%x\n", recv_data0);
> > +		dev_info(dsi->dev, "DSI_RX_DATA1: 0x%x\n", recv_data1);
> > +		dev_info(dsi->dev, "DSI_RX_DATA2: 0x%x\n", recv_data2);
> > +		dev_info(dsi->dev, "DSI_RX_DATA3: 0x%x\n", recv_data3);
> > +
> > +		dev_info(dsi->dev, "read_data0: %x,%x,%x,%x\n",
> > +			 read_data0.byte0, read_data0.byte1, read_data0.byte2,
> > +			 read_data0.byte3);
> > +		dev_info(dsi->dev, "read_data1: %x,%x,%x,%x\n",
> > +			 read_data1.byte0, read_data1.byte1, read_data1.byte2,
> > +			 read_data1.byte3);
> > +		dev_info(dsi->dev, "read_data2: %x,%x,%x,%x\n",
> > +			 read_data2.byte0, read_data2.byte1, read_data2.byte2,
> > +			 read_data2.byte3);
> > +		dev_info(dsi->dev, "read_data3: %x,%x,%x,%x\n",
> > +			 read_data3.byte0, read_data3.byte1, read_data3.byte2,
> > +			 read_data3.byte3);
> > +
> > +		packet_type = read_data0.byte0;
> > +		dev_info(dsi->dev, "DSI read packet_type is 0x%x\n",
> > +			 packet_type);
> > +
> > +		if (packet_type == 0x1a || packet_type == 0x1c) {
> > +			void *read_tmp = (void *)&recv_data1;
> > +
> > +			recv_data_cnt = read_data0.byte1 +
> > +					read_data0.byte2 * 16;
> > +			if (recv_data_cnt > 10)
> > +				recv_data_cnt = 10;
> 
> Why do you drop data over size of 10? Isn't it an error?
We will update these codes in the next version.

> 
> > +
> > +			if (recv_data_cnt > buffer_size)
> > +				recv_data_cnt = buffer_size;
> 
> Isn't it an error while you drop data over the buffer size?
We will update these codes in the next version.

> 
> > +
> > +			memcpy(buffer, read_tmp, recv_data_cnt);
> > +		} else {
> > +			/* short  packet */
> > +			recv_data_cnt = 2;
> > +			if (recv_data_cnt > buffer_size)
> > +				recv_data_cnt = buffer_size;
> 
> Isn't it an error while you drop data over the buffer size?
We will update these codes in the next version.

> 
> > +
> > +			memcpy(buffer, &read_data0.byte1, 2);
> 
> If buffer_size is 1, why do you still copy 2 bytes?
Will fix.

> 
> > +		}
> > +	} while (packet_type != 0x1c && packet_type != 0x21 &&
> > +		packet_type != 0x22 && packet_type != 0x1a);
> 
> Could you give these magic number a descriptive name?
OK.

> 
> > +
> > +	dev_info(dsi->dev, "dsi get %d byte data from the panel address(0x%x)\n",
> > +		 recv_data_cnt, *((u8 *)(msg->tx_buf)));
> > +
> > +	return recv_data_cnt;
> > +}
> > +
> > +static ssize_t mtk_dsi_host_write_cmd(struct mtk_dsi *dsi,
> > +				      const struct mipi_dsi_msg *msg)
> > +{
> > +	u32 i;
> > +	u32 goto_addr, mask_para, set_para, reg_val;
> > +	void __iomem *cmdq_reg;
> > +	struct dsi_cmd_t0 t0;
> > +	struct dsi_cmd_t2 t2;
> > +	const char *tx_buf = msg->tx_buf;
> > +	struct dsi_tx_cmdq_regs *dsi_cmd_reg;
> > +
> > +	dsi_cmd_reg = (struct dsi_tx_cmdq_regs *)(dsi->regs + DSI_CMDQ0);
> > +
> > +	mtk_dsi_wait_for_idle(dsi);
> > +
> > +	if (msg->tx_len > 2) {
> > +		t2.config = 2;
> > +		t2.type = msg->type;
> > +		t2.wc16 = msg->tx_len;
> > +
> > +		reg_val = (t2.wc16 << 16) | (t2.type << 8) | t2.config;
> 
> Why need 'struct dsi_cmd_t2 t2'? I think code is more simple when get
> rid of this structure. The code looks like:
> 
> reg_val = (wc16 << 16) | (type << 8) | config;
We will check this part.

> 
> > +
> > +		writel(reg_val, &dsi_cmd_reg->data[0]);
> > +
> > +		goto_addr = (u32)(&dsi_cmd_reg->data[1].byte0);
> > +		mask_para = (0xff << ((goto_addr & 0x3) * 8));
> > +		set_para = (tx_buf[0] << ((goto_addr & 0x3) * 8));
> > +		cmdq_reg = (void __iomem *)(goto_addr & (~0x3));
> > +		mtk_dsi_set_cmdq(cmdq_reg, mask_para, set_para);
> 
> I think you can merge this setting into 'for loop' and the loop look
> like this:
> 
> for (i = 0; i < msg->tx_len; i++) {
> 	goto_addr = (u32)(&dsi_cmd_reg->data[1].byte0) + i;
> 	mask_para = (0xff << ((goto_addr & 0x3) * 8));
> 	set_para = (tx_buf[i] << ((goto_addr & 0x3) * 8));
> 	cmdq_reg = (void __iomem *)(goto_addr & (~0x3));
> 	mtk_dsi_set_cmdq(cmdq_reg, mask_para, set_para);
> }
OK, we will merge it into the loop.

> 
> > +
> > +		for (i = 1; i < msg->tx_len; i++) {
> > +			goto_addr = (u32)(&dsi_cmd_reg->data[1].byte1) + i - 1;
> > +			mask_para = (0xff << ((goto_addr & 0x3) * 8));
> > +			set_para = (tx_buf[i] << ((goto_addr & 0x3) * 8));
> > +			cmdq_reg = (void __iomem *)(goto_addr & (~0x3));
> > +			mtk_dsi_set_cmdq(cmdq_reg, mask_para, set_para);
> > +		}
> > +
> > +		mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE,
> > +			     2 + (msg->tx_len - 1) / 4);
> 
> I think it is better to change formula of DSI_CMDQ_SIZE to '1 +
> (msg->tx_len + 3) / 4'. The '1' means the first cmd which describe the
> size of tx_buf, and the rest means the other cmds for body of tx_buf.
OK.

Regards,
yt.shen

> 
> > +	} else {
> > +		t0.config = 0;
> > +		t0.data0 = tx_buf[0];
> > +		if (msg->tx_len == 2) {
> > +			t0.type = MIPI_DSI_DCS_SHORT_WRITE_PARAM;
> > +			t0.data1 = tx_buf[1];
> > +		} else {
> > +			t0.type = MIPI_DSI_DCS_SHORT_WRITE;
> > +			t0.data1 = 0;
> > +		}
> > +
> > +		reg_val = (t0.data1 << 24) | (t0.data0 << 16) | (t0.type << 8) |
> > +			   t0.config;
> > +
> > +		writel(reg_val, &dsi_cmd_reg->data[0]);
> > +		mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, 1);
> > +	}
> > +
> > +	mtk_dsi_start(dsi);
> > +	mtk_dsi_wait_for_idle(dsi);
> > +
> > +	return 0;
> > +}
> > +
> > +static ssize_t mtk_dsi_host_transfer(struct mipi_dsi_host *host,
> > +				     const struct mipi_dsi_msg *msg)
> > +{
> > +	struct mtk_dsi *dsi = host_to_dsi(host);
> > +	u8 type = msg->type;
> > +	ssize_t ret = 0;
> > +
> > +	if (MTK_DSI_HOST_IS_READ(type))
> > +		ret = mtk_dsi_host_read_cmd(dsi, msg);
> > +	else if (MTK_DSI_HOST_IS_WRITE(type))
> > +		ret = mtk_dsi_host_write_cmd(dsi, msg);
> > +
> > +	return ret;
> > +}
> > +
> >  static const struct mipi_dsi_host_ops mtk_dsi_ops = {
> >  	.attach = mtk_dsi_host_attach,
> >  	.detach = mtk_dsi_host_detach,
> > +	.transfer = mtk_dsi_host_transfer,
> >  };
> >  
> >  static int mtk_dsi_bind(struct device *dev, struct device *master, void *data)
> 
> 
> Regards,
> CK
> 

From mboxrd@z Thu Jan  1 00:00:00 1970
From: YT Shen <yt.shen@mediatek.com>
Subject: Re: [PATCH v4 6/8] drm/mediatek: add dsi transfer function
Date: Tue, 26 Jul 2016 18:42:36 +0800
Message-ID: <1469529756.4678.30.camel@mtksdaap41>
References: <1468577274-6178-1-git-send-email-yt.shen@mediatek.com>
 <1468577274-6178-7-git-send-email-yt.shen@mediatek.com>
 <1468994346.11841.31.camel@mtksdaap41>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1468994346.11841.31.camel@mtksdaap41>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: CK Hu <ck.hu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>, dri-devel@lists.freedesktop.org, Russell King <linux@arm.linux.org.uk>, Mao Huang <littlecvr@chromium.org>, yingjoe.chen@mediatek.com, devicetree@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>, Pawel Moll <pawel.moll@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Rob Herring <robh+dt@kernel.org>, linux-mediatek@lists.infradead.org, Matthias Brugger <matthias.bgg@gmail.com>, shaoming chen <shaoming.chen@mediatek.com>, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, Kumar Gala <galak@codeaurora.org>
List-Id: devicetree@vger.kernel.org

SGkgQ0ssCgpUaGFua3MgZm9yIHRoZSByZXZpZXcuCgpPbiBXZWQsIDIwMTYtMDctMjAgYXQgMTM6
NTkgKzA4MDAsIENLIEh1IHdyb3RlOgo+IEhpLCBZVDoKPiAKPiBTb21lIGNvbW1lbnRzIGlubGlu
ZS4KPiAKPiBPbiBGcmksIDIwMTYtMDctMTUgYXQgMTg6MDcgKzA4MDAsIFlUIFNoZW4gd3JvdGU6
Cj4gPiBGcm9tOiBzaGFvbWluZyBjaGVuIDxzaGFvbWluZy5jaGVuQG1lZGlhdGVrLmNvbT4KPiA+
IAo+ID4gYWRkIGRzaSByZWFkL3dyaXRlIGNvbW1hbmRzIGZvciB0cmFuc2ZlciBmdW5jdGlvbgo+
ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBzaGFvbWluZyBjaGVuIDxzaGFvbWluZy5jaGVuQG1lZGlh
dGVrLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHNpLmMg
fCAgMzIyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIDEgZmlsZSBj
aGFuZ2VkLCAzMjIgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL21lZGlhdGVrL210a19kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtf
ZHNpLmMKPiA+IGluZGV4IGRlNWFkN2YuLjFmOTk4OTQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz
L2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RzaS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVk
aWF0ZWsvbXRrX2RzaS5jCj4gPiBAQCAtMjQsNiArMjQsNyBAQAo+ID4gICNpbmNsdWRlIDxsaW51
eC9vZl9ncmFwaC5oPgo+ID4gICNpbmNsdWRlIDxsaW51eC9waHkvcGh5Lmg+Cj4gPiAgI2luY2x1
ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ID4gKyNpbmNsdWRlIDx2aWRlby9taXBpX2Rp
c3BsYXkuaD4KPiA+ICAjaW5jbHVkZSA8dmlkZW8vdmlkZW9tb2RlLmg+Cj4gPiAgCj4gPiAgI2lu
Y2x1ZGUgIm10a19kcm1fZGRwX2NvbXAuaCIKPiA+IEBAIC04MCw4ICs4MSwxNiBAQAo+ID4gICNk
ZWZpbmUgRFNJX0hCUF9XQwkJMHg1NAo+ID4gICNkZWZpbmUgRFNJX0hGUF9XQwkJMHg1OAo+ID4g
IAo+ID4gKyNkZWZpbmUgRFNJX0NNRFFfU0laRQkJMHg2MAo+ID4gKyNkZWZpbmUgQ01EUV9TSVpF
CQkweDNmCj4gPiArCj4gPiAgI2RlZmluZSBEU0lfSFNUWF9DS0xfV0MJCTB4NjQKPiA+ICAKPiA+
ICsjZGVmaW5lIERTSV9SWF9EQVRBMAkJMHg3NAo+ID4gKyNkZWZpbmUgRFNJX1JYX0RBVEExCQkw
eDc4Cj4gPiArI2RlZmluZSBEU0lfUlhfREFUQTIJCTB4N2MKPiA+ICsjZGVmaW5lIERTSV9SWF9E
QVRBMwkJMHg4MAo+ID4gKwo+ID4gICNkZWZpbmUgRFNJX1JBQ0sJCTB4ODQKPiA+ICAjZGVmaW5l
IFJBQ0sJCQlCSVQoMCkKPiA+ICAKPiA+IEBAIC0xMTcsOCArMTI2LDI1IEBACj4gPiAgI2RlZmlu
ZSBDTEtfSFNfUE9TVAkJCSgweGZmIDw8IDgpCj4gPiAgI2RlZmluZSBDTEtfSFNfRVhJVAkJCSgw
eGZmIDw8IDE2KQo+ID4gIAo+ID4gKyNkZWZpbmUgRFNJX0NNRFEwCQkweDE4MAo+ID4gKwo+ID4g
ICNkZWZpbmUgTlNfVE9fQ1lDTEUobiwgYykgICAgKChuKSAvIChjKSArICgoKG4pICUgKGMpKSA/
IDEgOiAwKSkKPiA+ICAKPiA+ICsjZGVmaW5lIE1US19EU0lfSE9TVF9JU19SRUFEKHR5cGUpIFwK
PiA+ICsJKCh0eXBlID09IE1JUElfRFNJX0dFTkVSSUNfUkVBRF9SRVFVRVNUXzBfUEFSQU0pIHx8
IFwKPiA+ICsJKHR5cGUgPT0gTUlQSV9EU0lfR0VORVJJQ19SRUFEX1JFUVVFU1RfMV9QQVJBTSkg
fHwgXAo+ID4gKwkodHlwZSA9PSBNSVBJX0RTSV9HRU5FUklDX1JFQURfUkVRVUVTVF8yX1BBUkFN
KSB8fCBcCj4gPiArCSh0eXBlID09IE1JUElfRFNJX0RDU19SRUFEKSkKPiA+ICsKPiA+ICsjZGVm
aW5lIE1US19EU0lfSE9TVF9JU19XUklURSh0eXBlKSBcCj4gPiArCSgodHlwZSA9PSBNSVBJX0RT
SV9HRU5FUklDX1NIT1JUX1dSSVRFXzBfUEFSQU0pIHx8IFwKPiA+ICsJKHR5cGUgPT0gTUlQSV9E
U0lfR0VORVJJQ19TSE9SVF9XUklURV8xX1BBUkFNKSB8fCBcCj4gPiArCSh0eXBlID09IE1JUElf
RFNJX0dFTkVSSUNfU0hPUlRfV1JJVEVfMl9QQVJBTSkgfHwgXAo+ID4gKwkodHlwZSA9PSBNSVBJ
X0RTSV9EQ1NfU0hPUlRfV1JJVEUpIHx8IFwKPiA+ICsJKHR5cGUgPT0gTUlQSV9EU0lfRENTX1NI
T1JUX1dSSVRFX1BBUkFNKSB8fCBcCj4gPiArCSh0eXBlID09IE1JUElfRFNJX0dFTkVSSUNfTE9O
R19XUklURSkgfHwgXAo+ID4gKwkodHlwZSA9PSBNSVBJX0RTSV9EQ1NfTE9OR19XUklURSkpCj4g
PiArCj4gPiAgc3RydWN0IHBoeTsKPiA+ICAKPiA+ICBzdHJ1Y3QgbXRrX2RzaSB7Cj4gPiBAQCAt
MTQ4LDYgKzE3NCwzOCBAQCBzdHJ1Y3QgbXRrX2RzaSB7Cj4gPiAgCWludCBpcnFfbnVtLCBpcnFf
ZGF0YTsKPiA+ICB9Owo+ID4gIAo+ID4gK3N0cnVjdCBkc2lfY21kX3QwIHsKPiA+ICsJdTggY29u
ZmlnOwo+ID4gKwl1OCB0eXBlOwo+ID4gKwl1OCBkYXRhMDsKPiA+ICsJdTggZGF0YTE7Cj4gPiAr
fTsKPiA+ICsKPiA+ICtzdHJ1Y3QgZHNpX2NtZF90MiB7Cj4gPiArCXU4IGNvbmZpZzsKPiA+ICsJ
dTggdHlwZTsKPiA+ICsJdTE2IHdjMTY7Cj4gPiArCXU4ICpwZGF0YTsKPiA+ICt9Owo+ID4gKwo+
ID4gK3N0cnVjdCBkc2lfcnhfZGF0YSB7Cj4gPiArCXU4IGJ5dGUwOwo+ID4gKwl1OCBieXRlMTsK
PiA+ICsJdTggYnl0ZTI7Cj4gPiArCXU4IGJ5dGUzOwo+ID4gK307Cj4gPiArCj4gPiArc3RydWN0
IGRzaV90eF9jbWRxIHsKPiA+ICsJdTggYnl0ZTA7Cj4gPiArCXU4IGJ5dGUxOwo+ID4gKwl1OCBi
eXRlMjsKPiA+ICsJdTggYnl0ZTM7Cj4gPiArfTsKPiA+ICsKPiA+ICtzdHJ1Y3QgZHNpX3R4X2Nt
ZHFfcmVncyB7Cj4gPiArCXN0cnVjdCBkc2lfdHhfY21kcSBkYXRhWzEyOF07Cj4gPiArfTsKPiA+
ICsKPiA+ICBlbnVtIHsKPiA+ICAJRFNJX0lOVF9TTEVFUE9VVF9ET05FX0ZMQUcJPSBCSVQoNiks
Cj4gPiAgCURTSV9JTlRfVk1fQ01EX0RPTkVfRkxBRwk9IEJJVCg1KSwKPiA+IEBAIC04NTgsOSAr
OTE2LDI3MyBAQCBzdGF0aWMgaW50IG10a19kc2lfaG9zdF9kZXRhY2goc3RydWN0IG1pcGlfZHNp
X2hvc3QgKmhvc3QsCj4gPiAgCXJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgdm9p
ZCBtdGtfZHNpX3NldF9jbWRxKHZvaWQgX19pb21lbSAqcmVnLCB1MzIgbWFzaywgdTMyIGRhdGEp
Cj4gPiArewo+ID4gKwl1MzIgdGVtcCA9IHJlYWRsKHJlZyk7Cj4gPiArCj4gPiArCXdyaXRlbCgo
dGVtcCAmIH5tYXNrKSB8IChkYXRhICYgbWFzayksIHJlZyk7Cj4gPiArfQo+ID4gKwo+ID4gK3N0
YXRpYyB2b2lkIG10a19kc2lfd2FpdF9mb3JfaWRsZShzdHJ1Y3QgbXRrX2RzaSAqZHNpKQo+ID4g
K3sKPiA+ICsJdTMyIHRpbWVvdXRfbXMgPSA1MDAwMDA7IC8qIHRvdGFsIDFzIH4gMnMgdGltZW91
dCAqLwo+ID4gKwo+ID4gKwl3aGlsZSAodGltZW91dF9tcy0tKSB7Cj4gPiArCQlpZiAoIShyZWFk
bChkc2ktPnJlZ3MgKyBEU0lfSU5UU1RBKSAmIERTSV9CVVNZKSkKPiA+ICsJCQlicmVhazsKPiA+
ICsKPiA+ICsJCXVzbGVlcF9yYW5nZSgyLCA0KTsKPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAodGlt
ZW91dF9tcyA9PSAwKSB7Cj4gPiArCQlkZXZfaW5mbyhkc2ktPmRldiwgInBvbGxpbmcgZHNpIHdh
aXQgbm90IGJ1c3kgdGltZW91dCFcbiIpOwo+ID4gKwo+ID4gKwkJbXRrX2RzaV9lbmFibGUoZHNp
KTsKPiA+ICsJCW10a19kc2lfcmVzZXRfZW5naW5lKGRzaSk7Cj4gPiArCX0KPiA+ICt9Cj4gPiAr
Cj4gPiArc3RhdGljIHNzaXplX3QgbXRrX2RzaV9ob3N0X3JlYWRfY21kKHN0cnVjdCBtdGtfZHNp
ICpkc2ksCj4gPiArCQkJCSAgICAgY29uc3Qgc3RydWN0IG1pcGlfZHNpX21zZyAqbXNnKQo+ID4g
K3sKPiA+ICsJdTggbWF4X3RyeV9jb3VudCA9IDU7Cj4gPiArCXUzMiByZWN2X2RhdGFfY250LCB0
bXBfdmFsOwo+ID4gKwl1MzIgcmVjdl9kYXRhMCwgcmVjdl9kYXRhMSwgcmVjdl9kYXRhMiwgcmVj
dl9kYXRhMzsKPiA+ICsJc3RydWN0IGRzaV9yeF9kYXRhIHJlYWRfZGF0YTAsIHJlYWRfZGF0YTEs
IHJlYWRfZGF0YTIsIHJlYWRfZGF0YTM7Cj4gPiArCXN0cnVjdCBkc2lfY21kX3QwIHQwOwo+ID4g
KwlzMzIgcmV0Owo+ID4gKwo+ID4gKwl1OCAqYnVmZmVyID0gbXNnLT5yeF9idWY7Cj4gPiArCXU4
IGJ1ZmZlcl9zaXplID0gbXNnLT5yeF9sZW47Cj4gPiArCXU4IHBhY2tldF90eXBlOwo+ID4gKwo+
ID4gKwlpZiAocmVhZGwoZHNpLT5yZWdzICsgRFNJX01PREVfQ1RSTCkgJiAweDAzKSB7Cj4gPiAr
CQlkZXZfaW5mbyhkc2ktPmRldiwgImRzaSBlbmdpbmUgaXMgbm90IGNvbW1hbmQgbW9kZVxuIik7
Cj4gPiArCQlyZXR1cm4gLTE7Cj4gPiArCX0KPiA+ICsKPiA+ICsJaWYgKCFidWZmZXIpIHsKPiA+
ICsJCWRldl9pbmZvKGRzaS0+ZGV2LCAiZHNpIHJlY2VpdmUgYnVmZmVyIHNpemUgbWF5IGJlIE5V
TExcbiIpOwo+ID4gKwkJcmV0dXJuIC0xOwo+ID4gKwl9Cj4gPiArCj4gPiArCWRvIHsKPiA+ICsJ
CWlmIChtYXhfdHJ5X2NvdW50ID09IDApIHsKPiA+ICsJCQlkZXZfaW5mbyhkc2ktPmRldiwgImRz
aSBlbmdpbmUgcmVhZCBjb3VudGVyIGhhcyBiZWVuIG1heGludW1cbiIpOwo+ID4gKwkJCXJldHVy
biAtMTsKPiA+ICsJCX0KPiA+ICsKPiA+ICsJCW1heF90cnlfY291bnQtLTsKPiA+ICsJCXJlY3Zf
ZGF0YV9jbnQgPSAwOwo+ID4gKwo+ID4gKwkJbXRrX2RzaV93YWl0X2Zvcl9pZGxlKGRzaSk7Cj4g
PiArCj4gPiArCQl0MC5jb25maWcgPSAweDA0Owo+ID4gKwkJdDAuZGF0YTAgPSAqKCh1OCAqKSht
c2ctPnR4X2J1ZikpOwo+ID4gKwo+ID4gKwkJaWYgKGJ1ZmZlcl9zaXplIDwgMHgzKQo+IAo+IEl0
J3MgYmV0dGVyIHRvIHVzZSAnMycgaW5zdGVhZCBvZiAnMHgzJy4KT0suCgo+IAo+ID4gKwkJCXQw
LnR5cGUgPSBNSVBJX0RTSV9EQ1NfUkVBRDsKPiA+ICsJCWVsc2UKPiA+ICsJCQl0MC50eXBlID0g
TUlQSV9EU0lfR0VORVJJQ19SRUFEX1JFUVVFU1RfMV9QQVJBTTsKPiA+ICsKPiA+ICsJCXQwLmRh
dGExID0gMDsKPiA+ICsKPiA+ICsJCXRtcF92YWwgPSAodDAuZGF0YTEgPDwgMjQpIHwgKHQwLmRh
dGEwIDw8IDE2KSB8ICh0MC50eXBlIDw8IDgpIHwKPiA+ICsJCQl0MC5jb25maWc7Cj4gCj4gV2h5
IG5lZWQgJ3N0cnVjdCBkc2lfY21kX3QwIHQwJz8gSSB0aGluayBjb2RlIGlzIG1vcmUgc2ltcGxl
IHdoZW4gZ2V0Cj4gcmlkIG9mIHRoaXMgc3RydWN0dXJlLiBUaGUgY29kZSBsb29rcyBsaWtlOgo+
IAo+IHRtcF92YWwgPSAoZGF0YTEgPDwgMjQpIHwgKGRhdGEwIDw8IDE2KSB8ICh0eXBlIDw8IDgp
IHwgY29uZmlnOwpXZSB3aWxsIGNoZWNrIHRoaXMgcGFydC4KCj4gCj4gPiArCj4gPiArCQl3cml0
ZWwodG1wX3ZhbCwgZHNpLT5yZWdzICsgRFNJX0NNRFEwKTsKPiA+ICsJCW10a19kc2lfbWFzayhk
c2ksIERTSV9DTURRX1NJWkUsIENNRFFfU0laRSwgMSk7Cj4gPiArCj4gPiArCQltdGtfZHNpX21h
c2soZHNpLCBEU0lfUkFDSywgUkFDSywgUkFDSyk7Cj4gPiArCQltdGtfZHNpX21hc2soZHNpLCBE
U0lfSU5UU1RBLCBMUFJYX1JEX1JEWV9JTlRfRkxBRywKPiA+ICsJCQkgICAgIH5MUFJYX1JEX1JE
WV9JTlRfRkxBRyk7Cj4gPiArCQltdGtfZHNpX21hc2soZHNpLCBEU0lfSU5UU1RBLCBDTURfRE9O
RV9JTlRfRkxBRywKPiA+ICsJCQkgICAgIH5DTURfRE9ORV9JTlRfRkxBRyk7Cj4gCj4gSSB0aGlu
ayBpbnRlcnJ1cHQgc3RhdHVzIHNob3VsZCBiZSBjbGVhcmVkIGluIGlycSBoYW5kbGVyLiBTbyB5
b3UgbmVlZAo+IG5vdCB0byBjbGVhciBpdCBoZXJlLgp3aWxsIHJlbW92ZS4KCj4gCj4gPiArCQlt
dGtfZHNpX21hc2soZHNpLCBEU0lfSU5URU4sIERTSV9JTlRfTFBSWF9SRF9SRFlfRkxBRywKPiA+
ICsJCQkgICAgIERTSV9JTlRfTFBSWF9SRF9SRFlfRkxBRyk7Cj4gPiArCQltdGtfZHNpX21hc2so
ZHNpLCBEU0lfSU5URU4sIERTSV9JTlRfQ01EX0RPTkVfRkxBRywKPiA+ICsJCQkgICAgIERTSV9J
TlRfQ01EX0RPTkVfRkxBRyk7Cj4gCj4gV2h5IGVuYWJsZSBjbWRfZG9uZSBpbnRlcnJ1cHQ/IFlv
dSBqdXN0IG5lZWQgaW50ZXJydXB0IG9mIExQUlhfUkRfUkRZLgp3aWxsIHJlbW92ZS4KCj4gCj4g
PiArCj4gPiArCQltdGtfZHNpX3N0YXJ0KGRzaSk7Cj4gPiArCj4gPiArCQlkZXZfaW5mbyhkc2kt
PmRldiwgIlN0YXJ0IHBvbGxpbmcgRFNJIHJlYWQgcmVhZHkhISFcbiIpOwo+ID4gKwo+ID4gKwkJ
IC8qIDJzIHRpbWVvdXQqLwo+ID4gKwkJcmV0ID0gbXRrX2RzaV93YWl0X2Zvcl9pcnFfdGltZW91
dChkc2ksCj4gPiArCQkJCQkJICAgRFNJX0lOVF9MUFJYX1JEX1JEWV9GTEFHLAo+ID4gKwkJCQkJ
CSAgIDIwMDApOwo+ID4gKwkJaWYgKHJldCkgewo+ID4gKwkJCWRldl9pbmZvKGRzaS0+ZGV2LCAi
UG9sbGluZyBEU0kgcmVhZCByZWFkeSB0aW1lb3V0ISEhXG4iKTsKPiA+ICsKPiA+ICsJCQltdGtf
ZHNpX2VuYWJsZShkc2kpOwo+ID4gKwkJCW10a19kc2lfcmVzZXRfZW5naW5lKGRzaSk7Cj4gPiAr
Cj4gPiArCQkJcmV0dXJuIHJldDsKPiA+ICsJCX0KPiA+ICsKPiA+ICsJCWRldl9pbmZvKGRzaS0+
ZGV2LCAiRW5kIHBvbGxpbmcgRFNJIHJlYWQgcmVhZHkhISFcbiIpOwo+ID4gKwo+ID4gKwkJbXRr
X2RzaV9tYXNrKGRzaSwgRFNJX1JBQ0ssIFJBQ0ssIFJBQ0spOwo+ID4gKwkJbXRrX2RzaV9tYXNr
KGRzaSwgRFNJX0lOVFNUQSwgTFBSWF9SRF9SRFlfSU5UX0ZMQUcsCj4gPiArCQkJICAgICB+TFBS
WF9SRF9SRFlfSU5UX0ZMQUcpOwo+ID4gKwo+ID4gKwkJcmVjdl9kYXRhMCA9IHJlYWRsKGRzaS0+
cmVncyArIERTSV9SWF9EQVRBMCk7Cj4gPiArCQlyZWN2X2RhdGExID0gcmVhZGwoZHNpLT5yZWdz
ICsgRFNJX1JYX0RBVEExKTsKPiA+ICsJCXJlY3ZfZGF0YTIgPSByZWFkbChkc2ktPnJlZ3MgKyBE
U0lfUlhfREFUQTIpOwo+ID4gKwkJcmVjdl9kYXRhMyA9IHJlYWRsKGRzaS0+cmVncyArIERTSV9S
WF9EQVRBMyk7Cj4gPiArCj4gPiArCQlyZWFkX2RhdGEwID0gKigoc3RydWN0IGRzaV9yeF9kYXRh
ICopKCZyZWN2X2RhdGEwKSk7Cj4gPiArCQlyZWFkX2RhdGExID0gKigoc3RydWN0IGRzaV9yeF9k
YXRhICopKCZyZWN2X2RhdGExKSk7Cj4gPiArCQlyZWFkX2RhdGEyID0gKigoc3RydWN0IGRzaV9y
eF9kYXRhICopKCZyZWN2X2RhdGEyKSk7Cj4gPiArCQlyZWFkX2RhdGEzID0gKigoc3RydWN0IGRz
aV9yeF9kYXRhICopKCZyZWN2X2RhdGEzKSk7Cj4gCj4gWW91IG9ubHkgdXNlIHJlYWRfZGF0YTAu
IHJlYWRfZGF0YTEsIHJlYWRfZGF0YTIsIGFuZCByZWFkX2RhdGEzIGFyZSBqdXN0Cj4gZm9yIGRl
YnVnLiBSZW1vdmUgdGhlIGRlYnVnIG9ubHkgbW9kaWZpY2F0aW9uIGlmIHRoZXkgYXJlIG5vdCBu
ZWNlc3NhcnkuCj4gT3IgbW92ZSB0aGVtIHRvIGFub3RoZXIgcGF0Y2ggdG8gbWFrZSB0aGlzIHBh
dGNoIGNsZWFyLgpXZSB3aWxsIHJlbW92ZSB0aGUgZGVidWcgbWVzc2FnZXMgaGVyZS4KCj4gCj4g
PiArCj4gPiArCQlyZXQgPSByZWFkbChkc2ktPnJlZ3MgKyBEU0lfQ01EUV9TSVpFKTsKPiA+ICsJ
CWRldl9pbmZvKGRzaS0+ZGV2LCAiRFNJX0NNRFFfU0laRSA6IDB4JXhcbiIsIHJldCAmIENNRFFf
U0laRSk7Cj4gPiArCj4gPiArCQlyZXQgPSByZWFkbChkc2ktPnJlZ3MgKyBEU0lfQ01EUTApOwo+
ID4gKwkJZGV2X2luZm8oZHNpLT5kZXYsICJEU0lfQ01EUV9EQVRBMCA6IDB4JXhcbiIsCj4gPiAr
CQkJIHJldCAmIDB4ZmYpOwo+ID4gKwkJZGV2X2luZm8oZHNpLT5kZXYsICJEU0lfQ01EUV9EQVRB
MSA6IDB4JXhcbiIsCj4gPiArCQkJIChyZXQgPj4gOCkgJiAweGZmKTsKPiA+ICsJCWRldl9pbmZv
KGRzaS0+ZGV2LCAiRFNJX0NNRFFfREFUQTIgOiAweCV4XG4iLAo+ID4gKwkJCSAocmV0ID4+IDE2
KSAmIDB4ZmYpOwo+ID4gKwkJZGV2X2luZm8oZHNpLT5kZXYsICJEU0lfQ01EUV9EQVRBMyA6IDB4
JXhcbiIsCj4gPiArCQkJIChyZXQgPj4gMjQpICYgMHhmZik7Cj4gPiArCj4gPiArCQlkZXZfaW5m
byhkc2ktPmRldiwgIkRTSV9SWF9EQVRBMDogMHgleFxuIiwgcmVjdl9kYXRhMCk7Cj4gPiArCQlk
ZXZfaW5mbyhkc2ktPmRldiwgIkRTSV9SWF9EQVRBMTogMHgleFxuIiwgcmVjdl9kYXRhMSk7Cj4g
PiArCQlkZXZfaW5mbyhkc2ktPmRldiwgIkRTSV9SWF9EQVRBMjogMHgleFxuIiwgcmVjdl9kYXRh
Mik7Cj4gPiArCQlkZXZfaW5mbyhkc2ktPmRldiwgIkRTSV9SWF9EQVRBMzogMHgleFxuIiwgcmVj
dl9kYXRhMyk7Cj4gPiArCj4gPiArCQlkZXZfaW5mbyhkc2ktPmRldiwgInJlYWRfZGF0YTA6ICV4
LCV4LCV4LCV4XG4iLAo+ID4gKwkJCSByZWFkX2RhdGEwLmJ5dGUwLCByZWFkX2RhdGEwLmJ5dGUx
LCByZWFkX2RhdGEwLmJ5dGUyLAo+ID4gKwkJCSByZWFkX2RhdGEwLmJ5dGUzKTsKPiA+ICsJCWRl
dl9pbmZvKGRzaS0+ZGV2LCAicmVhZF9kYXRhMTogJXgsJXgsJXgsJXhcbiIsCj4gPiArCQkJIHJl
YWRfZGF0YTEuYnl0ZTAsIHJlYWRfZGF0YTEuYnl0ZTEsIHJlYWRfZGF0YTEuYnl0ZTIsCj4gPiAr
CQkJIHJlYWRfZGF0YTEuYnl0ZTMpOwo+ID4gKwkJZGV2X2luZm8oZHNpLT5kZXYsICJyZWFkX2Rh
dGEyOiAleCwleCwleCwleFxuIiwKPiA+ICsJCQkgcmVhZF9kYXRhMi5ieXRlMCwgcmVhZF9kYXRh
Mi5ieXRlMSwgcmVhZF9kYXRhMi5ieXRlMiwKPiA+ICsJCQkgcmVhZF9kYXRhMi5ieXRlMyk7Cj4g
PiArCQlkZXZfaW5mbyhkc2ktPmRldiwgInJlYWRfZGF0YTM6ICV4LCV4LCV4LCV4XG4iLAo+ID4g
KwkJCSByZWFkX2RhdGEzLmJ5dGUwLCByZWFkX2RhdGEzLmJ5dGUxLCByZWFkX2RhdGEzLmJ5dGUy
LAo+ID4gKwkJCSByZWFkX2RhdGEzLmJ5dGUzKTsKPiA+ICsKPiA+ICsJCXBhY2tldF90eXBlID0g
cmVhZF9kYXRhMC5ieXRlMDsKPiA+ICsJCWRldl9pbmZvKGRzaS0+ZGV2LCAiRFNJIHJlYWQgcGFj
a2V0X3R5cGUgaXMgMHgleFxuIiwKPiA+ICsJCQkgcGFja2V0X3R5cGUpOwo+ID4gKwo+ID4gKwkJ
aWYgKHBhY2tldF90eXBlID09IDB4MWEgfHwgcGFja2V0X3R5cGUgPT0gMHgxYykgewo+ID4gKwkJ
CXZvaWQgKnJlYWRfdG1wID0gKHZvaWQgKikmcmVjdl9kYXRhMTsKPiA+ICsKPiA+ICsJCQlyZWN2
X2RhdGFfY250ID0gcmVhZF9kYXRhMC5ieXRlMSArCj4gPiArCQkJCQlyZWFkX2RhdGEwLmJ5dGUy
ICogMTY7Cj4gPiArCQkJaWYgKHJlY3ZfZGF0YV9jbnQgPiAxMCkKPiA+ICsJCQkJcmVjdl9kYXRh
X2NudCA9IDEwOwo+IAo+IFdoeSBkbyB5b3UgZHJvcCBkYXRhIG92ZXIgc2l6ZSBvZiAxMD8gSXNu
J3QgaXQgYW4gZXJyb3I/CldlIHdpbGwgdXBkYXRlIHRoZXNlIGNvZGVzIGluIHRoZSBuZXh0IHZl
cnNpb24uCgo+IAo+ID4gKwo+ID4gKwkJCWlmIChyZWN2X2RhdGFfY250ID4gYnVmZmVyX3NpemUp
Cj4gPiArCQkJCXJlY3ZfZGF0YV9jbnQgPSBidWZmZXJfc2l6ZTsKPiAKPiBJc24ndCBpdCBhbiBl
cnJvciB3aGlsZSB5b3UgZHJvcCBkYXRhIG92ZXIgdGhlIGJ1ZmZlciBzaXplPwpXZSB3aWxsIHVw
ZGF0ZSB0aGVzZSBjb2RlcyBpbiB0aGUgbmV4dCB2ZXJzaW9uLgoKPiAKPiA+ICsKPiA+ICsJCQlt
ZW1jcHkoYnVmZmVyLCByZWFkX3RtcCwgcmVjdl9kYXRhX2NudCk7Cj4gPiArCQl9IGVsc2Ugewo+
ID4gKwkJCS8qIHNob3J0ICBwYWNrZXQgKi8KPiA+ICsJCQlyZWN2X2RhdGFfY250ID0gMjsKPiA+
ICsJCQlpZiAocmVjdl9kYXRhX2NudCA+IGJ1ZmZlcl9zaXplKQo+ID4gKwkJCQlyZWN2X2RhdGFf
Y250ID0gYnVmZmVyX3NpemU7Cj4gCj4gSXNuJ3QgaXQgYW4gZXJyb3Igd2hpbGUgeW91IGRyb3Ag
ZGF0YSBvdmVyIHRoZSBidWZmZXIgc2l6ZT8KV2Ugd2lsbCB1cGRhdGUgdGhlc2UgY29kZXMgaW4g
dGhlIG5leHQgdmVyc2lvbi4KCj4gCj4gPiArCj4gPiArCQkJbWVtY3B5KGJ1ZmZlciwgJnJlYWRf
ZGF0YTAuYnl0ZTEsIDIpOwo+IAo+IElmIGJ1ZmZlcl9zaXplIGlzIDEsIHdoeSBkbyB5b3Ugc3Rp
bGwgY29weSAyIGJ5dGVzPwpXaWxsIGZpeC4KCj4gCj4gPiArCQl9Cj4gPiArCX0gd2hpbGUgKHBh
Y2tldF90eXBlICE9IDB4MWMgJiYgcGFja2V0X3R5cGUgIT0gMHgyMSAmJgo+ID4gKwkJcGFja2V0
X3R5cGUgIT0gMHgyMiAmJiBwYWNrZXRfdHlwZSAhPSAweDFhKTsKPiAKPiBDb3VsZCB5b3UgZ2l2
ZSB0aGVzZSBtYWdpYyBudW1iZXIgYSBkZXNjcmlwdGl2ZSBuYW1lPwpPSy4KCj4gCj4gPiArCj4g
PiArCWRldl9pbmZvKGRzaS0+ZGV2LCAiZHNpIGdldCAlZCBieXRlIGRhdGEgZnJvbSB0aGUgcGFu
ZWwgYWRkcmVzcygweCV4KVxuIiwKPiA+ICsJCSByZWN2X2RhdGFfY250LCAqKCh1OCAqKShtc2ct
PnR4X2J1ZikpKTsKPiA+ICsKPiA+ICsJcmV0dXJuIHJlY3ZfZGF0YV9jbnQ7Cj4gPiArfQo+ID4g
Kwo+ID4gK3N0YXRpYyBzc2l6ZV90IG10a19kc2lfaG9zdF93cml0ZV9jbWQoc3RydWN0IG10a19k
c2kgKmRzaSwKPiA+ICsJCQkJICAgICAgY29uc3Qgc3RydWN0IG1pcGlfZHNpX21zZyAqbXNnKQo+
ID4gK3sKPiA+ICsJdTMyIGk7Cj4gPiArCXUzMiBnb3RvX2FkZHIsIG1hc2tfcGFyYSwgc2V0X3Bh
cmEsIHJlZ192YWw7Cj4gPiArCXZvaWQgX19pb21lbSAqY21kcV9yZWc7Cj4gPiArCXN0cnVjdCBk
c2lfY21kX3QwIHQwOwo+ID4gKwlzdHJ1Y3QgZHNpX2NtZF90MiB0MjsKPiA+ICsJY29uc3QgY2hh
ciAqdHhfYnVmID0gbXNnLT50eF9idWY7Cj4gPiArCXN0cnVjdCBkc2lfdHhfY21kcV9yZWdzICpk
c2lfY21kX3JlZzsKPiA+ICsKPiA+ICsJZHNpX2NtZF9yZWcgPSAoc3RydWN0IGRzaV90eF9jbWRx
X3JlZ3MgKikoZHNpLT5yZWdzICsgRFNJX0NNRFEwKTsKPiA+ICsKPiA+ICsJbXRrX2RzaV93YWl0
X2Zvcl9pZGxlKGRzaSk7Cj4gPiArCj4gPiArCWlmIChtc2ctPnR4X2xlbiA+IDIpIHsKPiA+ICsJ
CXQyLmNvbmZpZyA9IDI7Cj4gPiArCQl0Mi50eXBlID0gbXNnLT50eXBlOwo+ID4gKwkJdDIud2Mx
NiA9IG1zZy0+dHhfbGVuOwo+ID4gKwo+ID4gKwkJcmVnX3ZhbCA9ICh0Mi53YzE2IDw8IDE2KSB8
ICh0Mi50eXBlIDw8IDgpIHwgdDIuY29uZmlnOwo+IAo+IFdoeSBuZWVkICdzdHJ1Y3QgZHNpX2Nt
ZF90MiB0Mic/IEkgdGhpbmsgY29kZSBpcyBtb3JlIHNpbXBsZSB3aGVuIGdldAo+IHJpZCBvZiB0
aGlzIHN0cnVjdHVyZS4gVGhlIGNvZGUgbG9va3MgbGlrZToKPiAKPiByZWdfdmFsID0gKHdjMTYg
PDwgMTYpIHwgKHR5cGUgPDwgOCkgfCBjb25maWc7CldlIHdpbGwgY2hlY2sgdGhpcyBwYXJ0LgoK
PiAKPiA+ICsKPiA+ICsJCXdyaXRlbChyZWdfdmFsLCAmZHNpX2NtZF9yZWctPmRhdGFbMF0pOwo+
ID4gKwo+ID4gKwkJZ290b19hZGRyID0gKHUzMikoJmRzaV9jbWRfcmVnLT5kYXRhWzFdLmJ5dGUw
KTsKPiA+ICsJCW1hc2tfcGFyYSA9ICgweGZmIDw8ICgoZ290b19hZGRyICYgMHgzKSAqIDgpKTsK
PiA+ICsJCXNldF9wYXJhID0gKHR4X2J1ZlswXSA8PCAoKGdvdG9fYWRkciAmIDB4MykgKiA4KSk7
Cj4gPiArCQljbWRxX3JlZyA9ICh2b2lkIF9faW9tZW0gKikoZ290b19hZGRyICYgKH4weDMpKTsK
PiA+ICsJCW10a19kc2lfc2V0X2NtZHEoY21kcV9yZWcsIG1hc2tfcGFyYSwgc2V0X3BhcmEpOwo+
IAo+IEkgdGhpbmsgeW91IGNhbiBtZXJnZSB0aGlzIHNldHRpbmcgaW50byAnZm9yIGxvb3AnIGFu
ZCB0aGUgbG9vcCBsb29rCj4gbGlrZSB0aGlzOgo+IAo+IGZvciAoaSA9IDA7IGkgPCBtc2ctPnR4
X2xlbjsgaSsrKSB7Cj4gCWdvdG9fYWRkciA9ICh1MzIpKCZkc2lfY21kX3JlZy0+ZGF0YVsxXS5i
eXRlMCkgKyBpOwo+IAltYXNrX3BhcmEgPSAoMHhmZiA8PCAoKGdvdG9fYWRkciAmIDB4MykgKiA4
KSk7Cj4gCXNldF9wYXJhID0gKHR4X2J1ZltpXSA8PCAoKGdvdG9fYWRkciAmIDB4MykgKiA4KSk7
Cj4gCWNtZHFfcmVnID0gKHZvaWQgX19pb21lbSAqKShnb3RvX2FkZHIgJiAofjB4MykpOwo+IAlt
dGtfZHNpX3NldF9jbWRxKGNtZHFfcmVnLCBtYXNrX3BhcmEsIHNldF9wYXJhKTsKPiB9Ck9LLCB3
ZSB3aWxsIG1lcmdlIGl0IGludG8gdGhlIGxvb3AuCgo+IAo+ID4gKwo+ID4gKwkJZm9yIChpID0g
MTsgaSA8IG1zZy0+dHhfbGVuOyBpKyspIHsKPiA+ICsJCQlnb3RvX2FkZHIgPSAodTMyKSgmZHNp
X2NtZF9yZWctPmRhdGFbMV0uYnl0ZTEpICsgaSAtIDE7Cj4gPiArCQkJbWFza19wYXJhID0gKDB4
ZmYgPDwgKChnb3RvX2FkZHIgJiAweDMpICogOCkpOwo+ID4gKwkJCXNldF9wYXJhID0gKHR4X2J1
ZltpXSA8PCAoKGdvdG9fYWRkciAmIDB4MykgKiA4KSk7Cj4gPiArCQkJY21kcV9yZWcgPSAodm9p
ZCBfX2lvbWVtICopKGdvdG9fYWRkciAmICh+MHgzKSk7Cj4gPiArCQkJbXRrX2RzaV9zZXRfY21k
cShjbWRxX3JlZywgbWFza19wYXJhLCBzZXRfcGFyYSk7Cj4gPiArCQl9Cj4gPiArCj4gPiArCQlt
dGtfZHNpX21hc2soZHNpLCBEU0lfQ01EUV9TSVpFLCBDTURRX1NJWkUsCj4gPiArCQkJICAgICAy
ICsgKG1zZy0+dHhfbGVuIC0gMSkgLyA0KTsKPiAKPiBJIHRoaW5rIGl0IGlzIGJldHRlciB0byBj
aGFuZ2UgZm9ybXVsYSBvZiBEU0lfQ01EUV9TSVpFIHRvICcxICsKPiAobXNnLT50eF9sZW4gKyAz
KSAvIDQnLiBUaGUgJzEnIG1lYW5zIHRoZSBmaXJzdCBjbWQgd2hpY2ggZGVzY3JpYmUgdGhlCj4g
c2l6ZSBvZiB0eF9idWYsIGFuZCB0aGUgcmVzdCBtZWFucyB0aGUgb3RoZXIgY21kcyBmb3IgYm9k
eSBvZiB0eF9idWYuCk9LLgoKUmVnYXJkcywKeXQuc2hlbgoKPiAKPiA+ICsJfSBlbHNlIHsKPiA+
ICsJCXQwLmNvbmZpZyA9IDA7Cj4gPiArCQl0MC5kYXRhMCA9IHR4X2J1ZlswXTsKPiA+ICsJCWlm
IChtc2ctPnR4X2xlbiA9PSAyKSB7Cj4gPiArCQkJdDAudHlwZSA9IE1JUElfRFNJX0RDU19TSE9S
VF9XUklURV9QQVJBTTsKPiA+ICsJCQl0MC5kYXRhMSA9IHR4X2J1ZlsxXTsKPiA+ICsJCX0gZWxz
ZSB7Cj4gPiArCQkJdDAudHlwZSA9IE1JUElfRFNJX0RDU19TSE9SVF9XUklURTsKPiA+ICsJCQl0
MC5kYXRhMSA9IDA7Cj4gPiArCQl9Cj4gPiArCj4gPiArCQlyZWdfdmFsID0gKHQwLmRhdGExIDw8
IDI0KSB8ICh0MC5kYXRhMCA8PCAxNikgfCAodDAudHlwZSA8PCA4KSB8Cj4gPiArCQkJICAgdDAu
Y29uZmlnOwo+ID4gKwo+ID4gKwkJd3JpdGVsKHJlZ192YWwsICZkc2lfY21kX3JlZy0+ZGF0YVsw
XSk7Cj4gPiArCQltdGtfZHNpX21hc2soZHNpLCBEU0lfQ01EUV9TSVpFLCBDTURRX1NJWkUsIDEp
Owo+ID4gKwl9Cj4gPiArCj4gPiArCW10a19kc2lfc3RhcnQoZHNpKTsKPiA+ICsJbXRrX2RzaV93
YWl0X2Zvcl9pZGxlKGRzaSk7Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ID4gK30KPiA+ICsKPiA+
ICtzdGF0aWMgc3NpemVfdCBtdGtfZHNpX2hvc3RfdHJhbnNmZXIoc3RydWN0IG1pcGlfZHNpX2hv
c3QgKmhvc3QsCj4gPiArCQkJCSAgICAgY29uc3Qgc3RydWN0IG1pcGlfZHNpX21zZyAqbXNnKQo+
ID4gK3sKPiA+ICsJc3RydWN0IG10a19kc2kgKmRzaSA9IGhvc3RfdG9fZHNpKGhvc3QpOwo+ID4g
Kwl1OCB0eXBlID0gbXNnLT50eXBlOwo+ID4gKwlzc2l6ZV90IHJldCA9IDA7Cj4gPiArCj4gPiAr
CWlmIChNVEtfRFNJX0hPU1RfSVNfUkVBRCh0eXBlKSkKPiA+ICsJCXJldCA9IG10a19kc2lfaG9z
dF9yZWFkX2NtZChkc2ksIG1zZyk7Cj4gPiArCWVsc2UgaWYgKE1US19EU0lfSE9TVF9JU19XUklU
RSh0eXBlKSkKPiA+ICsJCXJldCA9IG10a19kc2lfaG9zdF93cml0ZV9jbWQoZHNpLCBtc2cpOwo+
ID4gKwo+ID4gKwlyZXR1cm4gcmV0Owo+ID4gK30KPiA+ICsKPiA+ICBzdGF0aWMgY29uc3Qgc3Ry
dWN0IG1pcGlfZHNpX2hvc3Rfb3BzIG10a19kc2lfb3BzID0gewo+ID4gIAkuYXR0YWNoID0gbXRr
X2RzaV9ob3N0X2F0dGFjaCwKPiA+ICAJLmRldGFjaCA9IG10a19kc2lfaG9zdF9kZXRhY2gsCj4g
PiArCS50cmFuc2ZlciA9IG10a19kc2lfaG9zdF90cmFuc2ZlciwKPiA+ICB9Owo+ID4gIAo+ID4g
IHN0YXRpYyBpbnQgbXRrX2RzaV9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IGRldmlj
ZSAqbWFzdGVyLCB2b2lkICpkYXRhKQo+IAo+IAo+IFJlZ2FyZHMsCj4gQ0sKPiAKCgpfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu
ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl
ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

From mboxrd@z Thu Jan  1 00:00:00 1970
From: yt.shen@mediatek.com (YT Shen)
Date: Tue, 26 Jul 2016 18:42:36 +0800
Subject: [PATCH v4 6/8] drm/mediatek: add dsi transfer function
In-Reply-To: <1468994346.11841.31.camel@mtksdaap41>
References: <1468577274-6178-1-git-send-email-yt.shen@mediatek.com>
 <1468577274-6178-7-git-send-email-yt.shen@mediatek.com>
 <1468994346.11841.31.camel@mtksdaap41>
Message-ID: <1469529756.4678.30.camel@mtksdaap41>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi CK,

Thanks for the review.

On Wed, 2016-07-20 at 13:59 +0800, CK Hu wrote:
> Hi, YT:
> 
> Some comments inline.
> 
> On Fri, 2016-07-15 at 18:07 +0800, YT Shen wrote:
> > From: shaoming chen <shaoming.chen@mediatek.com>
> > 
> > add dsi read/write commands for transfer function
> > 
> > Signed-off-by: shaoming chen <shaoming.chen@mediatek.com>
> > ---
> >  drivers/gpu/drm/mediatek/mtk_dsi.c |  322 ++++++++++++++++++++++++++++++++++++
> >  1 file changed, 322 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > index de5ad7f..1f99894 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> > @@ -24,6 +24,7 @@
> >  #include <linux/of_graph.h>
> >  #include <linux/phy/phy.h>
> >  #include <linux/platform_device.h>
> > +#include <video/mipi_display.h>
> >  #include <video/videomode.h>
> >  
> >  #include "mtk_drm_ddp_comp.h"
> > @@ -80,8 +81,16 @@
> >  #define DSI_HBP_WC		0x54
> >  #define DSI_HFP_WC		0x58
> >  
> > +#define DSI_CMDQ_SIZE		0x60
> > +#define CMDQ_SIZE		0x3f
> > +
> >  #define DSI_HSTX_CKL_WC		0x64
> >  
> > +#define DSI_RX_DATA0		0x74
> > +#define DSI_RX_DATA1		0x78
> > +#define DSI_RX_DATA2		0x7c
> > +#define DSI_RX_DATA3		0x80
> > +
> >  #define DSI_RACK		0x84
> >  #define RACK			BIT(0)
> >  
> > @@ -117,8 +126,25 @@
> >  #define CLK_HS_POST			(0xff << 8)
> >  #define CLK_HS_EXIT			(0xff << 16)
> >  
> > +#define DSI_CMDQ0		0x180
> > +
> >  #define NS_TO_CYCLE(n, c)    ((n) / (c) + (((n) % (c)) ? 1 : 0))
> >  
> > +#define MTK_DSI_HOST_IS_READ(type) \
> > +	((type == MIPI_DSI_GENERIC_READ_REQUEST_0_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_READ_REQUEST_2_PARAM) || \
> > +	(type == MIPI_DSI_DCS_READ))
> > +
> > +#define MTK_DSI_HOST_IS_WRITE(type) \
> > +	((type == MIPI_DSI_GENERIC_SHORT_WRITE_0_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_SHORT_WRITE_1_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_SHORT_WRITE_2_PARAM) || \
> > +	(type == MIPI_DSI_DCS_SHORT_WRITE) || \
> > +	(type == MIPI_DSI_DCS_SHORT_WRITE_PARAM) || \
> > +	(type == MIPI_DSI_GENERIC_LONG_WRITE) || \
> > +	(type == MIPI_DSI_DCS_LONG_WRITE))
> > +
> >  struct phy;
> >  
> >  struct mtk_dsi {
> > @@ -148,6 +174,38 @@ struct mtk_dsi {
> >  	int irq_num, irq_data;
> >  };
> >  
> > +struct dsi_cmd_t0 {
> > +	u8 config;
> > +	u8 type;
> > +	u8 data0;
> > +	u8 data1;
> > +};
> > +
> > +struct dsi_cmd_t2 {
> > +	u8 config;
> > +	u8 type;
> > +	u16 wc16;
> > +	u8 *pdata;
> > +};
> > +
> > +struct dsi_rx_data {
> > +	u8 byte0;
> > +	u8 byte1;
> > +	u8 byte2;
> > +	u8 byte3;
> > +};
> > +
> > +struct dsi_tx_cmdq {
> > +	u8 byte0;
> > +	u8 byte1;
> > +	u8 byte2;
> > +	u8 byte3;
> > +};
> > +
> > +struct dsi_tx_cmdq_regs {
> > +	struct dsi_tx_cmdq data[128];
> > +};
> > +
> >  enum {
> >  	DSI_INT_SLEEPOUT_DONE_FLAG	= BIT(6),
> >  	DSI_INT_VM_CMD_DONE_FLAG	= BIT(5),
> > @@ -858,9 +916,273 @@ static int mtk_dsi_host_detach(struct mipi_dsi_host *host,
> >  	return 0;
> >  }
> >  
> > +static void mtk_dsi_set_cmdq(void __iomem *reg, u32 mask, u32 data)
> > +{
> > +	u32 temp = readl(reg);
> > +
> > +	writel((temp & ~mask) | (data & mask), reg);
> > +}
> > +
> > +static void mtk_dsi_wait_for_idle(struct mtk_dsi *dsi)
> > +{
> > +	u32 timeout_ms = 500000; /* total 1s ~ 2s timeout */
> > +
> > +	while (timeout_ms--) {
> > +		if (!(readl(dsi->regs + DSI_INTSTA) & DSI_BUSY))
> > +			break;
> > +
> > +		usleep_range(2, 4);
> > +	}
> > +
> > +	if (timeout_ms == 0) {
> > +		dev_info(dsi->dev, "polling dsi wait not busy timeout!\n");
> > +
> > +		mtk_dsi_enable(dsi);
> > +		mtk_dsi_reset_engine(dsi);
> > +	}
> > +}
> > +
> > +static ssize_t mtk_dsi_host_read_cmd(struct mtk_dsi *dsi,
> > +				     const struct mipi_dsi_msg *msg)
> > +{
> > +	u8 max_try_count = 5;
> > +	u32 recv_data_cnt, tmp_val;
> > +	u32 recv_data0, recv_data1, recv_data2, recv_data3;
> > +	struct dsi_rx_data read_data0, read_data1, read_data2, read_data3;
> > +	struct dsi_cmd_t0 t0;
> > +	s32 ret;
> > +
> > +	u8 *buffer = msg->rx_buf;
> > +	u8 buffer_size = msg->rx_len;
> > +	u8 packet_type;
> > +
> > +	if (readl(dsi->regs + DSI_MODE_CTRL) & 0x03) {
> > +		dev_info(dsi->dev, "dsi engine is not command mode\n");
> > +		return -1;
> > +	}
> > +
> > +	if (!buffer) {
> > +		dev_info(dsi->dev, "dsi receive buffer size may be NULL\n");
> > +		return -1;
> > +	}
> > +
> > +	do {
> > +		if (max_try_count == 0) {
> > +			dev_info(dsi->dev, "dsi engine read counter has been maxinum\n");
> > +			return -1;
> > +		}
> > +
> > +		max_try_count--;
> > +		recv_data_cnt = 0;
> > +
> > +		mtk_dsi_wait_for_idle(dsi);
> > +
> > +		t0.config = 0x04;
> > +		t0.data0 = *((u8 *)(msg->tx_buf));
> > +
> > +		if (buffer_size < 0x3)
> 
> It's better to use '3' instead of '0x3'.
OK.

> 
> > +			t0.type = MIPI_DSI_DCS_READ;
> > +		else
> > +			t0.type = MIPI_DSI_GENERIC_READ_REQUEST_1_PARAM;
> > +
> > +		t0.data1 = 0;
> > +
> > +		tmp_val = (t0.data1 << 24) | (t0.data0 << 16) | (t0.type << 8) |
> > +			t0.config;
> 
> Why need 'struct dsi_cmd_t0 t0'? I think code is more simple when get
> rid of this structure. The code looks like:
> 
> tmp_val = (data1 << 24) | (data0 << 16) | (type << 8) | config;
We will check this part.

> 
> > +
> > +		writel(tmp_val, dsi->regs + DSI_CMDQ0);
> > +		mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, 1);
> > +
> > +		mtk_dsi_mask(dsi, DSI_RACK, RACK, RACK);
> > +		mtk_dsi_mask(dsi, DSI_INTSTA, LPRX_RD_RDY_INT_FLAG,
> > +			     ~LPRX_RD_RDY_INT_FLAG);
> > +		mtk_dsi_mask(dsi, DSI_INTSTA, CMD_DONE_INT_FLAG,
> > +			     ~CMD_DONE_INT_FLAG);
> 
> I think interrupt status should be cleared in irq handler. So you need
> not to clear it here.
will remove.

> 
> > +		mtk_dsi_mask(dsi, DSI_INTEN, DSI_INT_LPRX_RD_RDY_FLAG,
> > +			     DSI_INT_LPRX_RD_RDY_FLAG);
> > +		mtk_dsi_mask(dsi, DSI_INTEN, DSI_INT_CMD_DONE_FLAG,
> > +			     DSI_INT_CMD_DONE_FLAG);
> 
> Why enable cmd_done interrupt? You just need interrupt of LPRX_RD_RDY.
will remove.

> 
> > +
> > +		mtk_dsi_start(dsi);
> > +
> > +		dev_info(dsi->dev, "Start polling DSI read ready!!!\n");
> > +
> > +		 /* 2s timeout*/
> > +		ret = mtk_dsi_wait_for_irq_timeout(dsi,
> > +						   DSI_INT_LPRX_RD_RDY_FLAG,
> > +						   2000);
> > +		if (ret) {
> > +			dev_info(dsi->dev, "Polling DSI read ready timeout!!!\n");
> > +
> > +			mtk_dsi_enable(dsi);
> > +			mtk_dsi_reset_engine(dsi);
> > +
> > +			return ret;
> > +		}
> > +
> > +		dev_info(dsi->dev, "End polling DSI read ready!!!\n");
> > +
> > +		mtk_dsi_mask(dsi, DSI_RACK, RACK, RACK);
> > +		mtk_dsi_mask(dsi, DSI_INTSTA, LPRX_RD_RDY_INT_FLAG,
> > +			     ~LPRX_RD_RDY_INT_FLAG);
> > +
> > +		recv_data0 = readl(dsi->regs + DSI_RX_DATA0);
> > +		recv_data1 = readl(dsi->regs + DSI_RX_DATA1);
> > +		recv_data2 = readl(dsi->regs + DSI_RX_DATA2);
> > +		recv_data3 = readl(dsi->regs + DSI_RX_DATA3);
> > +
> > +		read_data0 = *((struct dsi_rx_data *)(&recv_data0));
> > +		read_data1 = *((struct dsi_rx_data *)(&recv_data1));
> > +		read_data2 = *((struct dsi_rx_data *)(&recv_data2));
> > +		read_data3 = *((struct dsi_rx_data *)(&recv_data3));
> 
> You only use read_data0. read_data1, read_data2, and read_data3 are just
> for debug. Remove the debug only modification if they are not necessary.
> Or move them to another patch to make this patch clear.
We will remove the debug messages here.

> 
> > +
> > +		ret = readl(dsi->regs + DSI_CMDQ_SIZE);
> > +		dev_info(dsi->dev, "DSI_CMDQ_SIZE : 0x%x\n", ret & CMDQ_SIZE);
> > +
> > +		ret = readl(dsi->regs + DSI_CMDQ0);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA0 : 0x%x\n",
> > +			 ret & 0xff);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA1 : 0x%x\n",
> > +			 (ret >> 8) & 0xff);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA2 : 0x%x\n",
> > +			 (ret >> 16) & 0xff);
> > +		dev_info(dsi->dev, "DSI_CMDQ_DATA3 : 0x%x\n",
> > +			 (ret >> 24) & 0xff);
> > +
> > +		dev_info(dsi->dev, "DSI_RX_DATA0: 0x%x\n", recv_data0);
> > +		dev_info(dsi->dev, "DSI_RX_DATA1: 0x%x\n", recv_data1);
> > +		dev_info(dsi->dev, "DSI_RX_DATA2: 0x%x\n", recv_data2);
> > +		dev_info(dsi->dev, "DSI_RX_DATA3: 0x%x\n", recv_data3);
> > +
> > +		dev_info(dsi->dev, "read_data0: %x,%x,%x,%x\n",
> > +			 read_data0.byte0, read_data0.byte1, read_data0.byte2,
> > +			 read_data0.byte3);
> > +		dev_info(dsi->dev, "read_data1: %x,%x,%x,%x\n",
> > +			 read_data1.byte0, read_data1.byte1, read_data1.byte2,
> > +			 read_data1.byte3);
> > +		dev_info(dsi->dev, "read_data2: %x,%x,%x,%x\n",
> > +			 read_data2.byte0, read_data2.byte1, read_data2.byte2,
> > +			 read_data2.byte3);
> > +		dev_info(dsi->dev, "read_data3: %x,%x,%x,%x\n",
> > +			 read_data3.byte0, read_data3.byte1, read_data3.byte2,
> > +			 read_data3.byte3);
> > +
> > +		packet_type = read_data0.byte0;
> > +		dev_info(dsi->dev, "DSI read packet_type is 0x%x\n",
> > +			 packet_type);
> > +
> > +		if (packet_type == 0x1a || packet_type == 0x1c) {
> > +			void *read_tmp = (void *)&recv_data1;
> > +
> > +			recv_data_cnt = read_data0.byte1 +
> > +					read_data0.byte2 * 16;
> > +			if (recv_data_cnt > 10)
> > +				recv_data_cnt = 10;
> 
> Why do you drop data over size of 10? Isn't it an error?
We will update these codes in the next version.

> 
> > +
> > +			if (recv_data_cnt > buffer_size)
> > +				recv_data_cnt = buffer_size;
> 
> Isn't it an error while you drop data over the buffer size?
We will update these codes in the next version.

> 
> > +
> > +			memcpy(buffer, read_tmp, recv_data_cnt);
> > +		} else {
> > +			/* short  packet */
> > +			recv_data_cnt = 2;
> > +			if (recv_data_cnt > buffer_size)
> > +				recv_data_cnt = buffer_size;
> 
> Isn't it an error while you drop data over the buffer size?
We will update these codes in the next version.

> 
> > +
> > +			memcpy(buffer, &read_data0.byte1, 2);
> 
> If buffer_size is 1, why do you still copy 2 bytes?
Will fix.

> 
> > +		}
> > +	} while (packet_type != 0x1c && packet_type != 0x21 &&
> > +		packet_type != 0x22 && packet_type != 0x1a);
> 
> Could you give these magic number a descriptive name?
OK.

> 
> > +
> > +	dev_info(dsi->dev, "dsi get %d byte data from the panel address(0x%x)\n",
> > +		 recv_data_cnt, *((u8 *)(msg->tx_buf)));
> > +
> > +	return recv_data_cnt;
> > +}
> > +
> > +static ssize_t mtk_dsi_host_write_cmd(struct mtk_dsi *dsi,
> > +				      const struct mipi_dsi_msg *msg)
> > +{
> > +	u32 i;
> > +	u32 goto_addr, mask_para, set_para, reg_val;
> > +	void __iomem *cmdq_reg;
> > +	struct dsi_cmd_t0 t0;
> > +	struct dsi_cmd_t2 t2;
> > +	const char *tx_buf = msg->tx_buf;
> > +	struct dsi_tx_cmdq_regs *dsi_cmd_reg;
> > +
> > +	dsi_cmd_reg = (struct dsi_tx_cmdq_regs *)(dsi->regs + DSI_CMDQ0);
> > +
> > +	mtk_dsi_wait_for_idle(dsi);
> > +
> > +	if (msg->tx_len > 2) {
> > +		t2.config = 2;
> > +		t2.type = msg->type;
> > +		t2.wc16 = msg->tx_len;
> > +
> > +		reg_val = (t2.wc16 << 16) | (t2.type << 8) | t2.config;
> 
> Why need 'struct dsi_cmd_t2 t2'? I think code is more simple when get
> rid of this structure. The code looks like:
> 
> reg_val = (wc16 << 16) | (type << 8) | config;
We will check this part.

> 
> > +
> > +		writel(reg_val, &dsi_cmd_reg->data[0]);
> > +
> > +		goto_addr = (u32)(&dsi_cmd_reg->data[1].byte0);
> > +		mask_para = (0xff << ((goto_addr & 0x3) * 8));
> > +		set_para = (tx_buf[0] << ((goto_addr & 0x3) * 8));
> > +		cmdq_reg = (void __iomem *)(goto_addr & (~0x3));
> > +		mtk_dsi_set_cmdq(cmdq_reg, mask_para, set_para);
> 
> I think you can merge this setting into 'for loop' and the loop look
> like this:
> 
> for (i = 0; i < msg->tx_len; i++) {
> 	goto_addr = (u32)(&dsi_cmd_reg->data[1].byte0) + i;
> 	mask_para = (0xff << ((goto_addr & 0x3) * 8));
> 	set_para = (tx_buf[i] << ((goto_addr & 0x3) * 8));
> 	cmdq_reg = (void __iomem *)(goto_addr & (~0x3));
> 	mtk_dsi_set_cmdq(cmdq_reg, mask_para, set_para);
> }
OK, we will merge it into the loop.

> 
> > +
> > +		for (i = 1; i < msg->tx_len; i++) {
> > +			goto_addr = (u32)(&dsi_cmd_reg->data[1].byte1) + i - 1;
> > +			mask_para = (0xff << ((goto_addr & 0x3) * 8));
> > +			set_para = (tx_buf[i] << ((goto_addr & 0x3) * 8));
> > +			cmdq_reg = (void __iomem *)(goto_addr & (~0x3));
> > +			mtk_dsi_set_cmdq(cmdq_reg, mask_para, set_para);
> > +		}
> > +
> > +		mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE,
> > +			     2 + (msg->tx_len - 1) / 4);
> 
> I think it is better to change formula of DSI_CMDQ_SIZE to '1 +
> (msg->tx_len + 3) / 4'. The '1' means the first cmd which describe the
> size of tx_buf, and the rest means the other cmds for body of tx_buf.
OK.

Regards,
yt.shen

> 
> > +	} else {
> > +		t0.config = 0;
> > +		t0.data0 = tx_buf[0];
> > +		if (msg->tx_len == 2) {
> > +			t0.type = MIPI_DSI_DCS_SHORT_WRITE_PARAM;
> > +			t0.data1 = tx_buf[1];
> > +		} else {
> > +			t0.type = MIPI_DSI_DCS_SHORT_WRITE;
> > +			t0.data1 = 0;
> > +		}
> > +
> > +		reg_val = (t0.data1 << 24) | (t0.data0 << 16) | (t0.type << 8) |
> > +			   t0.config;
> > +
> > +		writel(reg_val, &dsi_cmd_reg->data[0]);
> > +		mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, 1);
> > +	}
> > +
> > +	mtk_dsi_start(dsi);
> > +	mtk_dsi_wait_for_idle(dsi);
> > +
> > +	return 0;
> > +}
> > +
> > +static ssize_t mtk_dsi_host_transfer(struct mipi_dsi_host *host,
> > +				     const struct mipi_dsi_msg *msg)
> > +{
> > +	struct mtk_dsi *dsi = host_to_dsi(host);
> > +	u8 type = msg->type;
> > +	ssize_t ret = 0;
> > +
> > +	if (MTK_DSI_HOST_IS_READ(type))
> > +		ret = mtk_dsi_host_read_cmd(dsi, msg);
> > +	else if (MTK_DSI_HOST_IS_WRITE(type))
> > +		ret = mtk_dsi_host_write_cmd(dsi, msg);
> > +
> > +	return ret;
> > +}
> > +
> >  static const struct mipi_dsi_host_ops mtk_dsi_ops = {
> >  	.attach = mtk_dsi_host_attach,
> >  	.detach = mtk_dsi_host_detach,
> > +	.transfer = mtk_dsi_host_transfer,
> >  };
> >  
> >  static int mtk_dsi_bind(struct device *dev, struct device *master, void *data)
> 
> 
> Regards,
> CK
>