On Sat, 2016-07-09 at 19:05 +0900, James Bottomley wrote:
> On Fri, 2016-07-08 at 17:43 -0700, Dmitry Torokhov wrote:
> > On Sat, Jul 09, 2016 at 02:37:40AM +0200, Rafael J. Wysocki wrote:
> > > I tend to think that all known bugs should be fixed, at least 
> > > because once they have been fixed, no one needs to remember about 
> > > them any more. :-)
> > > 
> > > Moreover, minor fixes don't really introduce regressions that often
> > 
> > Famous last words :)
> 
> Actually, beyond the humour, the idea that small fixes don't introduce
> regressions must be our most annoying anti-pattern.  The reality is
> that a lot of so called fixes do introduce bugs. 

And this one (commit fa731ac7ea0 upstream) is a prime example of the
kind of 'fix' that actually introduces bugs.

Commit messages which purely claim to fix a compiler warning are
*often* problematic. Although in this case there was reasonable
justification for it.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation