From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755501AbcG0KES (ORCPT ); Wed, 27 Jul 2016 06:04:18 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:36998 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754820AbcG0KEC (ORCPT ); Wed, 27 Jul 2016 06:04:02 -0400 Message-ID: <1469613816.2470.50.camel@pengutronix.de> Subject: Re: [PATCH v4 4/8] drm/mediatek: add support for Mediatek SoC MT2701 From: Philipp Zabel To: YT Shen Cc: CK Hu , dri-devel@lists.freedesktop.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , David Airlie , Matthias Brugger , Mao Huang , Bibby Hsieh , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, Sascha Hauer , yingjoe.chen@mediatek.com, emil.l.velikov@gmail.com, thierry.reding@gmail.com Date: Wed, 27 Jul 2016 12:03:36 +0200 In-Reply-To: <1469529774.4678.34.camel@mtksdaap41> References: <1468577274-6178-1-git-send-email-yt.shen@mediatek.com> <1468577274-6178-5-git-send-email-yt.shen@mediatek.com> <1468997599.11841.49.camel@mtksdaap41> <1469529774.4678.34.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 26.07.2016, 18:42 +0800 schrieb YT Shen: > Hi CK, > > On Wed, 2016-07-20 at 14:53 +0800, CK Hu wrote: > > Hi, YT: > > > > Some comments inline. > > > > On Fri, 2016-07-15 at 18:07 +0800, YT Shen wrote: > > > This patch add support for the Mediatek MT2701 DISP subsystem. > > > There is only one OVL engine in MT2701. > > > > > > Signed-off-by: YT Shen > > > --- > > > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 ++++ > > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 ++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 41 +++++++++++++++++++++++++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 7 +++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 31 ++++++++++++++++++++ > > > 6 files changed, 92 insertions(+) > > > > > > > [snip...] > > > > > > > > static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > > > + { .compatible = "mediatek,mt2701-disp-ovl", .data = (void *)MTK_DISP_OVL }, > > > { .compatible = "mediatek,mt8173-disp-ovl", .data = (void *)MTK_DISP_OVL }, > > > + { .compatible = "mediatek,mt2701-disp-rdma", .data = (void *)MTK_DISP_RDMA }, > > > { .compatible = "mediatek,mt8173-disp-rdma", .data = (void *)MTK_DISP_RDMA }, > > > + { .compatible = "mediatek,mt2701-disp-wdma", .data = (void *)MTK_DISP_WDMA }, > > > > Is WDMA different from MT8173 to MT2701. If they are the same, you need > > not to add compatible of 'mediatek,mt2701-disp-wdma' because use > > 'mediatek,mt8173-disp-wdma' is enough. > Yes, the hardware has differences, so we need add new compatible > 'mt2701-disp-wdma' It would be nice if you could add a short paragraph to the patch description about what the hardware differences are (probably just changed register layout in most cases). regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Zabel Subject: Re: [PATCH v4 4/8] drm/mediatek: add support for Mediatek SoC MT2701 Date: Wed, 27 Jul 2016 12:03:36 +0200 Message-ID: <1469613816.2470.50.camel@pengutronix.de> References: <1468577274-6178-1-git-send-email-yt.shen@mediatek.com> <1468577274-6178-5-git-send-email-yt.shen@mediatek.com> <1468997599.11841.49.camel@mtksdaap41> <1469529774.4678.34.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1469529774.4678.34.camel@mtksdaap41> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: YT Shen Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , srv_heupstream@mediatek.com, Pawel Moll , Ian Campbell , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mao Huang , Matthias Brugger , Rob Herring , linux-mediatek@lists.infradead.org, Kumar Gala , yingjoe.chen@mediatek.com, Sascha Hauer , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org QW0gRGllbnN0YWcsIGRlbiAyNi4wNy4yMDE2LCAxODo0MiArMDgwMCBzY2hyaWViIFlUIFNoZW46 Cj4gSGkgQ0ssCj4gCj4gT24gV2VkLCAyMDE2LTA3LTIwIGF0IDE0OjUzICswODAwLCBDSyBIdSB3 cm90ZToKPiA+IEhpLCBZVDoKPiA+IAo+ID4gU29tZSBjb21tZW50cyBpbmxpbmUuCj4gPiAKPiA+ IE9uIEZyaSwgMjAxNi0wNy0xNSBhdCAxODowNyArMDgwMCwgWVQgU2hlbiB3cm90ZToKPiA+ID4g VGhpcyBwYXRjaCBhZGQgc3VwcG9ydCBmb3IgdGhlIE1lZGlhdGVrIE1UMjcwMSBESVNQIHN1YnN5 c3RlbS4KPiA+ID4gVGhlcmUgaXMgb25seSBvbmUgT1ZMIGVuZ2luZSBpbiBNVDI3MDEuCj4gPiA+ IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBZVCBTaGVuIDx5dC5zaGVuQG1lZGlhdGVrLmNvbT4KPiA+ ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rpc3Bfb3ZsLmMgICAg IHwgICAgNiArKysrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Rpc3BfcmRt YS5jICAgIHwgICAgNiArKysrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2Ry bV9kZHAuYyAgICAgIHwgICA0MSArKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ID4gIGRy aXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2RkcF9jb21wLmMgfCAgICA3ICsrKysrCj4g PiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kZHBfY29tcC5oIHwgICAgMSAr Cj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2RybV9kcnYuYyAgICAgIHwgICAz MSArKysrKysrKysrKysrKysrKysrKwo+ID4gPiAgNiBmaWxlcyBjaGFuZ2VkLCA5MiBpbnNlcnRp b25zKCspCj4gPiA+IAo+ID4gCj4gPiBbc25pcC4uLl0KPiA+IAo+ID4gPiAgCj4gPiA+ICBzdGF0 aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBtdGtfZGRwX2NvbXBfZHRfaWRzW10gPSB7Cj4g PiA+ICsJeyAuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdDI3MDEtZGlzcC1vdmwiLCAgIC5kYXRh ID0gKHZvaWQgKilNVEtfRElTUF9PVkwgfSwKPiA+ID4gIAl7IC5jb21wYXRpYmxlID0gIm1lZGlh dGVrLG10ODE3My1kaXNwLW92bCIsICAgLmRhdGEgPSAodm9pZCAqKU1US19ESVNQX09WTCB9LAo+ ID4gPiArCXsgLmNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQyNzAxLWRpc3AtcmRtYSIsICAuZGF0 YSA9ICh2b2lkICopTVRLX0RJU1BfUkRNQSB9LAo+ID4gPiAgCXsgLmNvbXBhdGlibGUgPSAibWVk aWF0ZWssbXQ4MTczLWRpc3AtcmRtYSIsICAuZGF0YSA9ICh2b2lkICopTVRLX0RJU1BfUkRNQSB9 LAo+ID4gPiArCXsgLmNvbXBhdGlibGUgPSAibWVkaWF0ZWssbXQyNzAxLWRpc3Atd2RtYSIsICAu ZGF0YSA9ICh2b2lkICopTVRLX0RJU1BfV0RNQSB9LAo+ID4gCj4gPiBJcyBXRE1BIGRpZmZlcmVu dCBmcm9tIE1UODE3MyB0byBNVDI3MDEuIElmIHRoZXkgYXJlIHRoZSBzYW1lLCB5b3UgbmVlZAo+ ID4gbm90IHRvIGFkZCBjb21wYXRpYmxlIG9mICdtZWRpYXRlayxtdDI3MDEtZGlzcC13ZG1hJyBi ZWNhdXNlIHVzZQo+ID4gJ21lZGlhdGVrLG10ODE3My1kaXNwLXdkbWEnIGlzIGVub3VnaC4KPiBZ ZXMsIHRoZSBoYXJkd2FyZSBoYXMgZGlmZmVyZW5jZXMsIHNvIHdlIG5lZWQgYWRkIG5ldyBjb21w YXRpYmxlCj4gJ210MjcwMS1kaXNwLXdkbWEnCgpJdCB3b3VsZCBiZSBuaWNlIGlmIHlvdSBjb3Vs ZCBhZGQgYSBzaG9ydCBwYXJhZ3JhcGggdG8gdGhlIHBhdGNoCmRlc2NyaXB0aW9uIGFib3V0IHdo YXQgdGhlIGhhcmR3YXJlIGRpZmZlcmVuY2VzIGFyZSAocHJvYmFibHkganVzdApjaGFuZ2VkIHJl Z2lzdGVyIGxheW91dCBpbiBtb3N0IGNhc2VzKS4KCnJlZ2FyZHMKUGhpbGlwcAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: p.zabel@pengutronix.de (Philipp Zabel) Date: Wed, 27 Jul 2016 12:03:36 +0200 Subject: [PATCH v4 4/8] drm/mediatek: add support for Mediatek SoC MT2701 In-Reply-To: <1469529774.4678.34.camel@mtksdaap41> References: <1468577274-6178-1-git-send-email-yt.shen@mediatek.com> <1468577274-6178-5-git-send-email-yt.shen@mediatek.com> <1468997599.11841.49.camel@mtksdaap41> <1469529774.4678.34.camel@mtksdaap41> Message-ID: <1469613816.2470.50.camel@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Dienstag, den 26.07.2016, 18:42 +0800 schrieb YT Shen: > Hi CK, > > On Wed, 2016-07-20 at 14:53 +0800, CK Hu wrote: > > Hi, YT: > > > > Some comments inline. > > > > On Fri, 2016-07-15 at 18:07 +0800, YT Shen wrote: > > > This patch add support for the Mediatek MT2701 DISP subsystem. > > > There is only one OVL engine in MT2701. > > > > > > Signed-off-by: YT Shen > > > --- > > > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 ++++ > > > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 ++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 41 +++++++++++++++++++++++++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 7 +++++ > > > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 31 ++++++++++++++++++++ > > > 6 files changed, 92 insertions(+) > > > > > > > [snip...] > > > > > > > > static const struct of_device_id mtk_ddp_comp_dt_ids[] = { > > > + { .compatible = "mediatek,mt2701-disp-ovl", .data = (void *)MTK_DISP_OVL }, > > > { .compatible = "mediatek,mt8173-disp-ovl", .data = (void *)MTK_DISP_OVL }, > > > + { .compatible = "mediatek,mt2701-disp-rdma", .data = (void *)MTK_DISP_RDMA }, > > > { .compatible = "mediatek,mt8173-disp-rdma", .data = (void *)MTK_DISP_RDMA }, > > > + { .compatible = "mediatek,mt2701-disp-wdma", .data = (void *)MTK_DISP_WDMA }, > > > > Is WDMA different from MT8173 to MT2701. If they are the same, you need > > not to add compatible of 'mediatek,mt2701-disp-wdma' because use > > 'mediatek,mt8173-disp-wdma' is enough. > Yes, the hardware has differences, so we need add new compatible > 'mt2701-disp-wdma' It would be nice if you could add a short paragraph to the patch description about what the hardware differences are (probably just changed register layout in most cases). regards Philipp