* [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace
@ 2016-07-27 10:42 David Howells
2016-07-27 11:21 ` Stephan Mueller
2016-08-01 10:37 ` [tip:x86/urgent] x86/syscalls/64: Add " tip-bot for David Howells
0 siblings, 2 replies; 3+ messages in thread
From: David Howells @ 2016-07-27 10:42 UTC (permalink / raw)
To: x86
Cc: smueller, linux-kernel, stable, dhowells, linux-security-module,
keyrings
x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
calling sys_keyctl. The latter will work in a lot of cases, thereby hiding
the issue.
Reported-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: David Howells <dhowells@redhat.com>
cc: stable@vger.kernel.org
---
arch/x86/entry/syscalls/syscall_32.tbl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl
index 4cddd17153fb..f848572169ea 100644
--- a/arch/x86/entry/syscalls/syscall_32.tbl
+++ b/arch/x86/entry/syscalls/syscall_32.tbl
@@ -294,7 +294,7 @@
# 285 sys_setaltroot
286 i386 add_key sys_add_key
287 i386 request_key sys_request_key
-288 i386 keyctl sys_keyctl
+288 i386 keyctl sys_keyctl compat_sys_keyctl
289 i386 ioprio_set sys_ioprio_set
290 i386 ioprio_get sys_ioprio_get
291 i386 inotify_init sys_inotify_init
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace
2016-07-27 10:42 [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace David Howells
@ 2016-07-27 11:21 ` Stephan Mueller
2016-08-01 10:37 ` [tip:x86/urgent] x86/syscalls/64: Add " tip-bot for David Howells
1 sibling, 0 replies; 3+ messages in thread
From: Stephan Mueller @ 2016-07-27 11:21 UTC (permalink / raw)
To: David Howells; +Cc: x86, linux-kernel, stable, linux-security-module, keyrings
Am Mittwoch, 27. Juli 2016, 11:42:38 CEST schrieb David Howells:
Hi David,
> x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
> calling sys_keyctl. The latter will work in a lot of cases, thereby hiding
> the issue.
>
> Reported-by: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: Stephan Mueller <smueller@chronox.de>
> cc: stable@vger.kernel.org
> ---
>
> arch/x86/entry/syscalls/syscall_32.tbl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/entry/syscalls/syscall_32.tbl
> b/arch/x86/entry/syscalls/syscall_32.tbl index 4cddd17153fb..f848572169ea
> 100644
> --- a/arch/x86/entry/syscalls/syscall_32.tbl
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl
> @@ -294,7 +294,7 @@
> # 285 sys_setaltroot
> 286 i386 add_key sys_add_key
> 287 i386 request_key sys_request_key
> -288 i386 keyctl sys_keyctl
> +288 i386 keyctl sys_keyctl compat_sys_keyctl
> 289 i386 ioprio_set sys_ioprio_set
> 290 i386 ioprio_get sys_ioprio_get
> 291 i386 inotify_init sys_inotify_init
Ciao
Stephan
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/urgent] x86/syscalls/64: Add compat_sys_keyctl for 32-bit userspace
2016-07-27 10:42 [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace David Howells
2016-07-27 11:21 ` Stephan Mueller
@ 2016-08-01 10:37 ` tip-bot for David Howells
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for David Howells @ 2016-08-01 10:37 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, jpoimboe, dhowells, dvlasenk, tglx, peterz, luto, bp,
brgerst, linux-kernel, torvalds, hpa, smueller
Commit-ID: f7d665627e103e82d34306c7d3f6f46f387c0d8b
Gitweb: http://git.kernel.org/tip/f7d665627e103e82d34306c7d3f6f46f387c0d8b
Author: David Howells <dhowells@redhat.com>
AuthorDate: Wed, 27 Jul 2016 11:42:38 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 1 Aug 2016 11:31:24 +0200
x86/syscalls/64: Add compat_sys_keyctl for 32-bit userspace
x86_64 needs to use compat_sys_keyctl for 32-bit userspace rather than
calling sys_keyctl(). The latter will work in a lot of cases, thereby
hiding the issue.
Reported-by: Stephan Mueller <smueller@chronox.de>
Tested-by: Stephan Mueller <smueller@chronox.de>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: keyrings@vger.kernel.org
Cc: linux-security-module@vger.kernel.org
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/146961615805.14395.5581949237156769439.stgit@warthog.procyon.org.uk
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/entry/syscalls/syscall_32.tbl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/entry/syscalls/syscall_32.tbl b/arch/x86/entry/syscalls/syscall_32.tbl
index 4cddd17..f848572 100644
--- a/arch/x86/entry/syscalls/syscall_32.tbl
+++ b/arch/x86/entry/syscalls/syscall_32.tbl
@@ -294,7 +294,7 @@
# 285 sys_setaltroot
286 i386 add_key sys_add_key
287 i386 request_key sys_request_key
-288 i386 keyctl sys_keyctl
+288 i386 keyctl sys_keyctl compat_sys_keyctl
289 i386 ioprio_set sys_ioprio_set
290 i386 ioprio_get sys_ioprio_get
291 i386 inotify_init sys_inotify_init
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-01 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-27 10:42 [PATCH] KEYS: x86_64 needs to use compat_sys_keyctl for 32-bit userspace David Howells
2016-07-27 11:21 ` Stephan Mueller
2016-08-01 10:37 ` [tip:x86/urgent] x86/syscalls/64: Add " tip-bot for David Howells
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.