From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSMPw-0007a1-Bq for qemu-devel@nongnu.org; Wed, 27 Jul 2016 06:50:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSMPq-0006z9-FD for qemu-devel@nongnu.org; Wed, 27 Jul 2016 06:50:23 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:10107 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSMPq-0006xN-1g for qemu-devel@nongnu.org; Wed, 27 Jul 2016 06:50:18 -0400 From: Vladimir Sementsov-Ogievskiy Date: Wed, 27 Jul 2016 13:49:48 +0300 Message-Id: <1469616590-38683-2-git-send-email-vsementsov@virtuozzo.com> In-Reply-To: <1469616590-38683-1-git-send-email-vsementsov@virtuozzo.com> References: <1469616590-38683-1-git-send-email-vsementsov@virtuozzo.com> Subject: [Qemu-devel] [PATCH 1/3] blockjob: fix dead pointer in txn list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: vsementsov@virtuozzo.com, stefanha@redhat.com, famz@redhat.com, mreitz@redhat.com, jcody@redhat.com, kwolf@redhat.com, den@openvz.org Job may be freed in block_job_unref and in this case this would break transaction QLIST. Fix this by removing job from this list before unref. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockjob.c | 1 + 1 file changed, 1 insertion(+) diff --git a/blockjob.c b/blockjob.c index a5ba3be..e045091 100644 --- a/blockjob.c +++ b/blockjob.c @@ -216,6 +216,7 @@ static void block_job_completed_single(BlockJob *job) } job->cb(job->opaque, job->ret); if (job->txn) { + QLIST_REMOVE(job, txn_list); block_job_txn_unref(job->txn); } block_job_unref(job); -- 1.8.3.1