From: Wei Dai <wei.dai@intel.com>
To: dev@dpdk.org
Cc: Wei Dai <wei.dai@intel.com>
Subject: [PATCH v3 3/4] eal: fix tail blank check in --lcores argument
Date: Wed, 27 Jul 2016 19:25:56 +0800 [thread overview]
Message-ID: <1469618756-144196-1-git-send-email-wei.dai@intel.com> (raw)
In-Reply-To: <1469526749-19698-1-git-send-email-wei.dai@intel.com>
the tail blank after a group of lcore or cpu set
will make check of its end character fail.
for example: --lcores '(0-3)@(0-3) ,(4-5)@(4-5)',
the next character after cpu set (0-3) is not ','
or '\0', which fail the check in eal_parse_lcores( ).
Fixes: 53e54bf81700 ("eal: new option --lcores for cpu assignment")
Signed-off-by: Wei Dai <wei.dai@intel.com>
---
lib/librte_eal/common/eal_common_options.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index 217d08b..1a1bab3 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -530,6 +530,13 @@ eal_parse_set(const char *input, uint16_t set[], unsigned num)
str = end + 1;
} while (*end != '\0' && *end != ')');
+ /*
+ * to avoid failure that tail blank makes end character check fail
+ * in eal_parse_lcores( )
+ */
+ while (isblank(*str))
+ str++;
+
return str - input;
}
--
2.5.5
next prev parent reply other threads:[~2016-07-27 11:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 6:03 [PATCH] eal: fix parsing of argument of option --lcores Wei Dai
2016-07-21 14:21 ` Thomas Monjalon
2016-07-21 20:44 ` bynes adam
2016-07-27 10:06 ` Dai, Wei
2016-07-26 9:52 ` [PATCH v2 1/2] eal: remove redundant codes to parse --lcores Wei Dai
2016-07-26 11:51 ` Ananyev, Konstantin
2016-07-26 17:36 ` Adam Bynes
2016-07-27 9:15 ` Dai, Wei
2016-07-27 11:22 ` [PATCH v3 1/4] " Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-27 11:25 ` Wei Dai [this message]
2016-07-28 15:18 ` [PATCH v3 3/4] eal: fix tail blank check in --lcores argument Ferruh Yigit
2016-07-26 9:52 ` [PATCH v2 2/2] eal: fix parsing of eal option --lcores Wei Dai
2016-07-27 11:23 ` [PATCH v3 2/4] " Wei Dai
2016-07-28 15:18 ` Ferruh Yigit
2016-07-27 11:27 ` [PATCH v3 4/4] eal: fix end character check in --lcores argument Wei Dai
2016-07-28 15:26 ` Ferruh Yigit
2016-07-28 16:05 ` Thomas Monjalon
2016-08-02 8:22 ` Dai, Wei
2016-08-02 10:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469618756-144196-1-git-send-email-wei.dai@intel.com \
--to=wei.dai@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.