From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752916AbcG2TxX (ORCPT ); Fri, 29 Jul 2016 15:53:23 -0400 Received: from smtprelay0165.hostedemail.com ([216.40.44.165]:51456 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751557AbcG2TxO (ORCPT ); Fri, 29 Jul 2016 15:53:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3866:3867:3870:4321:4362:4605:5007:10004:10400:10848:11026:11658:11783:11914:12043:12438:12517:12519:12740:13069:13311:13357:13439:13894:14659:14721:21080:30003:30025:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: paste12_9067b966beb5b X-Filterd-Recvd-Size: 1714 Message-ID: <1469821991.3998.86.camel@perches.com> Subject: Re: [PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer From: Joe Perches To: Nicolas Iooss , Andrew Morton , Andrey Ryabinin Cc: linux-kernel@vger.kernel.org Date: Fri, 29 Jul 2016 12:53:11 -0700 In-Reply-To: <20160729111053.21306-1-nicolas.iooss_linux@m4x.org> References: <20160729111053.21306-1-nicolas.iooss_linux@m4x.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-07-29 at 13:10 +0200, Nicolas Iooss wrote: > handle_object_size_mismatch() used %pk to format a kernel pointer in > pr_err().  This seems to be a misspelling for %pK. Thanks > diff --git a/lib/ubsan.c b/lib/ubsan.c [] > @@ -308,7 +308,7 @@ static void handle_object_size_mismatch(struct > type_mismatch_data *data, >   return; >   >   ubsan_prologue(&data->location, &flags); > - pr_err("%s address %pk with insufficient space\n", > + pr_err("%s address %pK with insufficient space\n", >   type_check_kinds[data->type_check_kind], >   (void *) ptr); >   pr_err("for an object of type %s\n", data->type->type_name); Maybe change this to a single output line: pr_err("%s address %pK with insufficient space for an object of type %s\n", type_check_kinds[data->type_check_kind], (void *)ptr, data->type->type_name);