[PATCH 01/18] multipath-tools: add KOVE/XPD to hwtable

[PATCH 01/18] multipath-tools: add KOVE/XPD to hwtable

[Xose Vazquez Perez]

Info provided directly by the manufacturer - http://kove.net/xpd :

.vendor        = "KOVE",
.product       = "XPD",
.features      = DEFAULT_FEATURES,
.hwhandler     = DEFAULT_HWHANDLER,
.selector      = "round-robin 0",
.pgpolicy      = MULTIBUS,
.pgfailback    = -FAILBACK_IMMEDIATE,
.rr_weight     = RR_WEIGHT_NONE,
.no_path_retry = DEFAULT_NO_PATH_RETRY,
.minio         = DEFAULT_MINIO,
.minio_rq      = DEFAULT_MINIO_RQ,
.checker_name  = DIRECTIO,
.prio_name     = DEFAULT_PRIO,
.prio_args     = NULL,

Cc: Nick Russo <nick.russo@kove.net>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 1efaeee..3e22714 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -771,6 +771,16 @@ static struct hwentry default_hw[] = {
 		.pgfailback    = 30,
 		.minio         = 128,
 	},
+	/*
+	 * Kove
+	 */
+	{
+		.vendor        = "KOVE",
+		.product       = "XPD",
+		.selector      = "round-robin 0",
+		.pgpolicy      = MULTIBUS,
+		.no_path_retry = DEFAULT_NO_PATH_RETRY,
+	},
 #if 0
 	/*
 	 * Copy this TEMPLATE to add new hardware.
-- 
2.7.4

[PATCH 02/18] multipath-tools: Remove ONTAP IBM Nseries from hwtable

[Xose Vazquez Perez]

Originally from Martin George <marting@netapp.com>

He wrote:
"Even earlier, the NetApp IBM Nseries product line never used a
VID/PID of "IBM" & "Nseries" respectively. Instead, it always
used the same VID/PID of "NETAPP" & "LUN" itself, similar to the
ONTAP product line. So this piece of code was redundant from the
beginning itself."

Cc: Hannes Reinecke <hare@suse.de>
Cc: Martin George <marting@netapp.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 3e22714..73ba4ee 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -508,14 +508,6 @@ static struct hwentry default_hw[] = {
 		.dev_loss      = MAX_DEV_LOSS_TMO,
 		.prio_name     = PRIO_ONTAP,
 	},
-	{
-		/* IBM NSeries */
-		.vendor        = "IBM",
-		.product       = "Nseries.*",
-		.features      = "1 queue_if_no_path",
-		.minio         = 128,
-		.prio_name     = PRIO_ONTAP,
-	},
 	/* LSI/Engenio/NetApp RDAC family
 	 *
 	 * Maintainer : Sean Stewart
-- 
2.7.4

[PATCH 03/18] multipath-tools: reorganize NetApp devices

[Xose Vazquez Perez]

Cc: Martin George <marting@netapp.com>
Cc: Sean Stewart <sean.stewart@netapp.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 73ba4ee..3952b42 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -494,12 +494,15 @@ static struct hwentry default_hw[] = {
 		.prio_name     = PRIO_ALUA,
 	},
 	/*
-	 * NetApp ONTAP family
-	 *
-	 * Maintainer : Martin George
-	 * Mail : marting@netapp.com
+	 * NetApp
 	 */
 	{
+		/*
+		 * ONTAP family
+		 *
+		 * Maintainer : Martin George
+		 * Mail : marting@netapp.com
+		 */
 		.vendor        = "NETAPP",
 		.product       = "LUN.*",
 		.features      = "3 queue_if_no_path pg_init_retries 50",
@@ -508,12 +511,12 @@ static struct hwentry default_hw[] = {
 		.dev_loss      = MAX_DEV_LOSS_TMO,
 		.prio_name     = PRIO_ONTAP,
 	},
-	/* LSI/Engenio/NetApp RDAC family
-	 *
-	 * Maintainer : Sean Stewart
-	 * Mail : sean.stewart@netapp.com
-	 */
 	{
+		/* LSI/Engenio/NetApp RDAC family
+		 *
+		 * Maintainer : Sean Stewart
+		 * Mail : sean.stewart@netapp.com
+		 */
 		.vendor        = "(NETAPP|LSI|ENGENIO)",
 		.product       = "INF-01-00",
 		.bl_product    = "Universal Xport",
-- 
2.7.4

[PATCH 04/18] multipath-tools: add NetApp/SolidFir to hwtable

[Xose Vazquez Perez]

Based on info provided directly by the manufacturer:
http://www.solidfire.com/
http://www.netapp.com/us/products/storage-systems/solidfire/

Redhat 7+:
vendor "SolidFir"
product "SSD SAN"
path_grouping_policy multibus
path_checker tur
hardware_handler "0"
failback immediate
rr_weight uniform
rr_min_io 10
rr_min_io_rq 10
features "0"
no_path_retry 24
prio const

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 3952b42..bd0bd8c 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -526,6 +526,15 @@ static struct hwentry default_hw[] = {
 		.checker_name  = RDAC,
 		.prio_name     = PRIO_RDAC,
 	},
+	{
+		/* SolidFir */
+		.vendor        = "SolidFir",
+		.product       = "SSD SAN",
+		.pgpolicy      = MULTIBUS,
+		.no_path_retry = 24,
+		.minio         = 10,
+		.minio_rq      = 10,
+	},
 	/*
 	 * Nexenta
 	 *
-- 
2.7.4

[PATCH 05/18] multipath-tools: add Nimble to hwtable

[Xose Vazquez Perez]

Based on documentation provided by the manufacturer:
http://www.nimblestorage.com/bpg_nimble_storage_linux_fibre_channel.pdf

vendor "Nimble"
product "Server"
prio "alua"
path_grouping_policy group_by_prio
path_checker tur
hardware_handler "1 alua"
features "1 queue_if_no_path"
rr_weight priorities
rr_min_io_rq 20
failback 10
path_selector "round-robin 0"
dev_loss_tmo infinity
fast_io_fail_tmo 1

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index bd0bd8c..673148a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -785,6 +785,22 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = MULTIBUS,
 		.no_path_retry = DEFAULT_NO_PATH_RETRY,
 	},
+	/*
+	 * Nimble Storage
+	 */
+	{
+		.vendor        = "Nimble",
+		.product       = "Server",
+		.prio_name     = PRIO_ALUA,
+		.hwhandler     = "1 alua",
+		.features      = "1 queue_if_no_path",
+		.rr_weight     = RR_WEIGHT_PRIO,
+		.minio_rq      = 20,
+		.pgfailback    = 10,
+		.selector      = "round-robin 0",
+		.dev_loss      = MAX_DEV_LOSS_TMO,
+		.fast_io_fail  = 1,
+	},
 #if 0
 	/*
 	 * Copy this TEMPLATE to add new hardware.
-- 
2.7.4

[PATCH 06/18] multipath-tools: add IBM/FlashSystem to hwtable

[Xose Vazquez Perez]

Based on documentation of the manufacturer:

- FlashSystem 820 and FlashSystem 900:
   http://www.redbooks.ibm.com/redbooks/pdfs/sg248271.pdf

vendor                  "IBM"
product                 "FlashSystem-9840"
path_selector           "queue-length 0"        # Linux 6.2, if available
path_grouping_policy    multibus
path_checker            tur
rr_min_io_rq            4                       # Linux 6.x
rr_weight               uniform
no_path_retry           fail
failback                immediate
dev_loss_tmo            300
fast_io_fail_tmo        25

- FlashSystem 710/810/720/820:
   http://www.ibm.com/support/knowledgecenter/ST2NVR/com.ibm.storage.flashsystem.1.1.doc/rsaa6.pdf

vendor                  "IBM"
product                 "FlashSystem"
path_selector           "round-robin 0"         # Linux 5, Linux 6
path_grouping_policy    multibus
path_checker            tur
rr_min_io_rq            4                       # 6.x,FlashSystem 720/820
rr_min_io_              4                       # 5.x,FlashSystem 720/820
rr_weight               uniform
no_path_retry           fail
failback                immediate
dev_loss_tmo            300
fast_io_fail_tmo        25

Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 673148a..6ea20b2 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -465,6 +465,18 @@ static struct hwentry default_hw[] = {
 		.pgfailback    = 15,
 		.minio         = 15,
 	},
+	{
+		/* FlashSystem */
+		.vendor        = "IBM",
+		.product       = "FlashSystem",
+		.selector      = "queue-length 0",
+		.pgpolicy      = MULTIBUS,
+		.minio         = 4,
+		.minio_rq      = 4,
+		.no_path_retry = NO_PATH_RETRY_FAIL,
+		.dev_loss      = 300,
+		.fast_io_fail  = 25,
+	},
 	/*
 	 * IBM Power Virtual SCSI Devices
 	 *
-- 
2.7.4

[PATCH 07/18] multipath-tools: add EMC/Celerra to hwtable

[Xose Vazquez Perez]

Based on documentation of the manufacturer:
http://www.emc.com/collateral/TechnicalDocument/docu5128.pdf

vendor "EMC"
product "Celerra"
path_grouping_policy "multibus"
path_checker "tur"
no_path_retry "30"

Cc: Edward Goggin <egoggin@emc.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 6ea20b2..d1e9c81 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -186,6 +186,12 @@ static struct hwentry default_hw[] = {
 		.pgpolicy      = MULTIBUS,
 		.pgfailback    = FAILBACK_UNDEF,
 	},
+	{
+		.vendor        = "EMC",
+		.product       = "Celerra",
+		.pgpolicy      = MULTIBUS,
+		.no_path_retry = 30,
+	},
 	/*
 	 * DELL
 	 */
-- 
2.7.4

[PATCH 08/18] multipath-tools: add FUJITSU/ETERNUS 2000/4000/8000 to hwtable

[Xose Vazquez Perez]

Based on documentation provided by the manufacturer:
http://storage-system.fujitsu.com/global/manual/diskarray/pdf/p3am-3192-en.pdf

For SUSE Linux Enterprise Server 11

vendor                  "FUJITSU"
product                 "E[248]000"
prio                    alua
path_grouping_policy    group_by_prio
path_selector           "round-robin 0"
failback                immediate
no_path_retry           10

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index d1e9c81..1845881 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -257,6 +257,13 @@ static struct hwentry default_hw[] = {
 		.product       = "FC2502",
 		.pgfailback    = FAILBACK_UNDEF,
 	},
+	{
+		.vendor        = "FUJITSU",
+		.product       = "E[248]000",
+		.prio_name     = PRIO_ALUA,
+		.no_path_retry = 10,
+		.selector      = "round-robin 0",
+	},
 	/*
 	 * Hitachi
 	 *
-- 
2.7.4

[PATCH 09/18] multipath-tools: add VIOLIN/ "SAN ARRAY" and "SAN ARRAY ALUA" to hwtable

[Xose Vazquez Perez]

Based on documentation provided by the manufacturer:
https://drive.google.com/open?id=0B_B6YmEmO7cDQlMzc1BsaUxZRVU

* For "SAN ARRAY ALUA":

- Red Hat Enterprise Linux 6.x:
vendor "VIOLIN"
product "SAN ARRAY ALUA"
path_grouping_policy group_by_prio
getuid_callout "/lib/udev/scsi_id --whitelisted --replace- whitespace --page=0x80 --device=/dev/%n"
prio "alua"
path_checker tur
path_selector "round-robin 0"
hardware_handler "1 alua"
failback immediate
rr_weight uniform
no_path_retry fail
rr_min_io_rq 4

- SUSE Enterprise Linux 11 SP3:
vendor "VIOLIN"
product "SAN ARRAY ALUA"
path_grouping_policy group_by_prio
prio "alua"
path_checker tur
path_selector "round-robin 0"
hardware_handler "0"
failback immediate
no_path_retry 100
detect_prio yes

* For "SAN ARRAY":

- Red Hat Enterprise Linux 6.x:
vendor "VIOLIN"
product "SAN ARRAY"
path_grouping_policy group_by_serial
getuid_callout "/lib/udev/scsi_id --whitelisted -- replace-whitespace --page=0x80 --device=/dev/%n"
path_checker tur
path_selector "round-robin 0"
hardware_handler "0"
failback immediate
rr_weight uniform
no_path_retry fail
rr_min_io_rq 4

- SUSE Enterprise Linux 11 SP3:
vendor "VIOLIN"
product "SAN ARRAY"
path_grouping_policy group_by_serial
path_checker tur
path_selector "round-robin 0"
hardware_handler "0"
failback immediate
rr_weight uniform
no_path_retry 100

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 1845881..4d5717a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -772,6 +772,21 @@ static struct hwentry default_hw[] = {
 		.features      = "1 queue_if_no_path",
 		.no_path_retry = 300,
 	},
+	{
+		.vendor        = "VIOLIN",
+		.product       = "SAN ARRAY",
+		.pgpolicy      = GROUP_BY_SERIAL,
+		.selector      = "round-robin 0",
+		.no_path_retry = 100,
+	},
+	{
+		.vendor        = "VIOLIN",
+		.product       = "SAN ARRAY ALUA",
+		.prio_name     = PRIO_ALUA,
+		.selector      = "round-robin 0",
+		.hwhandler     = "1 alua",
+		.no_path_retry = 100,
+	},
 	/*
 	 * Infinidat
 	 */
-- 
2.7.4

[PATCH 10/18] multipath-tools: add Nexsan E-Series and SATABeast/SATABoy to hwtable

[Xose Vazquez Perez]

Based on documentation provided by the manufacturer:
https://drive.google.com/file/d/0B_B6YmEmO7cDeGRXeG85MXFVMEU

Redhat 6:
vendor                  "NEXSAN "
product                 "NXS-B0.*|SATAB.*"
getuid_callout          "/lib/udev/scsi_id --whitelisted --device=/dev/%n"
path_grouping_policy    group_by_prio
prio                    alua
path_checker            directio
path_selector           "round-robin 0"
hardware_handler        "0"
rr_weight               priorities
no_path_retry           15
failback                immediate

SUSE 11 (including OpenSUSE):
vendor                  "NEXSAN "
product                 "NXS-B0.*|SATAB.*"
getuid_callout          "/lib/udev/scsi_id --whitelisted -g -u -d /dev/%n"
path_grouping_policy    group_by_prio
prio                    alua
path_checker            directio
path_selector           "round-robin 0"
hardware_handler        "0"
rr_weight               priorities
no_path_retry           15
failback                immediate

Debian Wheezy:
vendor                  "NEXSAN "
product                 "NXS-B0.*|SATAB.*"
path_grouping_policy    group_by_prio
prio                    alua
path_checker            directio
path_selector           "round-robin 0"
hardware_handler        "1 alua"
rr_weight               priorities
no_path_retry           5
failback                immediate

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 4d5717a..45a6332 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -841,6 +841,18 @@ static struct hwentry default_hw[] = {
 		.dev_loss      = MAX_DEV_LOSS_TMO,
 		.fast_io_fail  = 1,
 	},
+	/*
+	 * Nexsan
+	 */
+	{
+		.vendor        = "NEXSAN",
+		.product       = "(NXS-B0.*|SATAB.*)",
+		.selector      = "round-robin 0",
+		.prio_name     = PRIO_ALUA,
+		.hwhandler     = "1 alua",
+		.rr_weight     = RR_WEIGHT_PRIO,
+		.no_path_retry = 15,
+	},
 #if 0
 	/*
 	 * Copy this TEMPLATE to add new hardware.
-- 
2.7.4

[PATCH 11/18] multipath-tools: add Xiotech ISE 1400/2400/3400/3401 to hwtable

[Xose Vazquez Perez]

Based on documentation provided by the manufacturer:
https://drive.google.com/file/d/0B_B6YmEmO7cDc201a3ZlcmFvUmM

For the latest 2 updates of Redhat 6.x
vendor                  "XIOTECH"
product                 "ISE([12]400|340[01])"
path_grouping_policy    multibus
prio_callout            “none”
path_checker            tur
path_selector           “round-robin 0”
failback                immediate
dev_loss_tmo            600
fast_io_fail_tmo        5
no_path_retry           12
rr_min_io_rq            1

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 45a6332..3b67030 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -853,6 +853,16 @@ static struct hwentry default_hw[] = {
 		.rr_weight     = RR_WEIGHT_PRIO,
 		.no_path_retry = 15,
 	},
+	/*
+	 * Xiotech
+	 */
+	{
+		.vendor        = "XIOTECH",
+		.product       = "ISE([12]400|340[01])",
+		.selector      = "round-robin 0",
+		.pgpolicy      = MULTIBUS,
+		.no_path_retry = 12,
+	},
 #if 0
 	/*
 	 * Copy this TEMPLATE to add new hardware.
-- 
2.7.4

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

[PATCH 12/18] multipath-tools: put a comment in the correct place

[Xose Vazquez Perez]

FibreCAT S80 was out of the braces.

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 3b67030..822f7ff 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -251,8 +251,8 @@ static struct hwentry default_hw[] = {
 		.no_path_retry = 10,
 		.prio_name     = PRIO_ALUA,
 	},
-		/* FibreCAT S80 */
 	{
+		/* FibreCAT S80 */
 		.vendor        = "EUROLOGC",
 		.product       = "FC2502",
 		.pgfailback    = FAILBACK_UNDEF,
-- 
2.7.4

[PATCH 13/18] multipath-tools: delete nearly all attribute of last member(NULL) in hwtable

[Xose Vazquez Perez]

They are "useless".
Leave only mandatory attributes.

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 822f7ff..ebad919 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -910,29 +910,6 @@ static struct hwentry default_hw[] = {
 	{
 		.vendor        = NULL,
 		.product       = NULL,
-		.revision      = NULL,
-		.bl_product    = NULL,
-		.pgpolicy      = 0,
-		.uid_attribute = NULL,
-		.selector      = NULL,
-		.checker_name  = NULL,
-		.features      = NULL,
-		.hwhandler     = NULL,
-		.prio_name     = NULL,
-		.prio_args     = NULL,
-		.pgfailback    = 0,
-		.rr_weight     = 0,
-		.no_path_retry = 0,
-		.minio         = 0,
-		.minio_rq      = 0,
-		.flush_on_last_del = 0,
-		.fast_io_fail  = 0,
-		.dev_loss      = 0,
-		.retain_hwhandler = NULL,
-		.detect_prio   = NULL,
-		.deferred_remove = NULL,
-		.delay_watch_checks = 0,
-		.delay_wait_checks = 0,
 	},
 };
 
-- 
2.7.4

[PATCH 14/18] multipath-tools: change path grouping policy for EUROLOGC/FC2502

[Xose Vazquez Perez]

No prio defined and .pgpolicy=GROUP_BY_PRIO are an impossible combination.

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index ebad919..728680a 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -256,6 +256,7 @@ static struct hwentry default_hw[] = {
 		.vendor        = "EUROLOGC",
 		.product       = "FC2502",
 		.pgfailback    = FAILBACK_UNDEF,
+		.pgpolicy      = MULTIBUS,
 	},
 	{
 		.vendor        = "FUJITSU",
-- 
2.7.4

[PATCH 15/18] multipath-tools: add official name to Huawei devices

[Xose Vazquez Perez]

from http://www.t10.org/ftp/t10/vendorid.txt
Its official name is: "HUASY"

Just in case.

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 728680a..a9e65fc 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -755,7 +755,7 @@ static struct hwentry default_hw[] = {
 	 * Huawei
 	 */
 	{
-		.vendor        = "HUAWEI",
+		.vendor        = "(HUAWEI|HUASY)",
 		.product       = "XSG1",
 		.pgpolicy      = MULTIBUS,
 	},
-- 
2.7.4

[PATCH 16/18] multipath-tools: Use ALUA for HP 3PAR

[Xose Vazquez Perez]

Original patch from Hannes Reinecke <hare@suse.de>:

 		.vendor        = "3PARdata",
 		.product       = "VV",
 		.features      = DEFAULT_FEATURES,
-		.hwhandler     = DEFAULT_HWHANDLER,
-		.pgpolicy      = MULTIBUS,
-		.pgfailback    = FAILBACK_UNDEF,
+		.hwhandler     = "1 alua",
+		.pgpolicy      = GROUP_BY_PRIO,
+		.pgfailback    = -FAILBACK_IMMEDIATE,
 		.rr_weight     = RR_WEIGHT_NONE,
-		.no_path_retry = NO_PATH_RETRY_UNDEF,
-		.checker_name  = DEFAULT_CHECKER,
-		.prio_name     = DEFAULT_PRIO,
+		.no_path_retry = 18,
+		.checker_name  = TUR,
+		.prio_name     = PRIO_ALUA,
 		.prio_args     = NULL,

Sebastian was not convinced with this change, full thread: https://marc.info/?t=146175638600002
But there is no automatic way to change .pgpolicy from MULTIBUS to GROUP_BY_PRIO.
So we should stick to latest manufacturer's recommendations:

"With 3PAR OS 3.1.3 or later, Hewlett Packard Enterprise recommends host persona
2 (ALUA). Advantages of Host Persona 2 (ALUA):
o A single VV migration can be performed by using 3PAR Peer Motion if the
  source and destination 3PAR StoreServ Storage array uses host persona 2
  (required by the 3PAR OS).
o Host persona 2 is required for Storage Federation (required by the 3PAR OS).

*3PAR plans to support additional features in later HPE 3PAR OS releases only at
  Generic-ALUA Persona 2

Persona_Number Persona_Name   Host_Operating_System       Additional_Capabilities
============== ============== ==========================  =======================
1              Generic        Linux, Windows and Solaris  UARepLun, SESLun
2              Generic-ALUA   Linux, Windows and Solaris  UARepLun, SESLun, ALUA
6              Generic-Legacy Linux, Windows and Solaris  None

o UARepLun -  Notifies the host of newly exported VLUNs and should trigger a LUN
              discovery request on the host, making the VLUN automatically
              available on format.
o SESLun   -  Enables iSCSI Enclosure Services (SES) LUN ID 254 for Host Explorer
              agent support.
o ALUA     -  Enables the Asymmetric Logical Unit Access (ALUA) command and
              asymmetric state change unit attention when path counts change
              due to adding or removing ports in the host's definition."

HPE 3PAR docs: http://www.hpe.com/info/storage/docs

Cc: Sebastian Herbszt <herbszt@gmx.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index a9e65fc..e4c7b7d 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -42,8 +42,9 @@ static struct hwentry default_hw[] = {
 	{
 		.vendor        = "3PARdata",
 		.product       = "VV",
-		.pgpolicy      = MULTIBUS,
-		.pgfailback    = FAILBACK_UNDEF,
+		.hwhandler     = "1 alua",
+		.prio_name     = PRIO_ALUA,
+		.no_path_retry = 18,
 	},
 	{
 		.vendor        = "DEC",
-- 
2.7.4

[PATCH 17/18] multipath-tools: add HPE StoreVirtual P4000 family to hwtable

[Xose Vazquez Perez]

No official documentation. Based on field-tested configuration:
https://www.citrix.com/blogs/2013/10/02/hp-p4000-multipath-config-file/

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index e4c7b7d..51e115d 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -139,6 +139,14 @@ static struct hwentry default_hw[] = {
 		.minio         = 100,
 		.prio_name     = PRIO_ALUA,
 	},
+		/* StoreVirtual P4000 family */
+	{
+		.vendor        = "LEFTHAND",
+		.product       = "^(P4000.*|iSCSIDisk)",
+		.no_path_retry = 18,
+		.minio         = 100,
+		.prio_name     = PRIO_ALUA,
+	},
 	/*
 	 * DataDirect Networks
 	 */
-- 
2.7.4

[PATCH 18/18] multipath-tools: add Oracle FS to hwtable

[Xose Vazquez Perez]

Based on an auto-generated template from Oracle FS Path Manager 4.0:
        vendor                  "^Oracle(  )?$"
        product                 "^Oracle FS"
        path_selector           "round-robin 0"
        path_grouping_policy    group_by_prio
        prio                    oraclefspm
        path_checker            oraclefspm
        failback                immediate

Oracle is using a customized checker and prioritizer, and running
a daemon.
.
├── etc
│   └── init.d
│       └── oracle-fspmd
└── opt
    └── oracle
        └── fspm
            ├── bin
            │   ├── fspmd
            │   └── fspm-update-mpt
            └── plugins
                ├── libcheckoraclefspm.so
                ├── libpriooraclefspm.so
                └── mpath_prio_oraclefspm

Cc: Srinivasan Ramani <srinivas.ramani@oracle.com>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/hwtable.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
index 51e115d..fe4a51f 100644
--- a/libmultipath/hwtable.c
+++ b/libmultipath/hwtable.c
@@ -625,17 +625,23 @@ static struct hwentry default_hw[] = {
 	/*
 	 * Oracle
 	 */
-	{
 		/*
-		 * Pillar Data
+		 * Pillar Data / Oracle FS
 		 *
 		 * Maintainer : Srinivasan Ramani
 		 * Mail : srinivas.ramani@oracle.com
 		 */
+	{
 		.vendor        = "Pillar",
 		.product       = "Axiom.*",
+		.prio_name     = PRIO_ALUA,
 		.pgfailback    = FAILBACK_UNDEF,
+	},
+	{
+		.vendor        = "^Oracle",
+		.product       = "^Oracle FS.*",
 		.prio_name     = PRIO_ALUA,
+		.selector      = "round-robin 0",
 	},
 		/* StorageTek */
 	{
-- 
2.7.4

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [PATCH 16/18] multipath-tools: Use ALUA for HP 3PAR

[Sebastian Herbszt]

Xose Vazquez Perez wrote:
> Original patch from Hannes Reinecke <hare@suse.de>:
> 
> .vendor = "3PARdata",
> .product = "VV",
> .features = DEFAULT_FEATURES,
> - .hwhandler = DEFAULT_HWHANDLER,
> - .pgpolicy = MULTIBUS,
> - .pgfailback = FAILBACK_UNDEF,
> + .hwhandler = "1 alua",
> + .pgpolicy = GROUP_BY_PRIO,
> + .pgfailback = -FAILBACK_IMMEDIATE,
> .rr_weight = RR_WEIGHT_NONE,
> - .no_path_retry = NO_PATH_RETRY_UNDEF,
> - .checker_name = DEFAULT_CHECKER,
> - .prio_name = DEFAULT_PRIO,
> + .no_path_retry = 18,
> + .checker_name = TUR,
> + .prio_name = PRIO_ALUA,
> .prio_args = NULL,
> 
> Sebastian was not convinced with this change, full thread: https://marc.info/?t=146175638600002
> But there is no automatic way to change .pgpolicy from MULTIBUS to GROUP_BY_PRIO.
> So we should stick to latest manufacturer's recommendations:

So 'retain_attached_hw_handler' suggested by Hannes doesn't work?

Sebastian

Re: [PATCH 16/18] multipath-tools: Use ALUA for HP 3PAR

[Xose Vazquez Perez]

On 07/31/2016 12:14 AM, Sebastian Herbszt wrote:

> Xose Vazquez Perez wrote:

>> Sebastian was not convinced with this change, full thread: https://marc.info/?t=146175638600002
>> But there is no automatic way to change .pgpolicy from MULTIBUS to GROUP_BY_PRIO.
>> So we should stick to latest manufacturer's recommendations:

> So 'retain_attached_hw_handler' suggested by Hannes doesn't work?

No. It's related to hardware_handler, "alua" in this case.

Re: [PATCH 01/18] multipath-tools: add KOVE/XPD to hwtable

[Christophe Varoqui]

[-- Attachment #1.1: Type: text/plain, Size: 1691 bytes --]

Sorry this patchset will also need rebasing.
Thanks.

On Sat, Jul 30, 2016 at 2:28 AM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> Info provided directly by the manufacturer - http://kove.net/xpd :
>
> .vendor        = "KOVE",
> .product       = "XPD",
> .features      = DEFAULT_FEATURES,
> .hwhandler     = DEFAULT_HWHANDLER,
> .selector      = "round-robin 0",
> .pgpolicy      = MULTIBUS,
> .pgfailback    = -FAILBACK_IMMEDIATE,
> .rr_weight     = RR_WEIGHT_NONE,
> .no_path_retry = DEFAULT_NO_PATH_RETRY,
> .minio         = DEFAULT_MINIO,
> .minio_rq      = DEFAULT_MINIO_RQ,
> .checker_name  = DIRECTIO,
> .prio_name     = DEFAULT_PRIO,
> .prio_args     = NULL,
>
> Cc: Nick Russo <nick.russo@kove.net>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 1efaeee..3e22714 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -771,6 +771,16 @@ static struct hwentry default_hw[] = {
>                 .pgfailback    = 30,
>                 .minio         = 128,
>         },
> +       /*
> +        * Kove
> +        */
> +       {
> +               .vendor        = "KOVE",
> +               .product       = "XPD",
> +               .selector      = "round-robin 0",
> +               .pgpolicy      = MULTIBUS,
> +               .no_path_retry = DEFAULT_NO_PATH_RETRY,
> +       },
>  #if 0
>         /*
>          * Copy this TEMPLATE to add new hardware.
> --
> 2.7.4
>
>

[-- Attachment #1.2: Type: text/html, Size: 2686 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 16/18] multipath-tools: Use ALUA for HP 3PAR

[Sebastian Herbszt]

Xose Vazquez Perez wrote:
> On 07/31/2016 12:14 AM, Sebastian Herbszt wrote:
> 
> > Xose Vazquez Perez wrote:
> 
> >> Sebastian was not convinced with this change, full thread: https://marc.info/?t=146175638600002
> >> But there is no automatic way to change .pgpolicy from MULTIBUS to GROUP_BY_PRIO.
> >> So we should stick to latest manufacturer's recommendations:
> 
> > So 'retain_attached_hw_handler' suggested by Hannes doesn't work?
> 
> No. It's related to hardware_handler, "alua" in this case.

So how does the output of 'multipath -ll' looks like for persona 1 and 2
with and without 'retain_attached_hw_handler'?

Sebastian

Re: [PATCH 08/18] multipath-tools: add FUJITSU/ETERNUS 2000/4000/8000 to hwtable

[Sebastian Herbszt]

Xose Vazquez Perez wrote:
> Based on documentation provided by the manufacturer:
> http://storage-system.fujitsu.com/global/manual/diskarray/pdf/p3am-3192-en.pdf
> 
> For SUSE Linux Enterprise Server 11
> 
> vendor                  "FUJITSU"
> product                 "E[248]000"
> prio                    alua
> path_grouping_policy    group_by_prio
> path_selector           "round-robin 0"
> failback                immediate
> no_path_retry           10
> 
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/hwtable.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index d1e9c81..1845881 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -257,6 +257,13 @@ static struct hwentry default_hw[] = {
>  		.product       = "FC2502",
>  		.pgfailback    = FAILBACK_UNDEF,
>  	},
> +	{
> +		.vendor        = "FUJITSU",
> +		.product       = "E[248]000",
> +		.prio_name     = PRIO_ALUA,
> +		.no_path_retry = 10,
> +		.selector      = "round-robin 0",
> +	},
>  	/*
>  	 * Hitachi
>  	 *

How about dropping the path selector and merging
the entry with ETERNUS DX?

Sebastian

Re: [PATCH 16/18] multipath-tools: Use ALUA for HP 3PAR

[Xose Vazquez Perez]

On 07/31/2016 09:06 PM, Sebastian Herbszt wrote:

> Xose Vazquez Perez wrote:
>>
>> No. It's related to hardware_handler, "alua" in this case.
> 
> So how does the output of 'multipath -ll' looks like for persona 1 and 2
> with and without 'retain_attached_hw_handler'?

retain_attached_hw_handler is innocuous.
The paths grouping policy is controlled by the "path_grouping_policy" keyword,
multibus vs. group_by_prio. See man page.


Persona 1 and 2 basically is the same, but:

Persona 1:	path_grouping_policy = multibus
		failback = manual
		prio = const

Persona 2:	path_grouping_policy = group_by_prio
		failback = immediate
		prio = alua				(this is irrelevant, alua-prio is autodetected)
		hardware_handler= "1 alua"		(this is irrelevant, all hardware handlers are autodetected)

With 3PAR-OS 3.1.3, or later, you should use "Persona 2"

Re: [PATCH 16/18] multipath-tools: Use ALUA for HP 3PAR

[Sebastian Herbszt]

Xose Vazquez Perez wrote:
> On 07/31/2016 09:06 PM, Sebastian Herbszt wrote:
> 
> > Xose Vazquez Perez wrote:
> >>
> >> No. It's related to hardware_handler, "alua" in this case.
> > 
> > So how does the output of 'multipath -ll' looks like for persona 1 and 2
> > with and without 'retain_attached_hw_handler'?
> 
> retain_attached_hw_handler is innocuous.
> The paths grouping policy is controlled by the "path_grouping_policy" keyword,
> multibus vs. group_by_prio. See man page.

multibus should equal

path_grouping_policy = group_by_prio
prio = const

> Persona 1 and 2 basically is the same, but:
> 
> Persona 1:	path_grouping_policy = multibus
> 		failback = manual
> 		prio = const
> 
> Persona 2:	path_grouping_policy = group_by_prio
> 		failback = immediate
> 		prio = alua				(this is irrelevant, alua-prio is autodetected)
> 		hardware_handler= "1 alua"		(this is irrelevant, all hardware handlers are autodetected)
> 
> With 3PAR-OS 3.1.3, or later, you should use "Persona 2"

The above change plus

retain_attached_hw_handler = yes
detect_prio = yes

should work with persona 1 and 2.

Sebastian

Re: [PATCH 16/18] multipath-tools: Use ALUA for HP 3PAR

[Xose Vazquez Perez]

On 08/03/2016 02:17 AM, Sebastian Herbszt wrote:
> Xose Vazquez Perez wrote:
>> On 07/31/2016 09:06 PM, Sebastian Herbszt wrote:
>>
>>> Xose Vazquez Perez wrote:
>>>>
>>>> No. It's related to hardware_handler, "alua" in this case.
>>>
>>> So how does the output of 'multipath -ll' looks like for persona 1 and 2
>>> with and without 'retain_attached_hw_handler'?
>>
>> retain_attached_hw_handler is innocuous.
>> The paths grouping policy is controlled by the "path_grouping_policy" keyword,
>> multibus vs. group_by_prio. See man page.
> 
> multibus should equal
> 
> path_grouping_policy = group_by_prio
> prio = const
> 
>> Persona 1 and 2 basically is the same, but:
>>
>> Persona 1:	path_grouping_policy = multibus
>> 		failback = manual
>> 		prio = const
>>
>> Persona 2:	path_grouping_policy = group_by_prio
>> 		failback = immediate
>> 		prio = alua				(this is irrelevant, alua-prio is autodetected)
>> 		hardware_handler= "1 alua"		(this is irrelevant, all hardware handlers are autodetected)
>>
>> With 3PAR-OS 3.1.3, or later, you should use "Persona 2"
> 
> The above change plus
> 
> retain_attached_hw_handler = yes
> detect_prio = yes
> 
> should work with persona 1 and 2.


3PAR arrays are Symmetric Active/Active and with ALUA support.


- With Persona 1/Generic(UARepLun, SESLun), only one mode is supported:

o Symmetric Active/Active
        {
                .vendor        = "3PARdata",
                .product       = "VV",
                .pgpolicy      = MULTIBUS,
                .no_path_retry = 18,
        },


- With Persona 2/Generic-ALUA(UARepLun, SESLun, ALUA), both of them are supported:

o Symmetric Active/Active
        {
                .vendor        = "3PARdata",
                .product       = "VV",
                .pgpolicy      = MULTIBUS,
                .no_path_retry = 18,
        },

o Symmetric Active/Active + ALUA
        {
                .vendor        = "3PARdata",
                .product       = "VV",
                .pgpolicy      = GROUP_BY_PRIO,
                .pgfailback    = -FAILBACK_IMMEDIATE,
                .hwhandler     = "1 alua",
                .prio_name     = PRIO_ALUA,
                .no_path_retry = 18,
        },


Thera are also others Symmetric Active/Active arrays with support of ALUA.
At least, EMC/SYMMETRIX and IBM/2810XIV.