All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags
@ 2016-07-30  2:09 Chen Feng
  2016-08-08 18:44 ` Laura Abbott
  0 siblings, 1 reply; 2+ messages in thread
From: Chen Feng @ 2016-07-30  2:09 UTC (permalink / raw)
  To: puck.chen, labbott, sumit.semwal, gregkh, arve, riandrews, devel,
	linux-kernel
  Cc: suzhuangluan, dan.zhao, oliver.fu, qijiwen, saberlily.xia,
	xuyiping, puck.chen

It's useful to show the current memory in detail when alloc failed.

And, there may be a lot of high order alloc failed, just show memory
when an order 0 alloc failed.

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
---
 drivers/staging/android/ion/ion_system_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
index b69dfc7..c3b7975 100644
--- a/drivers/staging/android/ion/ion_system_heap.c
+++ b/drivers/staging/android/ion/ion_system_heap.c
@@ -28,7 +28,7 @@
 
 static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
 				     __GFP_NORETRY) & ~__GFP_RECLAIM;
-static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
+static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO);
 static const unsigned int orders[] = {8, 4, 0};
 static const int num_orders = ARRAY_SIZE(orders);
 static int order_to_index(unsigned int order)
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags
  2016-07-30  2:09 [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags Chen Feng
@ 2016-08-08 18:44 ` Laura Abbott
  0 siblings, 0 replies; 2+ messages in thread
From: Laura Abbott @ 2016-08-08 18:44 UTC (permalink / raw)
  To: Chen Feng, sumit.semwal, gregkh, arve, riandrews, devel, linux-kernel
  Cc: suzhuangluan, dan.zhao, oliver.fu, qijiwen, saberlily.xia,
	xuyiping, puck.chen

On 07/29/2016 07:09 PM, Chen Feng wrote:
> It's useful to show the current memory in detail when alloc failed.
>
> And, there may be a lot of high order alloc failed, just show memory
> when an order 0 alloc failed.
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
>  drivers/staging/android/ion/ion_system_heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c
> index b69dfc7..c3b7975 100644
> --- a/drivers/staging/android/ion/ion_system_heap.c
> +++ b/drivers/staging/android/ion/ion_system_heap.c
> @@ -28,7 +28,7 @@
>
>  static gfp_t high_order_gfp_flags = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN |
>  				     __GFP_NORETRY) & ~__GFP_RECLAIM;
> -static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO | __GFP_NOWARN);
> +static gfp_t low_order_gfp_flags  = (GFP_HIGHUSER | __GFP_ZERO);
>  static const unsigned int orders[] = {8, 4, 0};
>  static const int num_orders = ARRAY_SIZE(orders);
>  static int order_to_index(unsigned int order)
>

Acked-by: Laura Abbott <labbott@redhat.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-08 18:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-30  2:09 [PATCH] staging: ion: remove __GFP_NOWARN when use low order gfp flags Chen Feng
2016-08-08 18:44 ` Laura Abbott

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.